Lazily evaluate EvalErrorKind::*.into() calls. #50051

nnethercote · Apr 18, 2018

eval_context.rs calls ok_or in multiple places with an eagerly
evaluated EvalErrorKind::*.into() argument, which calls
EvalError::from(), which calls env::var("MIRI_BACKTRACE"), which
allocates a String. This code is hot enough for this to have a
measurable effect on some benchmarks.

This patch changes the ok_or calls into ok_or_else, thus avoiding
the evaluations when they're not needed. As a result, most of the
rustc-perf benchmarks get a measurable speedup, particularly the
shorter-running ones, where the improvement is as high as 6%.

Output from rustc-perf, comparing stage 2 builds with jemalloc disabled:

coercions
	avg: -1.8%	min: -6.0%	max: -0.0%
helloworld-opt
	avg: -3.7%	min: -4.0%	max: -3.4%
helloworld
	avg: -3.7%	min: -3.9%	max: -3.5%
parser
	avg: -3.5%	min: -3.9%	max: -3.1%
unify-linearly-opt
	avg: -3.2%	min: -3.8%	max: -2.8%
unify-linearly
	avg: -3.2%	min: -3.7%	max: -2.8%
parser-opt
	avg: -3.2%	min: -3.6%	max: -2.8%
clap-rs
	avg: -0.9%	min: -3.6%	max: 0.1%
encoding
	avg: -1.9%	min: -3.0%	max: -1.2%
clap-rs-opt
	avg: -0.8%	min: -2.7%	max: -0.1%
helloworld-check
	avg: -1.9%	min: -2.2%	max: -1.7%
deeply-nested-check
	avg: -1.4%	min: -2.1%	max: -0.9%
issue-46449-opt
	avg: -0.7%	min: -2.0%	max: -0.3%
unify-linearly-check
	avg: -1.5%	min: -1.9%	max: -1.2%
issue-46449
	avg: -1.0%	min: -1.8%	max: -0.8%
deeply-nested-opt
	avg: -0.7%	min: -1.7%	max: -0.2%
deeply-nested
	avg: -1.0%	min: -1.6%	max: -0.6%
parser-check
	avg: -1.3%	min: -1.6%	max: -0.8%
encoding-check
	avg: -1.5%	min: -1.6%	max: -1.2%
tuple-stress
	avg: -0.9%	min: -1.5%	max: 0.0%
tuple-stress-opt
	avg: -1.0%	min: -1.5%	max: -0.3%
issue-46449-check
	avg: -1.3%	min: -1.4%	max: -1.0%
encoding-opt
	avg: -1.1%	min: -1.2%	max: -0.9%
regression-31157
	avg: -0.7%	min: -1.2%	max: -0.2%
regression-31157-check
	avg: -0.8%	min: -1.2%	max: -0.5%
futures-check
	avg: -0.8%	min: -1.2%	max: -0.4%
unused-warnings-opt
	avg: -1.0%	min: -1.2%	max: -0.9%
unused-warnings
	avg: -1.0%	min: -1.1%	max: -0.9%
coercions-opt
	avg: -0.6%	min: -1.0%	max: -0.2%
inflate-check
	avg: -0.4%	min: -0.9%	max: -0.1%
regex-check
	avg: -0.8%	min: -0.9%	max: -0.5%
piston-image-check
	avg: -0.8%	min: -0.9%	max: -0.8%
deep-vector
	avg: -0.3%	min: -0.9%	max: 0.1%
futures
	avg: -0.5%	min: -0.8%	max: -0.2%
futures-opt
	avg: -0.5%	min: -0.7%	max: -0.1%
html5ever
	avg: -0.6%	min: -0.7%	max: -0.4%
tokio-webpush-simple-check
	avg: -0.2%	min: -0.7%	max: 0.1%
piston-image-opt
	avg: -0.3%	min: -0.7%	max: -0.1%
regex
	avg: -0.4%	min: -0.7%	max: -0.1%
piston-image
	avg: -0.4%	min: -0.7%	max: -0.2%
regex-opt
	avg: -0.3%	min: -0.7%	max: 0.1%
tokio-webpush-simple-opt
	avg: -0.2%	min: -0.6%	max: 0.0%
coercions-check
	avg: -0.3%	min: -0.6%	max: -0.1%
hyper
	avg: -0.4%	min: -0.6%	max: -0.2%
syn-opt
	avg: -0.3%	min: -0.6%	max: -0.0%
hyper-check
	avg: -0.5%	min: -0.6%	max: -0.3%
syn-check
	avg: -0.4%	min: -0.5%	max: -0.2%
hyper-opt
	avg: -0.3%	min: -0.5%	max: -0.1%
html5ever-opt
	avg: -0.3%	min: -0.5%	max: -0.2%
syn
	avg: -0.2%	min: -0.4%	max: -0.1%
deep-vector-opt
	avg: -0.2%	min: -0.4%	max: 0.1%
tokio-webpush-simple
	avg: -0.2%	min: -0.4%	max: -0.1%
inflate
	avg: -0.2%	min: -0.4%	max: -0.1%
inflate-opt
	avg: -0.2%	min: -0.4%	max: -0.0%
regression-31157-opt
	avg: -0.1%	min: -0.4%	max: 0.0%
html5ever-check
	avg: -0.3%	min: -0.4%	max: -0.2%
unused-warnings-check
	avg: -0.2%	min: -0.3%	max: -0.2%
script-servo-check
	avg: -0.1%	min: -0.3%	max: 0.0%
crates.io-check
	avg: -0.2%	min: -0.3%	max: -0.0%
script-servo
	avg: -0.1%	min: -0.2%	max: 0.0%
clap-rs-check
	avg: 0.0%	min: -0.1%	max: 0.2%
deep-vector-check
	avg: -0.0%	min: -0.2%	max: 0.2%
tuple-stress-check
	avg: -0.1%	min: -0.2%	max: 0.0%
crates.io-opt
	avg: -0.1%	min: -0.2%	max: 0.0%
crates.io
	avg: -0.1%	min: -0.2%	max: -0.0%
script-servo-opt
	avg: -0.0%	min: -0.1%	max: 0.0%

rust-highfive · Apr 18, 2018

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:00:46] configure: rust.quiet-tests     := True
---
[00:01:26] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:26] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:26] Build completed unsuccessfully in 0:00:40
[00:01:26] make: *** [prepare] Error 1
[00:01:26] Makefile:81: recipe for target 'prepare' failed
[00:01:26] Command failed. Attempt 2/5:
[00:01:26]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:27] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:27] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:27] Build completed unsuccessfully in 0:00:00
[00:01:27] Makefile:81: recipe for target 'prepare' failed
[00:01:27] make: *** [prepare] Error 1
[00:01:27] Command failed. Attempt 3/5:
[00:01:27]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:28] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:28] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:28] Build completed unsuccessfully in 0:00:00
[00:01:28] Makefile:81: recipe for target 'prepare' failed
[00:01:28] make: *** [prepare] Error 1
[00:01:28] Command failed. Attempt 4/5:
[00:01:28]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:28] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:28] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:28] Build completed unsuccessfully in 0:00:00
[00:01:28] make: *** [prepare] Error 1
[00:01:28] Makefile:81: recipe for target 'prepare' failed
[00:01:28] Command failed. Attempt 5/5:
[00:01:28]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:29] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:29] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:29] Build completed unsuccessfully in 0:00:00
[00:01:29] Makefile:81: recipe for target 'prepare' failed
[00:01:29] make: *** [prepare] Error 1
[00:01:29] The command has failed after 5 attempts.
---
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:318dc532:start=1524053154214451560,finish=1524053154221301761,duration=6850201
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:0968533b
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:0968533b:start=1524053154227585569,finish=1524053154233938051,duration=6352482
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:12f9e700
$ dmesg | grep -i kill
[   10.813862] init: failsafe main process (1094) killed by TERM signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · Apr 18, 2018

Please do not update the stdsimd and rustfmt submodules.

Mark-Simulacrum · Apr 18, 2018

@bors try

bors · Apr 18, 2018

⌛️ Trying commit 201e9ad with merge 0940946...

bors · Apr 18, 2018

💔 Test failed - status-travis

rust-highfive · Apr 18, 2018

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

$ git clone --depth=2 --branch=try https://github.com/rust-lang/rust.git rust-lang/rust
---
[00:01:59] configure: rust.quiet-tests     := True
---
[00:02:34] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:34] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:34] Build completed unsuccessfully in 0:00:35
[00:02:34] make: *** [prepare] Error 1
[00:02:34] Command failed. Attempt 2/5:
[00:02:34]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:35] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:35] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:35] Build completed unsuccessfully in 0:00:00
[00:02:35] make: *** [prepare] Error 1
[00:02:35] Command failed. Attempt 3/5:
[00:02:35]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:35] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:35] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:35] Build completed unsuccessfully in 0:00:00
[00:02:35] make: *** [prepare] Error 1
[00:02:35] Command failed. Attempt 4/5:
[00:02:35]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:36] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:36] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:36] Build completed unsuccessfully in 0:00:00
[00:02:36] make: *** [prepare] Error 1
[00:02:36] Command failed. Attempt 5/5:
[00:02:36]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:36] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:36] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:36] Build completed unsuccessfully in 0:00:00
[00:02:36] make: *** [prepare] Error 1
[00:02:36] The command has failed after 5 attempts.
---
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:0142af8c:start=1524058659328268684,finish=1524058659338198109,duration=9929425
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:0f1eab80
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:0f1eab80:start=1524058659345189776,finish=1524058659354493066,duration=9303290
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:2ee9494e
$ dmesg | grep -i kill
[   10.388111] init: failsafe main process (1093) killed by TERM signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · Apr 18, 2018

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

$ git clone --depth=2 --branch=try https://github.com/rust-lang/rust.git rust-lang/rust
---
[00:01:59] configure: rust.quiet-tests     := True
---
[00:02:34] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:34] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:34] Build completed unsuccessfully in 0:00:35
[00:02:34] make: *** [prepare] Error 1
[00:02:34] Command failed. Attempt 2/5:
[00:02:34]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:35] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:35] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:35] Build completed unsuccessfully in 0:00:00
[00:02:35] make: *** [prepare] Error 1
[00:02:35] Command failed. Attempt 3/5:
[00:02:35]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:35] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:35] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:35] Build completed unsuccessfully in 0:00:00
[00:02:35] make: *** [prepare] Error 1
[00:02:35] Command failed. Attempt 4/5:
[00:02:35]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:36] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:36] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:36] Build completed unsuccessfully in 0:00:00
[00:02:36] make: *** [prepare] Error 1
[00:02:36] Command failed. Attempt 5/5:
[00:02:36]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:36] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:36] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:36] Build completed unsuccessfully in 0:00:00
[00:02:36] make: *** [prepare] Error 1
[00:02:36] The command has failed after 5 attempts.
---
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:0142af8c:start=1524058659328268684,finish=1524058659338198109,duration=9929425
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:0f1eab80
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:0f1eab80:start=1524058659345189776,finish=1524058659354493066,duration=9303290
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:2ee9494e
$ dmesg | grep -i kill
[   10.388111] init: failsafe main process (1093) killed by TERM signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

nnethercote · Apr 18, 2018

I updated the patch to remove the unintentional submodule changes. Sometimes that happens to me when I update my repo, I don't understand why.

Mark-Simulacrum · Apr 18, 2018

@bors r+

cc @oli-obk -- perhaps useful to know for future miri-related work

bors · Apr 18, 2018

📌 Commit 5070dea has been approved by Mark-Simulacrum

oli-obk · Apr 19, 2018

Jup, I already saw it, and I fully agree this is good. I really am bad at writing code without clippy looking over my shoulder :(

bors · Apr 20, 2018

⌛️ Testing commit 5070dea with merge f4a3df1...

bors · Apr 20, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing f4a3df1 to master...

bors added the S-waiting-on-author label Apr 18, 2018

nnethercote force-pushed the nnethercote:no-env-var branch from 201e9ad to 5070dea Apr 18, 2018

bors added S-waiting-on-bors and removed S-waiting-on-author labels Apr 18, 2018

bors merged commit 5070dea into rust-lang:master Apr 20, 2018
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

nnethercote deleted the nnethercote:no-env-var branch Apr 20, 2018

Pzixel referenced this pull request Jun 2, 2018
Closed
Deprecate `ok_or` method #51292

rust-lang/rust

Lazily evaluate EvalErrorKind::*.into() calls. #50051

Lazily evaluate EvalErrorKind::*.into() calls. #50051

nnethercote commented Apr 18, 2018 •

edited by kennytm

This comment has been minimized.

rust-highfive commented Apr 18, 2018

This comment has been minimized.

kennytm commented Apr 18, 2018

This comment has been minimized.

Mark-Simulacrum commented Apr 18, 2018

This comment has been minimized.

bors commented Apr 18, 2018

bors added a commit that referenced this pull request Apr 18, 2018

This comment has been minimized.

bors commented Apr 18, 2018

This comment has been minimized.

rust-highfive commented Apr 18, 2018

bors added the S-waiting-on-author label Apr 18, 2018

This comment has been minimized.

rust-highfive commented Apr 18, 2018

nnethercote force-pushed the nnethercote:no-env-var branch from `201e9ad` to `5070dea` Apr 18, 2018

This comment has been minimized.

nnethercote commented Apr 18, 2018

This comment has been minimized.

Mark-Simulacrum commented Apr 18, 2018

This comment has been minimized.

bors commented Apr 18, 2018

bors added S-waiting-on-bors and removed S-waiting-on-author labels Apr 18, 2018

This comment has been minimized.

oli-obk commented Apr 19, 2018

This comment has been minimized.

bors commented Apr 20, 2018

bors added a commit that referenced this pull request Apr 20, 2018

This comment has been minimized.

bors commented Apr 20, 2018

bors merged commit `5070dea` into rust-lang:master Apr 20, 2018
2 checks passed

2 checks passed

nnethercote deleted the nnethercote:no-env-var branch Apr 20, 2018

Pzixel referenced this pull request Jun 2, 2018

Deprecate `ok_or` method #51292

rust-lang/rust

Join GitHub today

Lazily evaluate EvalErrorKind::*.into() calls. #50051

Conversation

nnethercote commented Apr 18, 2018 • edited by kennytm

This comment has been minimized.

rust-highfive commented Apr 18, 2018

This comment has been minimized.

kennytm commented Apr 18, 2018

This comment has been minimized.

Mark-Simulacrum commented Apr 18, 2018

This comment has been minimized.

bors commented Apr 18, 2018

bors added a commit that referenced this pull request Apr 18, 2018

This comment has been minimized.

bors commented Apr 18, 2018

This comment has been minimized.

rust-highfive commented Apr 18, 2018

bors added the S-waiting-on-author label Apr 18, 2018

This comment has been minimized.

rust-highfive commented Apr 18, 2018

nnethercote force-pushed the nnethercote:no-env-var branch from 201e9ad to 5070dea Apr 18, 2018

This comment has been minimized.

nnethercote commented Apr 18, 2018

This comment has been minimized.

Mark-Simulacrum commented Apr 18, 2018

This comment has been minimized.

bors commented Apr 18, 2018

bors added S-waiting-on-bors and removed S-waiting-on-author labels Apr 18, 2018

This comment has been minimized.

oli-obk commented Apr 19, 2018

This comment has been minimized.

bors commented Apr 20, 2018

bors added a commit that referenced this pull request Apr 20, 2018

This comment has been minimized.

bors commented Apr 20, 2018

Hide details View details bors merged commit 5070dea into rust-lang:master Apr 20, 2018 2 checks passed

2 checks passed

nnethercote deleted the nnethercote:no-env-var branch Apr 20, 2018

Pzixel referenced this pull request Jun 2, 2018

Deprecate `ok_or` method #51292

nnethercote commented Apr 18, 2018 •

edited by kennytm

nnethercote force-pushed the nnethercote:no-env-var branch from `201e9ad` to `5070dea` Apr 18, 2018

bors merged commit `5070dea` into rust-lang:master Apr 20, 2018
2 checks passed