Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bury Error::description() #50163

Merged
merged 3 commits into from Apr 30, 2018
Merged

Bury Error::description() #50163

merged 3 commits into from Apr 30, 2018

Conversation

@kornelski
Copy link
Contributor

kornelski commented Apr 22, 2018

Second attempt of #49536 rust-lang/rfcs#2230

The exact wording of the default implementation is still up in the air, but I think it's a detail that can be amended later.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Apr 22, 2018

r? @Kimundi

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Apr 22, 2018

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:54:38] ....i......................................................................................test [run-pass] run-pass/mir_heavy_promoted.rs has been running for over 60 seconds
[00:54:43] .........
[00:55:15] ....................................................................................................
[00:55:44] ......................................................................ii............................
[00:56:37] .................................i....................................................i.ii.......test [run-pass] run-pass/saturating-float-casts.rs has been running for over 60 seconds
[00:57:20] ..............................................................................................iiiiii
[00:57:48] i...................................................................................................
[00:58:18] ....................................................................................................
[00:58:46] ....................................................................................................
---
[01:31:22] travis_fold:end:stage0-linkchecker

[01:31:22] travis_time:end:stage0-linkchecker:start=1524427076559403483,finish=1524427079421650858,duration=2862247375

[01:31:33] book/first-edition/print.html:12010: broken link fragment `#tymethod.description` pointing to `std/error/trait.Error.html`
[01:31:33] book/first-edition/error-handling.html:1372: broken link fragment `#tymethod.description` pointing to `std/error/trait.Error.html`
[01:31:41] thread 'main' panicked at 'found some broken links', tools/linkchecker/main.rs:49:9
[01:31:41] 
[01:31:41] 
[01:31:41] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:31:41] expected success, got: exit code: 101
[01:31:41] expected success, got: exit code: 101
[01:31:41] 
[01:31:41] 
[01:31:41] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:31:41] Build completed unsuccessfully in 0:47:47
[01:31:41] make: *** [check] Error 1
[01:31:41] Makefile:58: recipe for target 'check' failed

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Apr 22, 2018

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:54:26] ....i....................................................................................test [run-pass] run-pass/mir_heavy_promoted.rs has been running for over 60 seconds
[00:54:31] ...........
[00:55:04] ....................................................................................................
[00:55:34] ......................................................................ii............................
[00:56:26] .................................i....................................................i.ii......test [run-pass] run-pass/saturating-float-casts.rs has been running for over 60 seconds
[00:57:11] ..............................................................................................iiiiii
[00:57:39] i...................................................................................................
[00:58:09] ....................................................................................................
[00:58:35] ....................................................................................................
---
[01:31:18] travis_fold:end:stage0-linkchecker

[01:31:18] travis_time:end:stage0-linkchecker:start=1524433456208041777,finish=1524433459099048407,duration=2891006630

[01:31:28] book/unsized-types.html:46: broken link fragment `#dynamically-sized-types--sized` pointing to `book/second-edition/ch19-04-advanced-types.html`
[01:31:36] thread 'main' panicked at 'found some broken links', tools/linkchecker/main.rs:49:9
[01:31:36] 
[01:31:36] 
[01:31:36] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:31:36] expected success, got: exit code: 101
[01:31:36] expected success, got: exit code: 101
[01:31:36] 
[01:31:36] 
[01:31:36] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:31:36] Build completed unsuccessfully in 0:47:55
[01:31:36] Makefile:58: recipe for target 'check' failed
[01:31:36] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1b687e4c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kornelski added a commit to kornelski/book that referenced this pull request Apr 23, 2018
@Kimundi

This comment has been minimized.

Copy link
Member

Kimundi commented Apr 25, 2018

Seems fine, I'll r+ as soon as the tests pass.

SimonSapin and others added 2 commits Mar 31, 2018
… rather than the module’s.

Remove code definition of the Error trait from its doc-comment

It was out of date, and rustdoc already shows the same information.

Add a default impl for Error::description and document it as deprecated.

It is redundant with Display while being much less flexible for implementors.

This is only a "soft" deprecation: it is not worth the hassle of a warning to existing users.

Tweak Error trait docs to reflect actual requirements
@kornelski kornelski force-pushed the kornelski:error branch from c993174 to cacc8bc Apr 25, 2018
@kornelski kornelski force-pushed the kornelski:error branch from cacc8bc to 1912f39 Apr 25, 2018
@kornelski

This comment has been minimized.

Copy link
Contributor Author

kornelski commented Apr 26, 2018

It passes the tests now

@pietroalbini

This comment has been minimized.

Copy link
Member

pietroalbini commented Apr 30, 2018

Ping from triage @Kimundi! The tests are passing now.

@Kimundi

This comment has been minimized.

Copy link
Member

Kimundi commented Apr 30, 2018

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Apr 30, 2018

📌 Commit 1912f39 has been approved by Kimundi

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Apr 30, 2018

⌛️ Testing commit 1912f39 with merge 4745092...

bors added a commit that referenced this pull request Apr 30, 2018
Bury Error::description()

Second attempt of #49536 rust-lang/rfcs#2230

The exact wording of the default implementation is still up in the air, but I think it's a detail that can be amended later.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Apr 30, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Kimundi
Pushing 4745092 to master...

@bors bors merged commit 1912f39 into rust-lang:master Apr 30, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@kornelski kornelski deleted the kornelski:error branch Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.