Add as_nanos function to Duration #50167

fintelia · Apr 22, 2018

Duration has historically lacked a way to get the actual number of nanoseconds it contained as a normal Rust type because u64 was of insufficient range, and f64 of insufficient precision. The u128 type solves both issues, so I propose adding an as_nanos function to expose the capability.

rust-highfive · Apr 22, 2018

r? @aidanhs

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · Apr 22, 2018

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:13:19] ....................................................................................................
[01:13:34] ....................................................................................................
[01:13:48] ....................................................................................................
[01:14:08] ....................................................................................................
[01:14:23] ....................i................................................F.................
[01:14:23] 
[01:14:23] 
[01:14:23] ---- time.rs - time::Duration::as_nanos (line 270) stdout ----
[01:14:23]  error[E0658]: use of unstable library feature 'duration_nanos' (see issue #50167)
[01:14:23]  --> time.rs:274:21
[01:14:23]   |
[01:14:23] 7 | assert_eq!(duration.as_nanos(), 5730023852);
[01:14:23]   |
[01:14:23]   |
[01:14:23]   = help: add #![feature(duration_nanos)] to the crate attributes to enable
[01:14:23] 
[01:14:23] thread 'time.rs - time::Duration::as_nanos (line 270)' panicked at 'couldn't compile the test', librustdoc/test.rs:321:13
[01:14:23] 
[01:14:23] 
[01:14:23] failures:
[01:14:23]     time.rs - time::Duration::as_nanos (line 270)
[01:14:23]     time.rs - time::Duration::as_nanos (line 270)
[01:14:23] 
[01:14:23] test result: FAILED. 1984 passed; 1 failed; 2 ignored; 0 measured; 0 filtered out
[01:14:23] 
[01:14:23] error: test failed, to rerun pass '--doc'
[01:14:23] 
[01:14:23] 
[01:14:23] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "core" "--" "--quiet"
[01:14:23] 
[01:14:23] 
[01:14:23] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:14:23] Build completed unsuccessfully in 0:34:30
[01:14:23] Build completed unsuccessfully in 0:34:30
[01:14:23] Makefile:58: recipe for target 'check' failed
[01:14:23] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:2b36015a
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · Apr 24, 2018

kennytm reviewed Apr 24, 2018

View changes

kennytm · Apr 24, 2018

src/libcore/time.rs

+    /// let duration = Duration::new(5, 730023852);
+    /// assert_eq!(duration.as_nanos(), 5730023852);
+    /// ```
+    #[unstable(feature = "duration_nanos", issue = "50167")]


The tracking issue number should be a new issue, not this PR.

pietroalbini · Apr 30, 2018

Reassigning this to someone from the libs team.
r? @sfackler

sfackler · May 1, 2018

We should add similar accessors for milliseconds and microseconds at the same time for consistency with the subsec methods.

cc @rust-lang/libs

fintelia · May 1, 2018

@sfackler I can make that change. Any thoughts on what the feature should be called then? "duration_as_nanos" isn't really a great name if it also adds as_millis() and as_micros(). Perhaps "duration_as_u128"?

sfackler · May 2, 2018

Sure, seems reasonable.

pietroalbini · May 14, 2018

Ping from triage @fintelia! It's been a while since we heard from you, will you have time to work on this again soon?

fintelia · May 14, 2018

Sorry about that. I'm probably going to be busy for about a week longer, so if someone else wants to take over making those changes, feel free

pietroalbini · May 14, 2018

@fintelia don't worry, we just want to make sure you still remember about the PR ;)
Someone from triage will ping you next week.

clarfon · May 27, 2018

clarfon reviewed May 27, 2018

View changes

clarfon · May 27, 2018

src/libcore/time.rs

+    #[unstable(feature = "duration_as_u128", issue = "50202")]
+    #[inline]
+    pub fn as_millis(&self) -> u128 {
+        self.secs as u128 * MILLIS_PER_SEC as u128 + self.nanos as u128 / NANOS_PER_MILLI as u128


Nit: self.nanos as u128 / NANOS_PER_MILLI as u128 should be replaced with (self.nanos / NANOS_PER_MILLI) as u128. The former requires doing 128-bit arithmetic on a 32-bit number, which is redundant.

clarfon · May 27, 2018

clarfon reviewed May 27, 2018

View changes

clarfon · May 27, 2018

src/libcore/time.rs

+    #[unstable(feature = "duration_as_u128", issue = "50202")]
+    #[inline]
+    pub fn as_micros(&self) -> u128 {
+        self.secs as u128 * MICROS_PER_SEC as u128 + self.nanos as u128 / NANOS_PER_MICRO as u128


See comment from as_nanos

clarfon · May 27, 2018

clarfon reviewed May 27, 2018

View changes

clarfon · May 27, 2018

src/libcore/time.rs

+    #[unstable(feature = "duration_as_u128", issue = "50202")]
+    #[inline]
+    pub fn as_nanos(&self) -> u128 {
+        self.secs as u128 * NANOS_PER_SEC as u128 + self.nanos as u128


See comment from as_nanos

shepmaster · Jun 2, 2018

Ping from triage, @sfackler !

sfackler · Jun 2, 2018

Oops - seems good to me!

@bors r+

bors · Jun 2, 2018

📌 Commit fc89566 has been approved by sfackler

bors · Jun 3, 2018

⌛️ Testing commit fc89566 with merge 3515dab...

bors · Jun 3, 2018

💥 Test timed out

fintelia added some commits Apr 22, 2018

Add as_nanos function to duration

43baa2c

Use NANOS_PER_SEC constant

Loading status checks…

57b2067

rust-highfive assigned aidanhs Apr 22, 2018

rust-highfive added the S-waiting-on-review label Apr 22, 2018

Add issue number

Loading status checks…

dc9e27d

Doctest of feature requires that feature

Loading status checks…

b66ab1a

kennytm added the T-libs label Apr 24, 2018

fintelia referenced this pull request Apr 24, 2018
Closed
Tracking Issue: Duration::{as_nanos, as_micros, as_millis} #50202

Issue number should be for tracking issue not PR

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

799eda4

rust-highfive assigned sfackler and unassigned aidanhs Apr 30, 2018

shepmaster added S-waiting-on-author and removed S-waiting-on-review labels May 6, 2018

Add as_micros and as_millis methods

Loading status checks…

99f5136

kennytm added S-waiting-on-review and removed S-waiting-on-author labels May 20, 2018

lolgesten referenced this pull request May 21, 2018
Closed
Add as_millis function to std::time::Duration #1545

Avoid 128-bit arithmetic where possible

Loading status checks…

fc89566

bors added S-waiting-on-bors and removed S-waiting-on-review labels Jun 2, 2018

Mark-Simulacrum referenced this pull request Jun 2, 2018
Merged
Rollup of 6 pull requests #51310

bors merged commit fc89566 into rust-lang:master Jun 3, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

bors added S-waiting-on-review and removed S-waiting-on-bors labels Jun 3, 2018

rust-lang/rust

Join GitHub today

Add as_nanos function to Duration #50167

Conversation

fintelia commented Apr 22, 2018

fintelia added some commits Apr 22, 2018

rust-highfive assigned aidanhs Apr 22, 2018

This comment has been minimized.

rust-highfive commented Apr 22, 2018

rust-highfive added the S-waiting-on-review label Apr 22, 2018

This comment was marked as resolved.

rust-highfive commented Apr 22, 2018

kennytm added the T-libs label Apr 24, 2018

kennytm reviewed Apr 24, 2018 View changes

This comment has been minimized.

This comment has been minimized.

fintelia referenced this pull request Apr 24, 2018

This comment has been minimized.

pietroalbini commented Apr 30, 2018

rust-highfive assigned sfackler and unassigned aidanhs Apr 30, 2018

This comment has been minimized.

sfackler commented May 1, 2018

This comment has been minimized.

fintelia commented May 1, 2018

This comment has been minimized.

sfackler commented May 2, 2018

shepmaster added S-waiting-on-author and removed S-waiting-on-review labels May 6, 2018

This comment has been minimized.

pietroalbini commented May 14, 2018

This comment has been minimized.

fintelia commented May 14, 2018

This comment has been minimized.

pietroalbini commented May 14, 2018

kennytm added S-waiting-on-review and removed S-waiting-on-author labels May 20, 2018

lolgesten referenced this pull request May 21, 2018

clarfon reviewed May 27, 2018 View changes

This comment has been minimized.

clarfon reviewed May 27, 2018 View changes

This comment has been minimized.

clarfon reviewed May 27, 2018 View changes

This comment has been minimized.

This comment has been minimized.

shepmaster commented Jun 2, 2018

This comment has been minimized.

sfackler commented Jun 2, 2018

This comment has been minimized.

bors commented Jun 2, 2018

bors added S-waiting-on-bors and removed S-waiting-on-review labels Jun 2, 2018

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 2, 2018

Mark-Simulacrum referenced this pull request Jun 2, 2018

bors added a commit that referenced this pull request Jun 2, 2018

Hide details View details bors merged commit fc89566 into rust-lang:master Jun 3, 2018 1 check passed

1 check passed

This comment has been minimized.

bors commented Jun 3, 2018

This comment has been minimized.

bors commented Jun 3, 2018

bors added S-waiting-on-review and removed S-waiting-on-bors labels Jun 3, 2018

kennytm reviewed Apr 24, 2018

View changes

clarfon reviewed May 27, 2018

View changes

clarfon reviewed May 27, 2018

View changes

clarfon reviewed May 27, 2018

View changes

bors merged commit `fc89566` into rust-lang:master Jun 3, 2018
1 check passed