Use FxHashMap in syntax_pos::symbol::Interner::intern. #50174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it's faster than HashMap. This change reduces the time taken for a few of the rustc-perf benchmarks, mostly the small ones, by up to 5%.
|
Thanks, @nnethercote! @bors r+ |
|
📌 Commit f7d4c97 has been approved by |
bors
added
the
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Apr 24, 2018
…ichaelwoerister
Use FxHashMap in syntax_pos::symbol::Interner::intern.
Because it's faster than HashMap.
This change reduces the time taken for a few of the rustc-perf
benchmarks, mostly the small ones, by up to 5%.
```
coercions
avg: -1.3% min: -5.5% max: -0.0%
helloworld-check
avg: -2.3% min: -3.5% max: -1.8%
deeply-nested-check
avg: -1.4% min: -3.2% max: -0.5%
tuple-stress-opt
avg: -0.7% min: -2.0% max: -0.1%
unify-linearly-check
avg: -1.2% min: -1.9% max: -0.6%
coercions-check
avg: -0.8% min: -1.3% max: -0.4%
unused-warnings-check
avg: -1.0% min: -1.3% max: -0.8%
deeply-nested-opt
avg: -0.5% min: -1.2% max: -0.2%
deeply-nested
avg: -0.7% min: -1.2% max: -0.4%
helloworld
avg: -0.8% min: -1.1% max: -0.7%
tuple-stress-check
avg: -0.5% min: -1.0% max: -0.1%
unused-warnings
avg: -0.8% min: -1.0% max: -0.7%
unused-warnings-opt
avg: -0.8% min: -1.0% max: -0.7%
coercions-opt
avg: -0.5% min: -1.0% max: -0.1%
helloworld-opt
avg: -0.7% min: -1.0% max: -0.6%
```
bors
added a commit
that referenced
this pull request
Apr 24, 2018
Rollup of 11 pull requests Successful merges: - #49461 (std: Child::kill() returns error if process has already exited) - #49727 (Add Cell::update) - #49812 (Fix revision support for UI tests.) - #49829 (Add doc links to `std::os` extension traits) - #49906 (Stabilize `std::hint::unreachable_unchecked`.) - #49970 (Deprecate Read::chars and char::decode_utf8) - #49985 (don't see issue #0) - #50118 (fix search bar bug) - #50139 (encourage descriptive issue titles) - #50174 (Use FxHashMap in syntax_pos::symbol::Interner::intern.) - #50185 (core: Fix overflow in `int::mod_euc` when `self < 0 && rhs == MIN`) Failed merges:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it's faster than HashMap.
This change reduces the time taken for a few of the rustc-perf
benchmarks, mostly the small ones, by up to 5%.