Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRename trans to codegen everywhere. #50615
Conversation
rust-highfive
assigned
nikomatsakis
May 10, 2018
This comment has been minimized.
This comment has been minimized.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
label
May 10, 2018
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
irinagpopa
force-pushed the
irinagpopa:rename-trans
branch
from
d6d9e06
to
4ce00fa
May 10, 2018
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
cc @michaelwoerister on the choice of "mono(morphization) item" to replace "trans item". |
This comment has been minimized.
This comment has been minimized.
|
The naming changes are fine by me. |
irinagpopa
force-pushed the
irinagpopa:rename-trans
branch
2 times, most recently
from
36edee7
to
3fcc1e5
May 12, 2018
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
irinagpopa
force-pushed the
irinagpopa:rename-trans
branch
2 times, most recently
from
78b6e33
to
1a69226
May 14, 2018
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
r=me |
irinagpopa
force-pushed the
irinagpopa:rename-trans
branch
from
1a69226
to
e561ed5
May 14, 2018
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
irinagpopa
force-pushed the
irinagpopa:rename-trans
branch
from
e561ed5
to
76b94d7
May 14, 2018
This comment has been minimized.
This comment has been minimized.
|
@bors r=nikomatsakis p=100 (high chance to bitrot) |
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-bors
and removed
S-waiting-on-review
labels
May 14, 2018
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
May 14, 2018
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-review
and removed
S-waiting-on-bors
labels
May 14, 2018
This comment has been minimized.
This comment has been minimized.
|
Cargo test failed. Please either keep the
|
kennytm
added
the
S-waiting-on-author
label
May 14, 2018
This comment has been minimized.
This comment has been minimized.
|
Tested on commit dbd10f8.
|
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
May 17, 2018
irinagpopa
deleted the
irinagpopa:rename-trans
branch
May 17, 2018
This was referenced May 17, 2018
This was referenced May 17, 2018
This comment has been minimized.
This comment has been minimized.
|
RLS breakage should be mititgated at rust-dev-tools/rls-rustc#8 and rust-lang/rls#872 |
irinagpopa commentedMay 10, 2018
Part of #45274.