New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LazyBTreeMap. #50740

Merged
merged 1 commit into from May 17, 2018

Conversation

Projects
None yet
4 participants
@nnethercote
Contributor

nnethercote commented May 14, 2018

It was introduced in #50240 to avoid an allocation when creating a new
BTreeMap, which gave some speed-ups. But then #50352 made that the
default behaviour for BTreeMap, so LazyBTreeMap is no longer necessary.

Remove LazyBTreeMap.
It was introduced in #50240 to avoid an allocation when creating a new
BTreeMap, which gave some speed-ups. But then #50352 made that the
default behaviour for BTreeMap, so LazyBTreeMap is no longer necessary.
@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented May 14, 2018

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@cramertj

This comment has been minimized.

Member

cramertj commented May 14, 2018

Awesome work, thanks!

@bors r+

@bors

This comment has been minimized.

Contributor

bors commented May 14, 2018

📌 Commit f46b888 has been approved by cramertj

kennytm added a commit to kennytm/rust that referenced this pull request May 15, 2018

Rollup merge of rust-lang#50740 - nnethercote:rm-LazyBTreeMap, r=cram…
…ertj

Remove LazyBTreeMap.

It was introduced in rust-lang#50240 to avoid an allocation when creating a new
BTreeMap, which gave some speed-ups. But then rust-lang#50352 made that the
default behaviour for BTreeMap, so LazyBTreeMap is no longer necessary.

bors added a commit that referenced this pull request May 15, 2018

Auto merge of #50775 - kennytm:rollup, r=kennytm
Rollup of 8 pull requests

Successful merges:

 - #50521 (Add simd math intrinsics and gather/scatter)
 - #50541 (rustdoc: replace most (e)println! statements with structured warnings/errors)
 - #50638 (Don't unconditionally set CLOEXEC twice on every fd we open on Linux)
 - #50696 (Update Cargo)
 - #50726 (read2: Use inner function instead of closure)
 - #50740 (Remove LazyBTreeMap.)
 - #50752 (Add missing error codes in libsyntax-ext asm)
 - #50767 (Don't inject clippy into the rls anymore)

Failed merges:

kennytm added a commit to kennytm/rust that referenced this pull request May 16, 2018

Rollup merge of rust-lang#50740 - nnethercote:rm-LazyBTreeMap, r=cram…
…ertj

Remove LazyBTreeMap.

It was introduced in rust-lang#50240 to avoid an allocation when creating a new
BTreeMap, which gave some speed-ups. But then rust-lang#50352 made that the
default behaviour for BTreeMap, so LazyBTreeMap is no longer necessary.

bors added a commit that referenced this pull request May 16, 2018

Auto merge of #50807 - kennytm:rollup, r=kennytm
Rollup of 17 pull requests

Successful merges:

 - #50638 (Don't unconditionally set CLOEXEC twice on every fd we open on Linux)
 - #50656 (Fix `fn main() -> impl Trait` for non-`Termination` trait)
 - #50669 (rustdoc: deprecate `#![doc(passes, plugins, no_default_passes)]`)
 - #50696 (Update Cargo)
 - #50698 (Replace tempdir by tempfile)
 - #50726 (read2: Use inner function instead of closure)
 - #50728 (Fix rustdoc panic with `impl Trait` in type parameters)
 - #50736 (env: remove unwrap in examples in favor of try op)
 - #50740 (Remove LazyBTreeMap.)
 - #50752 (Add missing error codes in libsyntax-ext asm)
 - #50779 (Make mutable_noalias and arg_align_attributes be tracked)
 - #50787 (Fix run-make wasm tests)
 - #50788 (Fix an ICE when casting a nonexistent const)
 - #50789 (Ensure libraries built in stage0 have unique metadata)
 - #50793 (tidy: Add a check for empty UI test files)
 - #50797 (fix a typo in signed-integer::from_str_radix())
 - #50809 (GitHub: Stop treating Cargo.lock as a generated file.)

Failed merges:

bors added a commit that referenced this pull request May 16, 2018

Auto merge of #50807 - kennytm:rollup, r=kennytm
Rollup of 18 pull requests

Successful merges:

 - #50638 (Don't unconditionally set CLOEXEC twice on every fd we open on Linux)
 - #50656 (Fix `fn main() -> impl Trait` for non-`Termination` trait)
 - #50669 (rustdoc: deprecate `#![doc(passes, plugins, no_default_passes)]`)
 - #50696 (Update Cargo)
 - #50698 (Replace tempdir by tempfile)
 - #50726 (read2: Use inner function instead of closure)
 - #50728 (Fix rustdoc panic with `impl Trait` in type parameters)
 - #50736 (env: remove unwrap in examples in favor of try op)
 - #50740 (Remove LazyBTreeMap.)
 - #50752 (Add missing error codes in libsyntax-ext asm)
 - #50779 (Make mutable_noalias and arg_align_attributes be tracked)
 - #50787 (Fix run-make wasm tests)
 - #50788 (Fix an ICE when casting a nonexistent const)
 - #50789 (Ensure libraries built in stage0 have unique metadata)
 - #50793 (tidy: Add a check for empty UI test files)
 - #50797 (fix a typo in signed-integer::from_str_radix())
 - #50808 (Stabilize num::NonZeroU*)
 - #50809 (GitHub: Stop treating Cargo.lock as a generated file.)

Failed merges:

kennytm added a commit to kennytm/rust that referenced this pull request May 16, 2018

Rollup merge of rust-lang#50740 - nnethercote:rm-LazyBTreeMap, r=cram…
…ertj

Remove LazyBTreeMap.

It was introduced in rust-lang#50240 to avoid an allocation when creating a new
BTreeMap, which gave some speed-ups. But then rust-lang#50352 made that the
default behaviour for BTreeMap, so LazyBTreeMap is no longer necessary.

bors added a commit that referenced this pull request May 17, 2018

Auto merge of #50807 - kennytm:rollup, r=kennytm
Rollup of 17 pull requests

Successful merges:

 - #50170 (Implement From for more types on Cow)
 - #50638 (Don't unconditionally set CLOEXEC twice on every fd we open on Linux)
 - #50656 (Fix `fn main() -> impl Trait` for non-`Termination` trait)
 - #50669 (rustdoc: deprecate `#![doc(passes, plugins, no_default_passes)]`)
 - #50726 (read2: Use inner function instead of closure)
 - #50728 (Fix rustdoc panic with `impl Trait` in type parameters)
 - #50736 (env: remove unwrap in examples in favor of try op)
 - #50740 (Remove LazyBTreeMap.)
 - #50752 (Add missing error codes in libsyntax-ext asm)
 - #50779 (Make mutable_noalias and arg_align_attributes be tracked)
 - #50787 (Fix run-make wasm tests)
 - #50788 (Fix an ICE when casting a nonexistent const)
 - #50789 (Ensure libraries built in stage0 have unique metadata)
 - #50793 (tidy: Add a check for empty UI test files)
 - #50797 (fix a typo in signed-integer::from_str_radix())
 - #50808 (Stabilize num::NonZeroU*)
 - #50809 (GitHub: Stop treating Cargo.lock as a generated file.)

Failed merges:

@bors bors merged commit f46b888 into rust-lang:master May 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nnethercote nnethercote deleted the nnethercote:rm-LazyBTreeMap branch May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment