Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upEmit noalias on &mut parameters by default #50744
Conversation
rust-highfive
assigned
eddyb
May 14, 2018
This comment has been minimized.
This comment has been minimized.
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
label
May 14, 2018
nikic
force-pushed the
nikic:mutable-noalias
branch
from
d34842d
to
8b4ee21
May 14, 2018
This comment has been minimized.
This comment has been minimized.
|
Shouldn't this be gated on the LLVM version? I think we still support distros using 3.9. |
This comment has been minimized.
This comment has been minimized.
|
@eddyb Good point, I've conditioned the default behavior on LLVM >= 6.0 now. |
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ Nice! |
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-bors
and removed
S-waiting-on-review
labels
May 14, 2018
This comment has been minimized.
This comment has been minimized.
|
It'd be very cool to see any before/after benchmarks for this. I'm really curious as to how much of an impact it actually has. |
This comment has been minimized.
This comment has been minimized.
|
This is removing the panic=abort stable opt in. Is firefox on a new enough llvm that it won't regress? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
kennytm
added
S-waiting-on-review
and removed
S-waiting-on-bors
labels
May 14, 2018
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-bors
and removed
S-waiting-on-review
labels
May 14, 2018
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-author
and removed
S-waiting-on-bors
labels
May 17, 2018
nikic
force-pushed the
nikic:mutable-noalias
branch
from
8acc992
to
dbf2108
May 17, 2018
This comment has been minimized.
This comment has been minimized.
|
|
nikic
force-pushed the
nikic:mutable-noalias
branch
from
dbf2108
to
1230813
May 17, 2018
This comment has been minimized.
This comment has been minimized.
|
@bors r=alexcrichton |
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-bors
and removed
S-waiting-on-author
labels
May 18, 2018
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
May 19, 2018
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-review
and removed
S-waiting-on-bors
labels
May 19, 2018
This comment was marked as outdated.
This comment was marked as outdated.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
kennytm
referenced this pull request
May 19, 2018
Closed
Spurious "syntax error in VERSION script" when linking the sanitizers on `dist-x86_64-linux-alt` #50887
rust-lang
deleted a comment from
rust-highfive
May 19, 2018
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-bors
and removed
S-waiting-on-review
labels
May 19, 2018
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
May 19, 2018
This comment has been minimized.
This comment has been minimized.
|
|
bors
merged commit 1230813
into
rust-lang:master
May 19, 2018
This comment has been minimized.
This comment has been minimized.
leonardo-m
commented
May 19, 2018
|
Is this changing the performance of some standard benchmark? |
This comment has been minimized.
This comment has been minimized.
|
Looks like the Rust part of the compiler is faster, but the LLVM part spends more time optimizing. So it seems promising for runtime perf; hopefully lolbench will confirm that. |
nikic commentedMay 14, 2018
This used to be disabled due to LLVM bugs in the handling of
noalias information in conjunction with unwinding. However,
according to #31681 all known LLVM bugs have been fixed by
LLVM 6.0, so it's probably time to reenable this optimization.
-Z no-mutable-noalias is left as an escape-hatch to debug problems
suspected to stem from this change.