New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rustdoc documentation to compiler docs. #50892

Merged
merged 1 commit into from May 28, 2018

Conversation

Projects
None yet
5 participants
@davidtwco
Member

davidtwco commented May 19, 2018

Fixes #50004.

r? @alexcrichton
(since you reviewed the last PR about compiler docs)

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented May 20, 2018

@bors: r+

@bors

This comment has been minimized.

Contributor

bors commented May 20, 2018

📌 Commit 9b02379 has been approved by alexcrichton

@bors

This comment has been minimized.

Contributor

bors commented May 20, 2018

⌛️ Testing commit 9b02379 with merge ba3866e...

bors added a commit that referenced this pull request May 20, 2018

Auto merge of #50892 - davidtwco:issue-50004, r=alexcrichton
Added rustdoc documentation to compiler docs.

Fixes #50004.

r? @alexcrichton
(since you reviewed the last PR about compiler docs)
@bors

This comment has been minimized.

Contributor

bors commented May 20, 2018

💔 Test failed - status-travis

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented May 20, 2018

The job dist-x86_64-linux-alt of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:00:57] 
[01:00:58]     Finished release [optimized] target(s) in 2m 7.10s
[01:00:58] [TIMING] Rustc { stage: 2, target: "x86_64-unknown-linux-gnu" } -- 127.154
[01:00:58] Documenting stage2 rustdoc (x86_64-unknown-linux-gnu)
[01:00:58] thread 'main' panicked at 'symlink_dir_force(&builder.config, &out, &out_dir) failed with No such file or directory (os error 2)', bootstrap/doc.rs:798:9
[01:00:58] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-linux-gnu --target x86_64-unknown-linux-gnu
[01:00:58] Build completed unsuccessfully in 0:55:49
travis_time:end:09874a25:start=1526822543684853229,finish=1526826202643690318,duration=3658958837089

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

1 similar comment
@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented May 20, 2018

The job dist-x86_64-linux-alt of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:00:57] 
[01:00:58]     Finished release [optimized] target(s) in 2m 7.10s
[01:00:58] [TIMING] Rustc { stage: 2, target: "x86_64-unknown-linux-gnu" } -- 127.154
[01:00:58] Documenting stage2 rustdoc (x86_64-unknown-linux-gnu)
[01:00:58] thread 'main' panicked at 'symlink_dir_force(&builder.config, &out, &out_dir) failed with No such file or directory (os error 2)', bootstrap/doc.rs:798:9
[01:00:58] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-linux-gnu --target x86_64-unknown-linux-gnu
[01:00:58] Build completed unsuccessfully in 0:55:49
travis_time:end:09874a25:start=1526822543684853229,finish=1526826202643690318,duration=3658958837089

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@davidtwco

This comment has been minimized.

Member

davidtwco commented May 20, 2018

Oops! Forgot to make sure that directory exists, testing a fix locally. Also, that bot is great.

@davidtwco

This comment has been minimized.

Member

davidtwco commented May 27, 2018

@alexcrichton would you be able to take another look at this now I've fixed the previous bug?

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented May 27, 2018

@bors: r+

@bors

This comment has been minimized.

Contributor

bors commented May 27, 2018

📌 Commit 52b83d7 has been approved by alexcrichton

@bors

This comment has been minimized.

Contributor

bors commented May 28, 2018

⌛️ Testing commit 52b83d7 with merge d0456c6...

bors added a commit that referenced this pull request May 28, 2018

Auto merge of #50892 - davidtwco:issue-50004, r=alexcrichton
Added rustdoc documentation to compiler docs.

Fixes #50004.

r? @alexcrichton
(since you reviewed the last PR about compiler docs)
@bors

This comment has been minimized.

Contributor

bors commented May 28, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing d0456c6 to master...

@bors bors merged commit 52b83d7 into rust-lang:master May 28, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@davidtwco davidtwco deleted the davidtwco:issue-50004 branch May 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment