New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline `try_get`. #50931

Merged
merged 1 commit into from May 22, 2018

Conversation

Projects
None yet
6 participants
@nnethercote
Contributor

nnethercote commented May 21, 2018

This speeds up lots of rustc-perf benchmark runs. The maximum
improvement is 1%, but there are a lot in the 0.5--1.0% range.

Inline `try_get`.
This speeds up lots of rustc-perf benchmark runs. The maximum
improvement is 1%, but there are a lot in the 0.5--1.0% range.
@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented May 21, 2018

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@@ -105,6 +105,10 @@ impl<'a, 'tcx, Q: QueryDescription<'tcx>> JobOwner<'a, 'tcx, Q> {
/// start executing the query, or it returns with the result of the query.
/// If the query is executing elsewhere, this will wait for it.
/// If the query panicked, this will silently panic.
///
/// This function is inlined because that results in a noticeable speedup

This comment has been minimized.

@ishitatsuyuki

ishitatsuyuki May 21, 2018

Member

Nit: can/should we use normal comments here? This doesn't seem useful when shown in rustdoc.

@michaelwoerister

This comment has been minimized.

Contributor

michaelwoerister commented May 21, 2018

@bors r+

@bors

This comment has been minimized.

Contributor

bors commented May 21, 2018

📌 Commit 9512016 has been approved by michaelwoerister

@Mark-Simulacrum

This comment has been minimized.

Member

Mark-Simulacrum commented May 21, 2018

@bors rollup

kennytm added a commit to kennytm/rust that referenced this pull request May 22, 2018

Rollup merge of rust-lang#50931 - nnethercote:inline-try_get, r=micha…
…elwoerister

Inline `try_get`.

This speeds up lots of rustc-perf benchmark runs. The maximum
improvement is 1%, but there are a lot in the 0.5--1.0% range.

bors added a commit that referenced this pull request May 22, 2018

Auto merge of #50968 - kennytm:rollup, r=kennytm
Rollup of 15 pull requests

Successful merges:

 - #50846 (Add E0665)
 - #50849 (CheckLoopVisitor: also visit closure arguments)
 - #50863 (Make `[T]::len` and `str::len` const fn)
 - #50875 (rustdoc: use "short form" doc(cfg) printing even when combined with other conditionals)
 - #50913 (Fix typo in cell.rs)
 - #50914 (Issue #50636: Improve error diagnostic with missing commas after struct fields.)
 - #50931 (Inline `try_get`.)
 - #50932 (Optimize seen Predicate filtering.)
 - #50945 (Stabilize feature from_ref)
 - #50946 (rustc: Fix procedural macros generating lifetime tokens)
 - #50947 (rustdoc: set tab width in rust source blocks)
 - #50952 (Add the 2018 edition of the book to doc.rust-lang.org)
 - #50958 (Micro-optimization on PR#50697)
 - #50961 (Fix FileCheck finding with MSVC)
 - #50963 (Right-size the `VecDeque` in `coerce_unsized`.)

Failed merges:

@bors bors merged commit 9512016 into rust-lang:master May 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nnethercote nnethercote deleted the nnethercote:inline-try_get branch May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment