Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace if with if and only if in the definition dox of Sync #51152

Merged
merged 1 commit into from Jun 2, 2018
Merged

Replace if with if and only if in the definition dox of Sync #51152

merged 1 commit into from Jun 2, 2018

Conversation

crlf0710
Copy link
Member

The old text was: "The precise definition is: a type T is Sync if &T is Send."

Since we've also got

impl<'a, T> Send for &'a T 
where
    T: Sync + ?Sized,

I purpose we can change the if to if and only if to make it more precise.

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 29, 2018
@kennytm
Copy link
Member

kennytm commented May 30, 2018

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 30, 2018

📌 Commit 0d821db has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2018
@bors
Copy link
Contributor

bors commented May 30, 2018

🔒 Merge conflict

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 30, 2018
kennytm added a commit to kennytm/rust that referenced this pull request May 30, 2018
@kennytm
Rollup merge of rust-lang#51152 - crlf0710:patch-1, r=kennytm
b7b7b25 
The old text was: "The precise definition is: a type `T` is `Sync` if `&T` is Send."

Since we've also got
```
impl<'a, T> Send for &'a T
where
    T: Sync + ?Sized,
```
I purpose we can change the `if` to `if and only if` to make it more precise.
@kennytm kennytm mentioned this pull request May 30, 2018
Closed
bors added a commit that referenced this pull request May 30, 2018
@bors
Auto merge of #51214 - kennytm:rollup, r=kennytm
ab61e34 
Rollup of 12 pull requests

Successful merges:

 - #51050 (std::fs::DirEntry.metadata(): use fstatat instead of lstat when possible)
 - #51123 (Update build instructions)
 - #51127 (Add doc link from discriminant struct to function.)
 - #51146 (typeck: Do not pass the field check on field error)
 - #51147 (Stabilize SliceIndex trait.)
 - #51151 (Move slice::exact_chunks directly above exact_chunks_mut for more con…)
 - #51152 (Replace `if` with `if and only if` in the definition dox of `Sync`)
 - #51153 (Link panic and compile_error docs)
 - #51158 (Mention spec and indented blocks in doctest docs)
 - #51186 (Remove two redundant .nll.stderr files)
 - #51203 (Two minor `obligation_forest` tweaks.)
 - #51213 (fs: copy: Use File::set_permissions instead of fs::set_permissions)

Failed merges:
@crlf0710
Replace if with if and only if in the definition dox of Sync
8e90a2d 
The old text was: "The precise definition is: a type T is Sync if &T is Send."

Since we've also got
```
impl<'a, T> Send for &'a T 
where
    T: Sync + ?Sized,
```
I purpose we can change the `if` to `if and only if` to make it more precise.
@crlf0710
Copy link
Member Author

crlf0710 commented Jun 1, 2018

Rebased

@kennytm
Copy link
Member

kennytm commented Jun 1, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Jun 1, 2018

📌 Commit 8e90a2d has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 1, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 1, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#51152 - crlf0710:patch-1, r=kennytm
b6013b2 
Replace `if` with `if and only if` in the definition dox of `Sync`

The old text was: "The precise definition is: a type `T` is `Sync` if `&T` is Send."

Since we've also got
```
impl<'a, T> Send for &'a T
where
    T: Sync + ?Sized,
```
I purpose we can change the `if` to `if and only if` to make it more precise.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 1, 2018
Merged
bors added a commit that referenced this pull request Jun 2, 2018
@bors
Auto merge of #51287 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
5f7c9da 
Rollup of 5 pull requests

Successful merges:

 - #51135 (Tweak output on E0599 for assoc fn used as method)
 - #51152 (Replace `if` with `if and only if` in the definition dox of `Sync`)
 - #51262 (Add missing whitespace in num example)
 - #51272 (Remove feature flag from fs::read_to_string example)
 - #51286 (Pull 1.26.2 release notes into master)

Failed merges:
@bors bors merged commit 8e90a2d into rust-lang:master Jun 2, 2018
@crlf0710 crlf0710 deleted the patch-1 branch June 2, 2018 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kennytm kennytm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crlf0710 @rust-highfive @kennytm @bors