Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement PartialEq between &str and OsString #51178
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @bluss (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
Click to expand the log.
We have all of the following:
// & <-> Owned are comparable impl<'a> PartialEq<&'a str> for String impl<'a> PartialEq<String> for &'a str // utf8 <-> OS are comparable impl PartialEq<str> for OsString impl PartialEq<OsString> for str
So I believe it makes sense to provide these as well.
impl<'a> PartialEq<&'a str> for OsString impl<'a> PartialEq<OsString> for &'a str
@rfcbot fcp merge
Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged teams:
No concerns currently listed.
Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.
How do I rebase?
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.
Please avoid the "Resolve conflicts" button on GitHub. It uses
Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how