Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize #[repr(transparent)] #51562

Merged
merged 1 commit into from Jun 16, 2018
Merged

Stabilize #[repr(transparent)] #51562

merged 1 commit into from Jun 16, 2018

Conversation

@SimonSapin
Copy link
Contributor

SimonSapin commented Jun 14, 2018

Tracking issue FCP: #43036 (comment)
Reference PR: rust-lang/reference#353

Tracking issue FCP: #43036 (comment)
Reference PR: rust-lang/reference#353
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jun 14, 2018

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@cramertj

This comment has been minimized.

Copy link
Member

cramertj commented Jun 14, 2018

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jun 14, 2018

📌 Commit e2aef92 has been approved by cramertj

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jun 14, 2018

⌛️ Testing commit e2aef92 with merge 39143cd...

bors added a commit that referenced this pull request Jun 14, 2018
Stabilize #[repr(transparent)]

Tracking issue FCP: #43036 (comment)
Reference PR: rust-lang/reference#353
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jun 14, 2018

💔 Test failed - status-appveyor

@SimonSapin

This comment has been minimized.

Copy link
Contributor Author

SimonSapin commented Jun 14, 2018

3 command(s) did not execute successfully:
  - "C:\\projects\\rust\\build\\bootstrap/debug/rustdoc" "--test" "C:\\projects\\rust\\src/doc/nomicon\\src\\destructors.md" "--test-args" ""
  - "C:\\projects\\rust\\build\\bootstrap/debug/rustdoc" "--test" "C:\\projects\\rust\\src/doc/nomicon\\src\\vec-final.md" "--test-args" ""
  - "C:\\projects\\rust\\build\\bootstrap/debug/rustdoc" "--test" "C:\\projects\\rust\\src/doc/reference\\src\\expressions\\array-expr.md" "--test-args" ""

This seems unrelated to this PR.

@kennytm

This comment has been minimized.

Copy link
Member

kennytm commented Jun 14, 2018

@bors retry #51565

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jun 15, 2018

⌛️ Testing commit e2aef92 with merge d837924...

bors added a commit that referenced this pull request Jun 15, 2018
Stabilize #[repr(transparent)]

Tracking issue FCP: #43036 (comment)
Reference PR: rust-lang/reference#353
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jun 15, 2018

💔 Test failed - status-appveyor

@SimonSapin

This comment has been minimized.

Copy link
Contributor Author

SimonSapin commented Jun 15, 2018

@bors retry #51565

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jun 16, 2018

⌛️ Testing commit e2aef92 with merge 53503e3...

bors added a commit that referenced this pull request Jun 16, 2018
Stabilize #[repr(transparent)]

Tracking issue FCP: #43036 (comment)
Reference PR: rust-lang/reference#353
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jun 16, 2018

💔 Test failed - status-travis

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jun 16, 2018

The job dist-mipsel-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
  0     0    0     0    0     0      0      0 --:--:--  0:00:51 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:52 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:53 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:54 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:55 --:--:--     0curl: (6) Could not resolve host: s3-us-west-1.amazonaws.com
[01:17:53] thread 'main' panicked at 'failed to download openssl source: exit code: 6', bootstrap/native.rs:575:17
[01:17:53] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host mipsel-unknown-linux-gnu --target mipsel-unknown-linux-gnu
[01:17:53] Build completed unsuccessfully in 1:14:43
travis_time:end:01375800:start=1529126347263326961,finish=1529131020968299183,duration=4673704972222

---
travis_time:end:1b0af65c:start=1529131021599621814,finish=1529131021608246093,duration=8624279
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:02ecdc00
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:09e40e54
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

1 similar comment
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jun 16, 2018

The job dist-mipsel-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
  0     0    0     0    0     0      0      0 --:--:--  0:00:51 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:52 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:53 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:54 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:55 --:--:--     0curl: (6) Could not resolve host: s3-us-west-1.amazonaws.com
[01:17:53] thread 'main' panicked at 'failed to download openssl source: exit code: 6', bootstrap/native.rs:575:17
[01:17:53] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host mipsel-unknown-linux-gnu --target mipsel-unknown-linux-gnu
[01:17:53] Build completed unsuccessfully in 1:14:43
travis_time:end:01375800:start=1529126347263326961,finish=1529131020968299183,duration=4673704972222

---
travis_time:end:1b0af65c:start=1529131021599621814,finish=1529131021608246093,duration=8624279
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:02ecdc00
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:09e40e54
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@SimonSapin

This comment has been minimized.

Copy link
Contributor Author

SimonSapin commented Jun 16, 2018

curl: (6) Could not resolve host: s3-us-west-1.amazonaws.com

Temporary network failure?

@bors retry

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jun 16, 2018

⌛️ Testing commit e2aef92 with merge 61ba018...

bors added a commit that referenced this pull request Jun 16, 2018
Stabilize #[repr(transparent)]

Tracking issue FCP: #43036 (comment)
Reference PR: rust-lang/reference#353
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jun 16, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: cramertj
Pushing 61ba018 to master...

@bors bors merged commit e2aef92 into rust-lang:master Jun 16, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the SimonSapin:transparent branch Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.