/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cross-lang-lto] Allow the linker to choose the LTO-plugin (which is useful when using LLD) #52019

Merged
merged 1 commit into from Jul 6, 2018

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
4 participants
@michaelwoerister @alexcrichton @bors @rust-highfive
@michaelwoerister
Copy link
Contributor

michaelwoerister commented Jul 3, 2018

This PR allows for not specifying an LTO-linker plugin but still let rustc invoke the linker with the correct plugin arguments. This is useful when using LLD which does not need the -plugin argument. Since LLD is the best linker for this scenario anyway, this change should improve ergonomics quite a bit.

r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton Jul 3, 2018

@rust-highfive rust-highfive added the S-waiting-on-review label Jul 3, 2018

@michaelwoerister michaelwoerister changed the title Allow the linker to choose the LTO-plugin (which is useful when using LLD) [cross-lang-lto] Allow the linker to choose the LTO-plugin (which is useful when using LLD) Jul 3, 2018

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Jul 3, 2018

@bors: r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 3, 2018

📌 Commit 65ff414 has been approved by alexcrichton

@bors bors added S-waiting-on-bors and removed S-waiting-on-review labels Jul 3, 2018

@michaelwoerister

This comment has been minimized.

Sign in to view
Copy link
Contributor

michaelwoerister commented Jul 4, 2018

@bors rollup

kennytm added a commit to kennytm/rust that referenced this pull request Jul 5, 2018

@kennytm
Rollup merge of rust-lang#52019 - michaelwoerister:cross-lto-auto-plu… 
…gin, r=alexcrichton

[cross-lang-lto] Allow the linker to choose the LTO-plugin (which is useful when using LLD)

This PR allows for not specifying an LTO-linker plugin but still let `rustc` invoke the linker with the correct plugin arguments. This is useful when using LLD which does not need the `-plugin` argument. Since LLD is the best linker for this scenario anyway, this change should improve ergonomics quite a bit.

r? @alexcrichton
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
bef2056

@kennytm kennytm referenced this pull request Jul 5, 2018

Merged

Rollup of 14 pull requests #52088

bors added a commit that referenced this pull request Jul 6, 2018

@bors
Auto merge of #52088 - kennytm:rollup, r=kennytm 
Rollup of 13 pull requests

Successful merges:

 - #51619 (rust: add initial changes to support powerpc64le musl)
 - #51793 (Fix variant background color on hover in search results)
 - #51861 (Prevent some markdown transformation on short docblocks)
 - #51953 (enable Atomic*.{load,store} for ARMv6-M / MSP430)
 - #52005 (Update LLVM to bring in a wasm codegen fix)
 - #52016 (Deduplicate error reports for statics)
 - #52019 ([cross-lang-lto] Allow the linker to choose the LTO-plugin (which is useful when using LLD))
 - #52030 (Any docs preposition change)
 - #52031 (Strenghten synchronization in `Arc::is_unique`)
 - #52033 ([Gardening] Update outdated comments: ByVal -> Scalar)
 - #52052 (Make verbose --version show if parallel queries are supported.)
 - #52073 (Add a punch card to weird expressions test)
 - #52080 (Improve dependency deduplication diagnostics)

Failed merges:

r? @ghost
Loading status checks…
67b3b2d

kennytm added a commit to kennytm/rust that referenced this pull request Jul 6, 2018

@kennytm
Rollup merge of rust-lang#52019 - michaelwoerister:cross-lto-auto-plu… 
…gin, r=alexcrichton

[cross-lang-lto] Allow the linker to choose the LTO-plugin (which is useful when using LLD)

This PR allows for not specifying an LTO-linker plugin but still let `rustc` invoke the linker with the correct plugin arguments. This is useful when using LLD which does not need the `-plugin` argument. Since LLD is the best linker for this scenario anyway, this change should improve ergonomics quite a bit.

r? @alexcrichton
Verified
This commit was signed with a verified signature.
@kennytm kennytm
GPG key ID: FEF6C8051D0E013C Learn about signing commits
ffc453a

bors added a commit that referenced this pull request Jul 6, 2018

@bors
Auto merge of #52088 - kennytm:rollup, r=kennytm 
Rollup of 14 pull requests

Successful merges:

 - #51619 (rust: add initial changes to support powerpc64le musl)
 - #51793 (Fix variant background color on hover in search results)
 - #52005 (Update LLVM to bring in a wasm codegen fix)
 - #52016 (Deduplicate error reports for statics)
 - #52019 ([cross-lang-lto] Allow the linker to choose the LTO-plugin (which is useful when using LLD))
 - #52030 (Any docs preposition change)
 - #52031 (Strenghten synchronization in `Arc::is_unique`)
 - #52033 ([Gardening] Update outdated comments: ByVal -> Scalar)
 - #52052 (Make verbose --version show if parallel queries are supported.)
 - #52055 (Include VS 2017 in error message.)
 - #52063 (Add a link to the rustc docs)
 - #52073 (Add a punch card to weird expressions test)
 - #52080 (Improve dependency deduplication diagnostics)
 - #51953 (enable Atomic*.{load,store} for ARMv6-M / MSP430)

Failed merges:
Loading status checks…
bff0090

bors added a commit that referenced this pull request Jul 6, 2018

@bors
Auto merge of #52088 - kennytm:rollup, r=kennytm 
Rollup of 14 pull requests

Successful merges:

 - #51619 (rust: add initial changes to support powerpc64le musl)
 - #51793 (Fix variant background color on hover in search results)
 - #52005 (Update LLVM to bring in a wasm codegen fix)
 - #52016 (Deduplicate error reports for statics)
 - #52019 ([cross-lang-lto] Allow the linker to choose the LTO-plugin (which is useful when using LLD))
 - #52030 (Any docs preposition change)
 - #52031 (Strenghten synchronization in `Arc::is_unique`)
 - #52033 ([Gardening] Update outdated comments: ByVal -> Scalar)
 - #52052 (Make verbose --version show if parallel queries are supported.)
 - #52055 (Include VS 2017 in error message.)
 - #52063 (Add a link to the rustc docs)
 - #52073 (Add a punch card to weird expressions test)
 - #52080 (Improve dependency deduplication diagnostics)
 - #51953 (enable Atomic*.{load,store} for ARMv6-M / MSP430)

Failed merges:
Loading status checks…
01c430a

bors added a commit that referenced this pull request Jul 6, 2018

@bors
Auto merge of #52088 - kennytm:rollup, r=kennytm 
Rollup of 14 pull requests

Successful merges:

 - #51619 (rust: add initial changes to support powerpc64le musl)
 - #51793 (Fix variant background color on hover in search results)
 - #52005 (Update LLVM to bring in a wasm codegen fix)
 - #52016 (Deduplicate error reports for statics)
 - #52019 ([cross-lang-lto] Allow the linker to choose the LTO-plugin (which is useful when using LLD))
 - #52030 (Any docs preposition change)
 - #52031 (Strenghten synchronization in `Arc::is_unique`)
 - #52033 ([Gardening] Update outdated comments: ByVal -> Scalar)
 - #52055 (Include VS 2017 in error message.)
 - #52063 (Add a link to the rustc docs)
 - #52073 (Add a punch card to weird expressions test)
 - #52080 (Improve dependency deduplication diagnostics)
 - #52093 (rustc: Update tracking issue for wasm_import_module)
 - #52096 (Fix typo in cell.rs)

Failed merges:
Loading status checks…
4d9fa23

@bors bors merged commit 65ff414 into rust-lang:master Jul 6, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@michaelwoerister michaelwoerister referenced this pull request Jul 10, 2018

Closed

[experimental]: Build LLVM with ThinLTO enabled #51207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment