Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uprefactor and cleanup region errors for NLL #52021
Conversation
rust-highfive
assigned
estebank
Jul 3, 2018
rust-highfive
added
the
S-waiting-on-review
label
Jul 3, 2018
This comment has been minimized.
This comment has been minimized.
|
That said, I might like to land this PR anyway, just to give us more to build from. |
nikomatsakis
force-pushed the
nikomatsakis:nll-region-errors
branch
from
37bfd0c
to
e91c818
Jul 3, 2018
This comment has been minimized.
This comment has been minimized.
|
I haven't updated the stderr files yet, but the general output we are creating looks like this:
There are a bunch of "to do" items here:
|
This comment has been minimized.
This comment has been minimized.
|
Another example:
In this case, my final goal might look like this:
This could be done with:
|
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment has been minimized.
This comment has been minimized.
|
Let me know if you wish to merge as is or with a mild clean up and I can give it a further pass once they're in master. |
nikomatsakis
added some commits
Jul 3, 2018
nikomatsakis
force-pushed the
nikomatsakis:nll-region-errors
branch
from
9b929d3
to
076120c
Jul 4, 2018
This comment has been minimized.
This comment has been minimized.
Mostly I don't want to try and get the "perfect message" in this PR. I'd be happy to do some mild cleanup, but also happy to land as is and do cleanup after landing. Also, this code will hopefully pass travis now. (Had a few things to fix.) |
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
nikomatsakis
force-pushed the
nikomatsakis:nll-region-errors
branch
from
076120c
to
0c15d35
Jul 4, 2018
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
nikomatsakis
changed the title
[WIP] refactor and cleanup region errors for NLL
refactor and cleanup region errors for NLL
Jul 4, 2018
nikomatsakis
force-pushed the
nikomatsakis:nll-region-errors
branch
from
0c15d35
to
727f017
Jul 4, 2018
This comment has been minimized.
This comment has been minimized.
estebank
approved these changes
Jul 5, 2018
| LL | self.x.iter().map(|a| a.0) | ||
| | ^^^^^^^^^^^^^ | ||
| | ^^^^^^ cast requires that `'1` must outlive `'static` |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
bors
removed
the
S-waiting-on-review
label
Jul 5, 2018
bors
added
the
S-waiting-on-bors
label
Jul 5, 2018
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Jul 6, 2018
This comment has been minimized.
This comment has been minimized.
|
|
nikomatsakis commentedJul 3, 2018
This is a WIP commit. It simplifies some of the code from #51536 and extends a few more steps towards the errors that @davidtwco and I were shooting for. These are intended as a replacement for the general "unable to infer lifetime" messages -- one that is actually actionable. We're certainly not there yet, but the overall shape hopefully gets a bit clearer.
I'm thinking about trying to open up an internals thread to sketch out the overall plan and perhaps discuss how to get the wording right, which special cases to handle, etc.
r? @estebank
cc @davidtwco