Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the adjusted type for cat_pattern in tuple patterns #52232

Merged
merged 3 commits into from Jul 11, 2018

Conversation

Reviewers

@pnkfelix pnkfelix

Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-bors T-compiler beta-accepted stable-accepted
Projects
None yet
Milestone
No milestone
7 participants
@arielb1 @pnkfelix @bors @kennytm @pietroalbini @Mark-Simulacrum @rust-highfive
@arielb1
Copy link
Contributor

arielb1 commented Jul 10, 2018

This looks like a typo introduced in #51686.

Fixes #52213.

r? @pnkfelix

beta + stable nominating because regression + unsoundness.

arielb1 added some commits Jul 10, 2018

@arielb1
use the adjusted type for cat_pattern in tuple patterns 
This looks like a typo introduced in #51686.

Fixes #52213.
05d6e55
@arielb1
add a debug log for more MC failures 
I don't see why MC should fail on well-formed code, so it might be a
better idea to just add a `delay_span_bug` there (anyone remember the
`cat_expr Errd` bug from the 1.0 days?).

However, I don't think this is a good idea to backport a new delay_span_bug
into stable and this code is going away soon-ish anyway.
df33cf4
@arielb1
add test for #52213
Loading status checks…
4c04453

@arielb1 arielb1 added beta-nominated stable-nominated labels Jul 10, 2018

@arielb1 arielb1 requested a review from pnkfelix Jul 10, 2018

@rust-highfive rust-highfive assigned pnkfelix Jul 10, 2018

@rust-highfive rust-highfive added the S-waiting-on-review label Jul 10, 2018

@pnkfelix

This comment has been minimized.

Sign in to view
Copy link
Member

pnkfelix commented Jul 10, 2018

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 10, 2018

📌 Commit 4c04453 has been approved by pnkfelix

@bors bors added S-waiting-on-bors and removed S-waiting-on-review labels Jul 10, 2018

@kennytm

This comment has been minimized.

Sign in to view
Copy link
Member

kennytm commented Jul 10, 2018

@bors p=13
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 11, 2018

⌛️ Testing commit 4c04453 with merge 4700e11...

bors added a commit that referenced this pull request Jul 11, 2018

@bors
Auto merge of #52232 - arielb1:ill-adjusted-tuples, r=pnkfelix 
 use the adjusted type for cat_pattern in tuple patterns

This looks like a typo introduced in #51686.

Fixes #52213.

r? @pnkfelix

beta + stable nominating because regression + unsoundness.
Loading status checks…
4700e11
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 11, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: pnkfelix
Pushing 4700e11 to master...

@bors bors merged commit 4c04453 into rust-lang:master Jul 11, 2018
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@sfackler sfackler referenced this pull request Jul 11, 2018

Closed

Can turn immutable into mut with `ref mut` #52240

@pietroalbini pietroalbini added the T-compiler label Jul 12, 2018

@pnkfelix

This comment has been minimized.

Sign in to view
Copy link
Member

pnkfelix commented Jul 12, 2018

@rfcbot fcp merge

I propose that we approve backporting this to beta.

Since time is somewhat limited, and back ports are usually less controversial than the usual things that go through the fcp process, I'm going to add the additional note if there are no unresolved formal concerns in a week's time, I will just check off any unmarked check boxes. (This effectively inverts the rfcbot into "approved by default.")

This was referenced Jul 12, 2018

Closed
Closed

@pietroalbini pietroalbini added beta-accepted stable-accepted labels Jul 14, 2018

@pietroalbini

This comment has been minimized.

Sign in to view
Copy link
Member

pietroalbini commented Jul 14, 2018

Marked as beta-accepted and stable-accepted (#52311 and #52312).

@pietroalbini pietroalbini referenced this pull request Jul 14, 2018

Merged

[beta] Rollup backports #52366

@pietroalbini pietroalbini removed the beta-nominated label Jul 14, 2018

bors added a commit that referenced this pull request Jul 14, 2018

@bors
Auto merge of #52366 - pietroalbini:beta-backports, r=pietroalbini 
[beta] Rollup backports

Merged and approved:

* #51956: Fix rustdoc run failures by shutting down definitely some lints
* #52232: use the adjusted type for cat_pattern in tuple patterns

Closes #52311
Closes #52313

r? @ghost
Loading status checks…
67e5a18

@Mark-Simulacrum Mark-Simulacrum referenced this pull request Jul 18, 2018

Merged

1.27.2 stable release #52481

bors added a commit that referenced this pull request Jul 18, 2018

@bors
Auto merge of #52481 - Mark-Simulacrum:stable-next, r=alexcrichton 
1.27.2 stable release

This is essentially a backport of #52232. I've set the release date for Friday, July 20th.

r? @alexcrichton
Loading status checks…
58cc626

@Mark-Simulacrum Mark-Simulacrum removed the stable-nominated label Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.