Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve: Modularize crate-local `#[macro_export] macro_rules` #52234

Merged
merged 1 commit into from Jul 31, 2018

Conversation

@petrochenkov
Copy link
Contributor

petrochenkov commented Jul 10, 2018

Based on #50911, cc #50911 (comment)

#[macro_export] macro_rules items are collected from the whole crate and are planted into the root module as items, so the external view of the crate is symmetric with its internal view and something like $crate::my_macro where my_macro is #[macro_export] macro_rules works both locally and from other crates.

Closes #52726

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jul 10, 2018

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@petrochenkov

This comment has been minimized.

Copy link
Contributor Author

petrochenkov commented Jul 10, 2018

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 10, 2018

⌛️ Trying commit ee16ce1 with merge bcc0707...

bors added a commit that referenced this pull request Jul 10, 2018

Auto merge of #52234 - petrochenkov:macuse2, r=<try>
[Experiment] resolve: Modularize crate-local `#[macro_export] macro_rules`

Based on #50911, cc #50911 (comment)

`#[macro_export] macro_rules` items are collected from the whole crate and are planted into the root module as items, so the external view of the crate is symmetric with its internal view and something like `$crate::my_macro` where `my_macro` is `#[macro_export] macro_rules` works both locally and from other crates.
@petrochenkov

This comment has been minimized.

Copy link
Contributor Author

petrochenkov commented Jul 10, 2018

ping @pietroalbini
this needs a check-only crater run

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jul 11, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/2d/99/b2c4e9d5a30f6471e410a146232b4118e697fa3ffc06d6a65efde84debd0/futures-3.2.0-py2-none-any.whl
Requirement already satisfied: six>=1.5 in /usr/lib/python2.7/dist-packages (from python-dateutil<3.0.0,>=2.1; python_version >= "2.7"->botocore==1.10.55->awscli)
Building wheels for collected packages: awscli
  Running setup.py bdist_wheel for awscli ... - \ | / - \ done
Successfully built awscli
Installing collected packages: docutils, jmespath, python-dateutil, botocore, colorama, pyasn1, rsa, futures, s3transfer, awscli
Successfully installed awscli-1.15.56 botocore-1.10.55 colorama-0.3.9 docutils-0.14 futures-3.2.0 jmespath-0.9.3 pyasn1-0.4.3 python-dateutil-2.7.3 rsa-3.4.2 s3transfer-0.1.13
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
---
[00:41:07]     Checking rustc_tsan v0.0.0 (file:///checkout/src/librustc_tsan)
[00:41:07]     Checking rustc_msan v0.0.0 (file:///checkout/src/librustc_msan)
[00:41:07]     Checking rustc_asan v0.0.0 (file:///checkout/src/librustc_asan)
[00:41:07]  Documenting std v0.0.0 (file:///checkout/src/libstd)
[00:41:08] error: macro expansion ignores token `{` and any following
[00:41:08]     |
[00:41:08]     |
[00:41:08] 771 |         ($file:expr) => ({ /* compiler built-in */ });
[00:41:08]     |
[00:41:08]     |
[00:41:08] note: caused by the macro expansion here; the usage of `include!` is likely invalid in item context
[00:41:08]    --> libstd/lib.rs:548:1
[00:41:08]     |
[00:41:08] 548 | include!("primitive_docs.rs");
[00:41:08] 
[00:41:08] 
[00:41:08] error: macro expansion ignores token `{` and any following
[00:41:08]     |
[00:41:08]     |
[00:41:08] 771 |         ($file:expr) => ({ /* compiler built-in */ });
[00:41:08]     |
[00:41:08]     |
[00:41:08] note: caused by the macro expansion here; the usage of `include!` is likely invalid in item context
[00:41:08]    --> libstd/lib.rs:553:1
[00:41:08]     |
[00:41:08] 553 | include!("keyword_docs.rs");
[00:41:08] 
[00:41:08] 
[00:41:08] error: Could not document `std`.
[00:41:08] Caused by:
[00:41:08] Caused by:
[00:41:08]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --crate-name std libstd/lib.rs --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/doc --cfg feature="alloc_jemalloc" --cfg feature="backtrace" --cfg feature="jemalloc" --cfg feature="panic-unwind" --cfg feature="panic_unwind" -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps --extern alloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liballoc-f4ae61a0ac9de403.rmeta --extern alloc_jemalloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liballoc_jemalloc-6e31f4ac527cac4f.rmeta --extern alloc_system=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liballoc_system-953937df74cec9d8.rmeta --extern compiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcompiler_builtins-9cb094b550f36de1.rmeta --extern core=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcore-b15f1ff96a8f614d.rmeta --extern libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liblibc-b593463e25ad8bc9.rmeta --extern panic_abort=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libpanic_abort-d6f76d88eb491ae8.rmeta --extern panic_unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libpanic_unwind-241c8eb04554268c.rmeta --extern rustc_asan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_asan-8fb2bf0fd88472e9.rmeta --extern rustc_lsan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_lsan-ec08d8e5e1d73289.rmeta --extern rustc_msan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_msan-1341914eb50a09c0.rmeta --extern rustc_tsan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_tsan-acea38b6e3885725.rmeta --extern std_unicode=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libstd_unicode-f63bf17f6ac88315.rmeta --extern unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libunwind-39eca009eb64ef4f.rmeta` (exit code: 101)
[00:41:08] 
[00:41:08] 
[00:41:08] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "doc" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--no-deps" "-p" "alloc" "-p" "core" "-p" "std" "-p" "std_unicode"
[00:41:08] 
[00:41:08] 
[00:41:08] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap doc
[00:41:08] Build completed unsuccessfully in 0:04:52
[00:41:08] Build completed unsuccessfully in 0:04:52
[00:41:08] make: *** [all] Error 1
[00:41:08] Makefile:28: recipe for target 'all' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0755e612
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:02926932:start=1531269441066222874,finish=1531269441073890522,duration=7667648
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:054d9cfa
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:11e929ba
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 11, 2018

💔 Test failed - status-travis

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jul 11, 2018

The job dist-x86_64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_fold:end:services

travis_fold:start:git.checkout
travis_time:start:08fbd86e
$ git clone --depth=2 --branch=try https://github.com/rust-lang/rust.git rust-lang/rust
---
[00:59:05]     Checking rustc_lsan v0.0.0 (file:///checkout/src/librustc_lsan)
[00:59:05]     Checking panic_unwind v0.0.0 (file:///checkout/src/libpanic_unwind)
[00:59:05]     Checking rustc_msan v0.0.0 (file:///checkout/src/librustc_msan)
[00:59:05]  Documenting std v0.0.0 (file:///checkout/src/libstd)
[00:59:06] error: macro expansion ignores token `{` and any following
[00:59:06]     |
[00:59:06]     |
[00:59:06] 771 |         ($file:expr) => ({ /* compiler built-in */ });
[00:59:06]     |
[00:59:06]     |
[00:59:06] note: caused by the macro expansion here; the usage of `include!` is likely invalid in item context
[00:59:06]    --> libstd/lib.rs:548:1
[00:59:06]     |
[00:59:06] 548 | include!("primitive_docs.rs");
[00:59:06] 
[00:59:06] 
[00:59:06] error: macro expansion ignores token `{` and any following
[00:59:06]     |
[00:59:06]     |
[00:59:06] 771 |         ($file:expr) => ({ /* compiler built-in */ });
[00:59:06]     |
[00:59:06]     |
[00:59:06] note: caused by the macro expansion here; the usage of `include!` is likely invalid in item context
[00:59:06]    --> libstd/lib.rs:553:1
[00:59:06]     |
[00:59:06] 553 | include!("keyword_docs.rs");
[00:59:06] 
[00:59:06] 
[00:59:06] error: Could not document `std`.
[00:59:06] Caused by:
[00:59:06] Caused by:
[00:59:06]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --crate-name std libstd/lib.rs --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/doc --cfg feature="alloc_jemalloc" --cfg feature="backtrace" --cfg feature="jemalloc" --cfg feature="panic-unwind" --cfg feature="panic_unwind" --cfg feature="profiler" --cfg feature="profiler_builtins" -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps --extern alloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liballoc-11f645d5d50ec01d.rmeta --extern alloc_jemalloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liballoc_jemalloc-b47ce328a4ba70ee.rmeta --extern alloc_system=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liballoc_system-f97b2ca8b6ea07bd.rmeta --extern compiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcompiler_builtins-a79b1686dcdb6599.rmeta --extern core=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcore-9dfdb611cdf09a22.rmeta --extern libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liblibc-e113f9b9a0aa6586.rmeta --extern panic_abort=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libpanic_abort-afa6c0a795054c51.rmeta --extern panic_unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libpanic_unwind-4f996473c57ff2d7.rmeta --extern profiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libprofiler_builtins-96fc30c656f77bfd.rmeta --extern rustc_asan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_asan-6678a520a240f250.rmeta --extern rustc_lsan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_lsan-2b28bf250e8c19b3.rmeta --extern rustc_msan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_msan-72f2ee3ef3ce967d.rmeta --extern rustc_tsan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_tsan-f130431124e944fe.rmeta --extern std_unicode=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libstd_unicode-3448644921326dc8.rmeta --extern unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libunwind-62dce3cd9306a1e4.rmeta` (exit code: 101)
[00:59:06] 
[00:59:06] 
[00:59:06] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "doc" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace profiler" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--no-deps" "-p" "alloc" "-p" "core" "-p" "std" "-p" "std_unicode"
[00:59:06] 
[00:59:06] 
[00:59:06] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-linux-gnu --target x86_64-unknown-linux-gnu
[00:59:06] Build completed unsuccessfully in 0:53:26

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

1 similar comment
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jul 11, 2018

The job dist-x86_64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_fold:end:services

travis_fold:start:git.checkout
travis_time:start:08fbd86e
$ git clone --depth=2 --branch=try https://github.com/rust-lang/rust.git rust-lang/rust
---
[00:59:05]     Checking rustc_lsan v0.0.0 (file:///checkout/src/librustc_lsan)
[00:59:05]     Checking panic_unwind v0.0.0 (file:///checkout/src/libpanic_unwind)
[00:59:05]     Checking rustc_msan v0.0.0 (file:///checkout/src/librustc_msan)
[00:59:05]  Documenting std v0.0.0 (file:///checkout/src/libstd)
[00:59:06] error: macro expansion ignores token `{` and any following
[00:59:06]     |
[00:59:06]     |
[00:59:06] 771 |         ($file:expr) => ({ /* compiler built-in */ });
[00:59:06]     |
[00:59:06]     |
[00:59:06] note: caused by the macro expansion here; the usage of `include!` is likely invalid in item context
[00:59:06]    --> libstd/lib.rs:548:1
[00:59:06]     |
[00:59:06] 548 | include!("primitive_docs.rs");
[00:59:06] 
[00:59:06] 
[00:59:06] error: macro expansion ignores token `{` and any following
[00:59:06]     |
[00:59:06]     |
[00:59:06] 771 |         ($file:expr) => ({ /* compiler built-in */ });
[00:59:06]     |
[00:59:06]     |
[00:59:06] note: caused by the macro expansion here; the usage of `include!` is likely invalid in item context
[00:59:06]    --> libstd/lib.rs:553:1
[00:59:06]     |
[00:59:06] 553 | include!("keyword_docs.rs");
[00:59:06] 
[00:59:06] 
[00:59:06] error: Could not document `std`.
[00:59:06] Caused by:
[00:59:06] Caused by:
[00:59:06]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --crate-name std libstd/lib.rs --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/doc --cfg feature="alloc_jemalloc" --cfg feature="backtrace" --cfg feature="jemalloc" --cfg feature="panic-unwind" --cfg feature="panic_unwind" --cfg feature="profiler" --cfg feature="profiler_builtins" -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps --extern alloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liballoc-11f645d5d50ec01d.rmeta --extern alloc_jemalloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liballoc_jemalloc-b47ce328a4ba70ee.rmeta --extern alloc_system=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liballoc_system-f97b2ca8b6ea07bd.rmeta --extern compiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcompiler_builtins-a79b1686dcdb6599.rmeta --extern core=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcore-9dfdb611cdf09a22.rmeta --extern libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liblibc-e113f9b9a0aa6586.rmeta --extern panic_abort=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libpanic_abort-afa6c0a795054c51.rmeta --extern panic_unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libpanic_unwind-4f996473c57ff2d7.rmeta --extern profiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libprofiler_builtins-96fc30c656f77bfd.rmeta --extern rustc_asan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_asan-6678a520a240f250.rmeta --extern rustc_lsan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_lsan-2b28bf250e8c19b3.rmeta --extern rustc_msan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_msan-72f2ee3ef3ce967d.rmeta --extern rustc_tsan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_tsan-f130431124e944fe.rmeta --extern std_unicode=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libstd_unicode-3448644921326dc8.rmeta --extern unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libunwind-62dce3cd9306a1e4.rmeta` (exit code: 101)
[00:59:06] 
[00:59:06] 
[00:59:06] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "doc" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace profiler" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--no-deps" "-p" "alloc" "-p" "core" "-p" "std" "-p" "std_unicode"
[00:59:06] 
[00:59:06] 
[00:59:06] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-linux-gnu --target x86_64-unknown-linux-gnu
[00:59:06] Build completed unsuccessfully in 0:53:26

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@petrochenkov

This comment has been minimized.

Copy link
Contributor Author

petrochenkov commented Jul 11, 2018

Is it necessary to fix the std doc generation mode (cfg(dox)) to run crater?

@pietroalbini

This comment has been minimized.

Copy link
Member

pietroalbini commented Jul 11, 2018

I don't think std docs needs to be working to get a crater run, but a successful try build is needed.

@petrochenkov petrochenkov force-pushed the petrochenkov:macuse2 branch from ee16ce1 to 1f844a8 Jul 11, 2018

@petrochenkov

This comment has been minimized.

Copy link
Contributor Author

petrochenkov commented Jul 11, 2018

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 11, 2018

⌛️ Trying commit 1f844a8 with merge d39a6f7...

bors added a commit that referenced this pull request Jul 11, 2018

Auto merge of #52234 - petrochenkov:macuse2, r=<try>
[Experiment] resolve: Modularize crate-local `#[macro_export] macro_rules`

Based on #50911, cc #50911 (comment)

`#[macro_export] macro_rules` items are collected from the whole crate and are planted into the root module as items, so the external view of the crate is symmetric with its internal view and something like `$crate::my_macro` where `my_macro` is `#[macro_export] macro_rules` works both locally and from other crates.

This PR turns deprecation lint `duplicate_macro_exports` introduced in #50143 into a hard error, so regressions from it will have to be filtered away from crater results. The lint can be reimplemented later in the new setup.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jul 11, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/2d/99/b2c4e9d5a30f6471e410a146232b4118e697fa3ffc06d6a65efde84debd0/futures-3.2.0-py2-none-any.whl
Requirement already satisfied: six>=1.5 in /usr/lib/python2.7/dist-packages (from python-dateutil<3.0.0,>=2.1; python_version >= "2.7"->botocore==1.10.55->awscli)
Building wheels for collected packages: awscli
  Running setup.py bdist_wheel for awscli ... - \ | / - \ done
Successfully built awscli
Installing collected packages: docutils, jmespath, python-dateutil, botocore, colorama, pyasn1, rsa, futures, s3transfer, awscli
Successfully installed awscli-1.15.56 botocore-1.10.55 colorama-0.3.9 docutils-0.14 futures-3.2.0 jmespath-0.9.3 pyasn1-0.4.3 python-dateutil-2.7.3 rsa-3.4.2 s3transfer-0.1.13
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
---
[01:10:19] travis_fold:end:stage0-linkchecker

[01:10:19] travis_time:end:stage0-linkchecker:start=1531308106477156288,finish=1531308108797621155,duration=2320464867

[01:10:19] std/macro.assert_ne.html:11: broken link - std/macro.assert.html
[01:10:21] std/macro.assert_eq.html:11: broken link - std/macro.assert.html
[01:10:21] std/io/trait.Write.html:121: broken link - std/macro.format_args.html
[01:10:23] std/macro.panic.html:26: broken link - std/macro.compile_error.html
[01:10:25] std/macro.debug_assert.html:8: broken link - std/macro.assert.html
[01:10:25] std/macro.debug_assert.html:11: broken link - std/macro.assert.html
[01:10:25] std/macro.debug_assert.html:20: broken link - std/macro.assert.html
[01:10:26] std/primitive.bool.html:7: broken link - std/macro.assert.html
[01:10:26] std/fmt/fn.format.html:3: broken link - std/macro.format_args.html
[01:10:26] std/fmt/index.html:234: broken link - std/macro.format_args.html
[01:10:26] std/fmt/struct.Arguments.html:5: broken link - std/macro.format_args.html
[01:10:26] std/fmt/struct.Arguments.html:8: broken link - std/macro.format_args.html
[01:10:26] std/fmt/struct.Formatter.html:310: broken link - std/macro.format_args.html
[01:10:28] core/macro.assert_ne.html:10: broken link - core/macro.assert.html
[01:10:29] core/macro.assert_eq.html:10: broken link - core/macro.assert.html
[01:10:29] core/macro.debug_assert.html:8: broken link - core/macro.assert.html
[01:10:29] core/macro.debug_assert.html:11: broken link - core/macro.assert.html
[01:10:29] core/macro.debug_assert.html:20: broken link - core/macro.assert.html
[01:10:30] core/fmt/struct.Arguments.html:5: broken link - std/macro.format_args.html
[01:10:30] core/fmt/struct.Arguments.html:8: broken link - std/macro.format_args.html
[01:10:30] core/fmt/struct.Formatter.html:310: broken link - std/macro.format_args.html
[01:10:34] alloc/fmt/fn.format.html:3: broken link - std/macro.format_args.html
[01:10:34] alloc/fmt/index.html:234: broken link - std/macro.format_args.html
[01:10:34] alloc/fmt/struct.Arguments.html:5: broken link - std/macro.format_args.html
[01:10:34] alloc/fmt/struct.Arguments.html:8: broken link - std/macro.format_args.html
[01:10:34] alloc/fmt/struct.Formatter.html:310: broken link - std/macro.format_args.html
[01:10:34] thread 'main' panicked at 'found some broken links', tools/linkchecker/main.rs:49:9
[01:10:34] 
[01:10:34] 
[01:10:34] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:10:34] expected success, got: exit code: 101
[01:10:34] expected success, got: exit code: 101
[01:10:34] 
[01:10:34] 
[01:10:34] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:10:34] Build completed unsuccessfully in 0:28:45
[01:10:34] Makefile:58: recipe for target 'check' failed
[01:10:34] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:04291a7c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 11, 2018

☀️ Test successful - status-travis
State: approved= try=True

@pietroalbini

This comment has been minimized.

Copy link
Member

pietroalbini commented Jul 11, 2018

@craterbot run start=master#ae5b629efd79de78e6ba7ef493c32857bd7f9cf9 end=try#d39a6f7eddafd45dcc60e99001b8cd08c2bd3255 mode=check-only

@craterbot

This comment has been minimized.

Copy link
Collaborator

craterbot commented Jul 11, 2018

👌 Experiment pr-52234 created and queued.

ℹ️ Crater is a tool to run experiments across the whole Rust ecosystem. Learn more

@craterbot

This comment has been minimized.

Copy link
Collaborator

craterbot commented Jul 11, 2018

🚧 Experiment pr-52234 is now running on agent crater-1.

ℹ️ Crater is a tool to run experiments across the whole Rust ecosystem. Learn more

@craterbot

This comment has been minimized.

Copy link
Collaborator

craterbot commented Jul 12, 2018

🎉 Experiment pr-52234 is completed!
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across the whole Rust ecosystem. Learn more

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 31, 2018

⌛️ Testing commit 4442240 with merge 1eb96b6...

bors added a commit that referenced this pull request Jul 31, 2018

Auto merge of #52234 - petrochenkov:macuse2, r=alexcrichton
resolve: Modularize crate-local `#[macro_export] macro_rules`

Based on #50911, cc #50911 (comment)

`#[macro_export] macro_rules` items are collected from the whole crate and are planted into the root module as items, so the external view of the crate is symmetric with its internal view and something like `$crate::my_macro` where `my_macro` is `#[macro_export] macro_rules` works both locally and from other crates.

Closes #52726
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 31, 2018

💔 Test failed - status-travis

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jul 31, 2018

The job dist-x86_64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:056cdbd9:start=1533020447648454921,finish=1533020447654873279,duration=6418358
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:05482a44
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:30228eaa
travis_time:start:30228eaa
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0866ffa0
$ dmesg | grep -i kill
$ dmesg | grep -i kill
[   10.110735] init: failsafe main process (1093) killed by TERM signal
[   41.397264] init: plymouth-upstart-bridge main process (510) killed by TERM signal
travis_fold:end:after_failure.6

Done. Your build exited with 1.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@pietroalbini

This comment has been minimized.

Copy link
Member

pietroalbini commented Jul 31, 2018

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Jul 31, 2018

@bors r+ p=10

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 31, 2018

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #50267
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 31, 2018

📌 Commit 4442240 has been approved by Mark-Simulacrum

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 31, 2018

⌛️ Testing commit 4442240 with merge 78016da...

bors added a commit that referenced this pull request Jul 31, 2018

Auto merge of #52234 - petrochenkov:macuse2, r=Mark-Simulacrum
resolve: Modularize crate-local `#[macro_export] macro_rules`

Based on #50911, cc #50911 (comment)

`#[macro_export] macro_rules` items are collected from the whole crate and are planted into the root module as items, so the external view of the crate is symmetric with its internal view and something like `$crate::my_macro` where `my_macro` is `#[macro_export] macro_rules` works both locally and from other crates.

Closes #52726
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 31, 2018

💔 Test failed - status-travis

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jul 31, 2018

The job dist-x86_64-freebsd of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:27:53] [RUSTC-TIMING] proc_macro test:false 10.917
[00:27:53]    Compiling syntax_ext v0.0.0 (file:///checkout/src/libsyntax_ext)
[00:28:17] [RUSTC-TIMING] syntax_ext test:false 24.069

Broadcast message from root@travis-job-33a5b1b6-36b2-4b2f-8752-c7410a7db509
 (unknown) at 19:56 ...
The system is going down for power off NOW!
[00:29:03] 
[00:29:03] Session terminated, terminating shell... ...terminated.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 143.
travis_time:start:24f636f9
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@pietroalbini

This comment has been minimized.

Copy link
Member

pietroalbini commented Jul 31, 2018

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 31, 2018

⌛️ Testing commit 4442240 with merge e94df4a...

bors added a commit that referenced this pull request Jul 31, 2018

Auto merge of #52234 - petrochenkov:macuse2, r=Mark-Simulacrum
resolve: Modularize crate-local `#[macro_export] macro_rules`

Based on #50911, cc #50911 (comment)

`#[macro_export] macro_rules` items are collected from the whole crate and are planted into the root module as items, so the external view of the crate is symmetric with its internal view and something like `$crate::my_macro` where `my_macro` is `#[macro_export] macro_rules` works both locally and from other crates.

Closes #52726
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 31, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing e94df4a to master...

@bors bors merged commit 4442240 into rust-lang:master Jul 31, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.