Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upresolve: Functions introducing procedural macros reserve a slot in the macro namespace as well #52383
Conversation
rust-highfive
assigned
eddyb
Jul 14, 2018
This comment has been minimized.
This comment has been minimized.
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
label
Jul 14, 2018
This comment has been minimized.
This comment has been minimized.
|
cc @alercah |
rust-highfive
assigned
alexcrichton
and unassigned
eddyb
Jul 14, 2018
This comment has been minimized.
This comment has been minimized.
|
Seems plausible to me. |
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-bors
and removed
S-waiting-on-review
labels
Jul 15, 2018
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Jul 15, 2018
This comment has been minimized.
This comment has been minimized.
|
|
bors
merged commit 431aefb
into
rust-lang:master
Jul 15, 2018
pitdicker
referenced this pull request
Jul 17, 2018
Closed
Fails to build on recent nightly (2018-07-17) #252
petrochenkov
referenced this pull request
Sep 11, 2018
Merged
resolve: Introduce two sub-namespaces in macro namespace #54069
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
petrochenkov commentedJul 14, 2018
Similarly to #52234, this gives us symmetry between internal and external views of a crate, but in this case it's always an error to call a procedural macro in the same crate in which it's defined.
Closes #52225