New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Preliminary work splitting const qualification into separate passes #52518

Open
wants to merge 10 commits into
base: master
from

Conversation

Projects
None yet
@alexreg
Contributor

alexreg commented Jul 19, 2018

r? @eddyb

CC @oli-obk

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Jul 19, 2018

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment was marked as outdated.

Collaborator

rust-highfive commented Jul 19, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:03:59] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:00] tidy error: /checkout/src/librustc_data_structures/indexed_set.rs:212: trailing whitespace
[00:04:00] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:309: trailing whitespace
[00:04:00] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:685: trailing whitespace
[00:04:01] some tidy checks failed
[00:04:01] 
[00:04:01] 
[00:04:01] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:01] 
[00:04:01] 
[00:04:01] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:01] Build completed unsuccessfully in 0:00:51
[00:04:01] Build completed unsuccessfully in 0:00:51
[00:04:01] Makefile:79: recipe for target 'tidy' failed
[00:04:01] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0023f23f
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:1ca4f3f0:start=1531971991610291738,finish=1531971991617218032,duration=6926294
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:3229f440
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:00e53b3c
travis_time:start:00e53b3c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:080c9160
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@@ -101,7 +101,9 @@ struct Qualifier<'a, 'gcx: 'a+'tcx, 'tcx: 'a> {
rpo: ReversePostorder<'a, 'tcx>,
tcx: TyCtxt<'a, 'gcx, 'tcx>,
param_env: ty::ParamEnv<'tcx>,
local_qualif: IndexVec<Local, Option<Qualif>>,

This comment has been minimized.

@oli-obk

oli-obk Jul 19, 2018

Contributor

The commit message isn't up to date anymore. The temp + return merge is already in master

Show resolved Hide resolved src/test/compile-fail/const-block-non-item-statement.rs Outdated
@@ -175,6 +176,7 @@ pub enum EvalErrorKind<'tcx, O> {
NoMirFor(String),
UnterminatedCString(Pointer),
DanglingPointerDeref,
ExternStaticRead(DefId),

This comment has been minimized.

@oli-obk

oli-obk Jul 19, 2018

Contributor

This is introduced here and removed two commits later. Merge the commits into each other?

@alexreg alexreg force-pushed the alexreg:const-qualif branch from ab1fa82 to 2f57769 Jul 19, 2018

@rust-highfive

This comment was marked as outdated.

Collaborator

rust-highfive commented Jul 19, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:03:40] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:40] tidy error: /checkout/src/librustc_data_structures/indexed_set.rs:212: trailing whitespace
[00:03:41] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:309: trailing whitespace
[00:03:41] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:685: trailing whitespace
[00:03:42] some tidy checks failed
[00:03:42] 
[00:03:42] 
[00:03:42] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:42] 
[00:03:42] 
[00:03:42] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:42] Build completed unsuccessfully in 0:00:46
[00:03:42] Build completed unsuccessfully in 0:00:46
[00:03:42] Makefile:79: recipe for target 'tidy' failed
[00:03:42] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:002cd4a8
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:264f6840:start=1532015209114302543,finish=1532015209121844963,duration=7542420
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0b59be8e
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:185bf2a8
travis_time:start:185bf2a8
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0fc0b61c
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexreg alexreg force-pushed the alexreg:const-qualif branch from 2f57769 to 965d6c6 Jul 19, 2018

@rust-highfive

This comment was marked as outdated.

Collaborator

rust-highfive commented Jul 19, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:03:44] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:44] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:309: trailing whitespace
[00:03:44] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:685: trailing whitespace
[00:03:45] some tidy checks failed
[00:03:45] 
[00:03:45] 
[00:03:45] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:45] 
[00:03:45] 
[00:03:45] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:45] Build completed unsuccessfully in 0:00:50
[00:03:45] Build completed unsuccessfully in 0:00:50
[00:03:45] Makefile:79: recipe for target 'tidy' failed
[00:03:45] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:139f172c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0039501c:start=1532016692634763507,finish=1532016692640644642,duration=5881135
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0709fb3c
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:379f1fb8
travis_time:start:379f1fb8
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:2f975b77
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexreg alexreg force-pushed the alexreg:const-qualif branch from 965d6c6 to 4957866 Jul 19, 2018

@rust-highfive

This comment was marked as outdated.

Collaborator

rust-highfive commented Jul 19, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:34:43]    Compiling libc v0.2.42
[00:34:43]    Compiling void v1.0.2
[00:34:43]    Compiling ucd-util v0.1.1
[00:34:43]    Compiling lazy_static v1.0.2
[00:34:43] error: Could not compile `libc`.
[00:34:43] warning: build failed, waiting for other jobs to finish...
[00:34:43] error: Could not compile `void`.
[00:34:43] warning: build failed, waiting for other jobs to finish...
[00:34:43] error: Could not compile `ucd-util`.
[00:34:43] warning: build failed, waiting for other jobs to finish...
[00:34:43] error: Could not compile `lazy_static`.
[00:34:43] To learn more, run the command again with --verbose.
[00:34:43] 
[00:34:43] 
[00:34:43] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/rustdoc/Cargo.toml"
[00:34:43] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/rustdoc/Cargo.toml"
[00:34:43] expected success, got: exit code: 101
[00:34:43] 
[00:34:43] 
[00:34:43] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:34:43] Build completed unsuccessfully in 0:30:56
[00:34:43] Makefile:28: recipe for target 'all' failed
[00:34:43] make: *** [all] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:001a95d8
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:1f862090:start=1532019514834552146,finish=1532019514842212941,duration=7660795
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:078dfede
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:start:crashlog
obj/cores/core.12132.!checkout!obj!build!x86_64-unknown-linux-gnu!stage2!bin!rustc
Source directories searched: /home/travis/build/rust-lang/rust/src:$cdir:$cwd
Reading symbols from obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc...(no debugging symbols found)...done.
[New LWP 12132]
warning: Could not load shared library symbols for 14 libraries, e.g. /lib/x86_64-linux-gnu/libc.so.6.
Use the "info sharedlibrary" command to see the complete listing.
Do you need "set solib-search-path" or "set sysroot"?
Core was generated by `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc --crate-name libc'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00007f6106800801 in core::hash::impls::_$LT$impl$u20$core..hash..Hash$u20$for$u20$str$GT$::hash::hb452fae37f72bb61 ()
   from ./checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/../lib/../lib/libsyntax_pos-59496eb2bd12a70c.so
#0  0x00007f6106800801 in core::hash::impls::_$LT$impl$u20$core..hash..Hash$u20$for$u20$str$GT$::hash::hb452fae37f72bb61 ()
   from ./checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/../lib/../lib/libsyntax_pos-59496eb2bd12a70c.so
#1  0x00007f61067ff29e in syntax_pos::symbol::Interner::intern::hde59d124a63d249d ()
   from ./checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/../lib/../lib/libsyntax_pos-59496eb2bd12a70c.so
#2  0x00007f61067fbb66 in _$LT$scoped_tls..ScopedKey$LT$T$GT$$GT$::with::h30ed98782fc5336d ()
   from ./checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/../lib/../lib/libsyntax_pos-59496eb2bd12a70c.so
#3  0x00007f61067fe8ef in syntax_pos::symbol::Ident::from_str::hb535b36bfc79fa6c ()
   from ./checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/../lib/../lib/libsyntax_pos-59496eb2bd12a70c.so
#4  0x00007f6106f9b07b in syntax::std_inject::maybe_inject_crates_ref::h254676ead5da4fb7 ()
   from ./checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/../lib/../lib/libsyntax-7590698bfcad744b.so
#5  0x00007f610c0d4891 in rustc::util::common::time::h3e1233bb51514896 ()
   from ./checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/../lib/librustc_driver-3cfba80c664ed664.so
#6  0x00007f610c107829 in rustc_driver::driver::phase_2_configure_and_expand::h8c794a1f3e54b72d ()
   from ./checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/../lib/librustc_driver-3cfba80c664ed664.so
#7  0x00007f610c10370e in rustc_driver::driver::compile_input::h60313df4a8b21bd6 ()
   from ./checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/../lib/librustc_driver-3cfba80c664ed664.so
---Type <return> to continue, or q <return> to quit---

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@nikomatsakis

This comment has been minimized.

Contributor

nikomatsakis commented Jul 19, 2018

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned nikomatsakis Jul 19, 2018

@alexreg alexreg force-pushed the alexreg:const-qualif branch 2 times, most recently from d3af745 to 55e384f Jul 20, 2018

@rust-highfive

This comment was marked as outdated.

Collaborator

rust-highfive commented Jul 21, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_fold:start:step_start_instance
Starting instance
✓ selected image "travis-ci-connie-trusty-1512502258-986baf0"
✓ rendered startup script
✓ inserted instance
• sleeping 25s before checking instance insert
• polling for instance insert completion...
✓ instance is ready (26.515s)
travis_fold:end:step_start_instance
travis_fold:start:step_upload_script
Uploading script
• waiting for ssh connectivity..........................
✓ ssh connectivity established (23.709s)
✓ uploaded script
travis_fold:end:step_upload_script
Worker information
hostname: b9f08c07-18e0-46ef-b512-3bfe40b39e43@1.production-4-worker-org-b-2-gce
hostname: b9f08c07-18e0-46ef-b512-3bfe40b39e43@1.production-4-worker-org-b-2-gce
version: v3.12.0-4-g8111060 https://github.com/travis-ci/worker/tree/811106032d78b3bff03434ed431e3ac90542781d
startup: 26.515513245s
travis_fold:end:worker_info
travis_fold:start:system_info
Build system information
---
    100% |████████████████████████████████| 61kB 7.2MB/s 
Collecting botocore==1.10.62 (from awscli)
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/24/ec/95df2edaa21e426581f41745e0de355170b8cb6eed2a2a5641c0c348df33/botocore-1.10.62-py2.py3-none-any.whl (4.4MB)
    0% |                                | 10kB 43.2MB/s eta 0:00:01
    0% |▏                               | 20kB 31.2MB/s eta 0:00:01
    0% |▎                               | 30kB 37.9MB/s eta 0:00:01
    0% |▎                               | 40kB 13.8MB/s eta 0:00:01
---
[00:47:21] ....................................................................................................
[00:47:33] .......................................................................i...........................F
[00:47:43] ....................................................................................................
[00:47:54] .............................................................................................i......
[00:48:03] ..........F.........................................................................................
[00:48:26] ....................................................................................................
[00:48:35] .........................................................................i..........................
[00:48:44] ........................................................................i...........................
[00:49:01] ....................................................................................................

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

let store = |this: &mut Self, index| {
this.local_mut_interior.set_member(&index, this.qualif.mut_interior);
this.local_needs_drop.set_member(&index, this.qualif.needs_drop);
this.local_not_const.set_member(&index, this.qualif.not_const);
};

// Only handle promotable temps in non-const functions.
if self.mode == Mode::Fn {
if let Place::Local(index) = *dest {
if self.mir.local_kind(index) == LocalKind::Temp

This comment has been minimized.

@oli-obk

oli-obk Jul 21, 2018

Contributor

I believe the failure here is due to this not also entering this arm in case of LocalKind::ReturnPointer. Although I don't see how that worked before!?

@alexreg alexreg force-pushed the alexreg:const-qualif branch from 55e384f to 339df90 Jul 21, 2018

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Jul 21, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:03:57] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:57] tidy error: /checkout/src/test/ui/issue-14227.rs:24: line longer than 100 chars
[00:03:57] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:1076: line longer than 100 chars
[00:03:59] some tidy checks failed
[00:03:59] 
[00:03:59] 
[00:03:59] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:59] 
[00:03:59] 
[00:03:59] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:59] Build completed unsuccessfully in 0:00:54
[00:03:59] Build completed unsuccessfully in 0:00:54
[00:03:59] Makefile:79: recipe for target 'tidy' failed
[00:03:59] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:067949db
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:01a85238:start=1532193485462531910,finish=1532193485469597926,duration=7066016
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:05d88ddf
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:192a8690
travis_time:start:192a8690
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:05005e51
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexreg alexreg force-pushed the alexreg:const-qualif branch from 339df90 to 2966a14 Jul 21, 2018

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Jul 21, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:48:59] ....................................................................................................
[00:49:02] ....................................................................................................
[00:49:05] ....................................................................................................
[00:49:07] ....................................................................................................
[00:49:11] ....................................................FFF................FF..................i........
[00:49:16] ....................................................................................i...............
[00:49:19] .............................i......................................................................
[00:49:19] .............................i......................................................................
[00:49:23] ....................................F...............................................................
[00:49:31] .......................................................i..ii........................................
[00:49:35] ....................................................................................................
[00:49:38] ....................................................................................................
[00:49:40] ....................................................................................................
[00:49:40] ....................................................................................................
[00:49:43] .......................................i............................................................
[00:49:46] ....................................................................................................
[00:49:49] ....................................................................................................
          Error
[00:49:53]         ),
[00:49:53]         msg: "22:1: 22:35: statements in constants are unstable (see issue #48821) [E0658]"
[00:49:53] ]
[00:49:53] 
[00:49:53] not found errors (from test file): [
[00:49:53]     Error {
---
[00:49:53] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:49:53] 
[00:49:53] ---- [compile-fail] compile-fail/const-block-non-item-statement-3.rs stdout ----
[00:49:53] 
[00:49:53] error: /checkout/src/test/compile-fail/const-block-non-item-statement-3.rs:11: unexpected error: '11:20: 11:37: let bindings in constants are unstable (see issue #48821) [E0658]'
[00:49:53] 
[00:49:53] error: /checkout/src/test/compile-fail/const-block-non-item-statement-3.rs:11: unexpected error: '11:20: 11:37: statements in constants are unstable (see issuheckout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/compile-fail/const-fn-destructuring-arg.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail/const-fn-destructuring-arg/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail/const-fn-destructuring-arg/auxiliary" "-A" "unused"
[00:49:53]     Error {
[00:49:53]         line_num: 17,
[00:49:53]         kind: Some(
[00:49:53]             Error
[00:49:53]             Error
[00:49:53]         ),
[00:49:53]         msg: "17:13: 17:14: let bindings in constant functions are unstable (see issue #48821) [E0658]"
[00:49:53]     Error {
[00:49:53]         line_num: 17,
[00:49:53]         kind: Some(
[00:49:53]             Error
[00:49:53]             Error
[00:49:53]         ),
[00:49:53]         msg: "17:13: 17:14: statements in constant functions are unstable (see issue #48821) [E0658]"
[00:49:53]     Error {
[00:49:53]         line_num: 19,
[00:49:53]         kind: Some(
[00:49:53]             Error
[00:49:53]             Error
[00:49:53]         ),
[00:49:53]         msg: "19:13: 19:14: let bindings in constant functions are unstable (see issue #48821) [E0658]"
[00:49:53]     Error {
[00:49:53]         line_num: 19,
[00:49:53]         kind: Some(
[00:49:53]             Error
[00:49:53]             Error
[00:49:53]         ),
[00:49:53]         msg: "19:13: 19:14: statements in constant funcn-linux-gnu/release
121696 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps
111564 ./obj/build/x86_64-unknown-linux-gnu/stage1-std
107600 ./src/llvm/test/CodeGen
102364 ./obj/cores

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexreg alexreg force-pushed the alexreg:const-qualif branch from dd85a5e to a0b32f8 Jul 21, 2018

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Jul 21, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:03:53] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:53] tidy error: /checkout/src/librustc_data_structures/indexed_set.rs:212: trailing whitespace
[00:03:54] some tidy checks failed
[00:03:54] 
[00:03:54] 
[00:03:54] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:54] 
[00:03:54] 
[00:03:54] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:54] Build completed unsuccessfully in 0:00:47
[00:03:54] Build completed unsuccessfully in 0:00:47
[00:03:54] Makefile:79: recipe for target 'tidy' failed
[00:03:54] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0a23fe20
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0a484264:start=1532208823101840621,finish=1532208823109019494,duration=7178873
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:25e17e11
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:00378078
travis_time:start:00378078
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:02b839b0
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@TimNN

This comment has been minimized.

Contributor

TimNN commented Aug 7, 2018

Ping from triage, @alexreg. It looks like some changes have been requested to your PR.

@alexreg

This comment has been minimized.

Contributor

alexreg commented Aug 7, 2018

@TimNN Yeah, I was away on holiday, but just getting to them now. Hopefully will have them resolved in the next day or two. :-)

@Aaronepower

This comment has been minimized.

Contributor

Aaronepower commented Aug 21, 2018

Triage: @alexreg Hope you had a good holiday. Can you give a status update on this PR?

@mark-i-m

This comment has been minimized.

Contributor

mark-i-m commented Aug 21, 2018

@Aaronepower

It looks like @eddyb is needed: #49146 (comment)

@Aaronepower

This comment has been minimized.

Contributor

Aaronepower commented Aug 21, 2018

@mark-i-m Thank you, I've updated the status of the PR to reflect this.

@alexreg

This comment has been minimized.

Contributor

alexreg commented Aug 21, 2018

@Aaronepower Yep. I've been pestering @eddyb about this for a while. I think he'll finally get around to it soon. :-)

@pietroalbini

This comment has been minimized.

Member

pietroalbini commented Aug 27, 2018

Ping from triage @eddyb! This PR needs your review.

@TimNN

This comment has been minimized.

Contributor

TimNN commented Sep 4, 2018

Ping from triage @eddyb / @rust-lang/compiler: This PR requires your review.

1 similar comment
@TimNN

This comment has been minimized.

Contributor

TimNN commented Sep 11, 2018

Ping from triage @eddyb / @rust-lang/compiler: This PR requires your review.

@alexreg

This comment has been minimized.

Contributor

alexreg commented Sep 12, 2018

@TimNN Appreciate your efforts to try to get @eddyb to review this... I've spoken with him on Discord though, and he's too busy with 2018 Edition stuff at this moment. That said, a week today (or tomorrow) he should be able to tackle this! :-)

@RalfJung

This comment has been minimized.

Member

RalfJung commented Sep 29, 2018

Conflict ahead: #54424

@alexreg

This comment has been minimized.

Contributor

alexreg commented Sep 29, 2018

@RalfJung Okay thanks for the notice. I don't think it will matter too much, since @eddyb will either be significantly reworking this or redoing it from scratch shortly.

@TimNN

This comment has been minimized.

Contributor

TimNN commented Oct 16, 2018

Ping from triage @eddyb / @alexreg: What is the status of this PR?

@alexreg

This comment has been minimized.

Contributor

alexreg commented Oct 16, 2018

@eddyb Still waiting on @eddyb... he's been AWOL for a little while now.

@TimNN TimNN added A-allocators and removed A-allocators labels Oct 30, 2018

@TimNN

This comment has been minimized.

Contributor

TimNN commented Nov 13, 2018

Ping from triage @eddyb / @rust-lang/compiler: What are your plans for this PR?

@estebank

This comment has been minimized.

Contributor

estebank commented Nov 13, 2018

Side note: please do not leave merge commits in the PR.

@alexreg

This comment has been minimized.

Contributor

alexreg commented Nov 14, 2018

@estebank That's a rebase gone wrong I think. :-P

@TimNN

This comment has been minimized.

Contributor

TimNN commented Nov 20, 2018

Ping from triage @eddyb: This PR requires your review!

@TimNN

This comment has been minimized.

Contributor

TimNN commented Nov 27, 2018

Ping from triage @eddyb / @rust-lang/compiler! This PR requires your review.

@Centril

This comment has been minimized.

Contributor

Centril commented Dec 1, 2018

Ping from triage @eddyb / @rust-lang/compiler -- we are eagerly awaiting your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment