Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd lldb to the build #52716
Conversation
rust-highfive
assigned
aturon
Jul 25, 2018
This comment has been minimized.
This comment has been minimized.
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
rust-highfive
added
the
S-waiting-on-review
label
Jul 25, 2018
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment has been minimized.
This comment has been minimized.
|
I'll send a patch to tidy. |
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment has been minimized.
This comment has been minimized.
|
My current theory is that the new dist rule is using the wrong test in |
This comment has been minimized.
This comment has been minimized.
rust-highfive
assigned
Mark-Simulacrum
and unassigned
aturon
Jul 27, 2018
Mark-Simulacrum
reviewed
Jul 27, 2018
|
|
||
| // Do nothing if lldb was not built. This is difficult to | ||
| // determine in should_run because the target is not available | ||
| // at that point. |
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrum
Jul 27, 2018
Member
Can omit this comment -- this is the expected way of doing things, should_run is very high-level.
| let libdir = builder.llvm_out(target).join("lib"); | ||
| let dst = image.join("lib"); | ||
| t!(fs::create_dir_all(&dst)); | ||
| for entry in t!(fs::read_dir(&libdir)) { |
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrum
Jul 27, 2018
Member
You'll probably want to add a if self.config.dry_run { return; } somewhere in here since the read_dir will fail on dry run builds otherwise.
This comment has been minimized.
This comment has been minimized.
|
Is this waiting on me for something? I believe the changes look good. |
This comment has been minimized.
This comment has been minimized.
Yes, I think so. Edit: I should have said, I think @nrc switched the review to you, so my belief is that if you think it is ok, then you can merge it. However you're likely to know better than I do. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-bors
and removed
S-waiting-on-review
labels
Jul 31, 2018
This comment has been minimized.
This comment has been minimized.
|
This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
bors
added
S-waiting-on-author
and removed
S-waiting-on-bors
labels
Aug 1, 2018
tromey
force-pushed the
tromey:rustup-lldb
branch
from
14b38bf
to
6f5c66d
Aug 1, 2018
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment has been minimized.
This comment has been minimized.
|
I don't understand that failure but I will ask around about it tomorrow. The |
This comment has been minimized.
This comment has been minimized.
|
Maybe it's just because the Cargo.lock change somehow didn't survive the rebase. |
tromey
force-pushed the
tromey:rustup-lldb
branch
from
6f5c66d
to
1d43f25
Aug 2, 2018
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
bors
removed
the
S-waiting-on-author
label
Aug 2, 2018
bors
added
S-waiting-on-review
and removed
S-waiting-on-bors
labels
Aug 13, 2018
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-bors
and removed
S-waiting-on-review
labels
Aug 13, 2018
This comment has been minimized.
This comment has been minimized.
|
This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
bors
added
S-waiting-on-author
and removed
S-waiting-on-bors
labels
Aug 13, 2018
tromey
force-pushed the
tromey:rustup-lldb
branch
from
88fafbb
to
dd4cf7f
Aug 13, 2018
This was referenced Aug 13, 2018
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-bors
and removed
S-waiting-on-author
labels
Aug 14, 2018
This comment has been minimized.
This comment has been minimized.
|
This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
bors
added
S-waiting-on-author
and removed
S-waiting-on-bors
labels
Aug 14, 2018
tromey
force-pushed the
tromey:rustup-lldb
branch
from
dd4cf7f
to
6e3a4f4
Aug 15, 2018
This comment has been minimized.
This comment has been minimized.
|
Rebased again. |
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-bors
and removed
S-waiting-on-author
labels
Aug 15, 2018
bors
added a commit
that referenced
this pull request
Aug 15, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
tromey commentedJul 25, 2018
This optionally adds lldb (and clang, which it needs) to the build.
Because rust uses LLVM 7, and because clang 7 is not yet released, a
recent git master version of clang is used.
The lldb that is used includes the Rust plugin.
lldb is only built when asked for, or when doing a nightly build on
macOS. Only macOS is done for now due to difficulties with the Python
dependency.