Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for unexpected region for local data ReStatic #52809

Merged
merged 1 commit into from Aug 1, 2018

Conversation

Projects
None yet
4 participants
@davidtwco
Copy link
Member

davidtwco commented Jul 28, 2018


// compile-pass

#![feature(nll)]

This comment has been minimized.

@pnkfelix

pnkfelix Jul 31, 2018

Member

Does this test need to utilize #![feature(nll)]? (In other words, is there something in the test itself that requires NLL for it to compile sucessfully?)

Or can we leave that off, and let the compare-mode=nll handle testing that case (and thus get a test for this in both AST-borrowck and NLL modes)

This comment has been minimized.

@davidtwco

davidtwco Jul 31, 2018

Author Member

This test does not compile without #![feature(nll)]. I'm not sure if it is possible to allow a UI test to compile successfully in one compare mode but fail in another.

This comment has been minimized.

@pnkfelix

pnkfelix Aug 1, 2018

Member

You can use #[rustc_error] to support that. There are examples of it elsewhere in the ui/ test suite.

This comment has been minimized.

@pnkfelix

pnkfelix Aug 1, 2018

Member

but having said that, there's no reason to worry about it in this case. If the test does not compile w/o #[feature(nll)], that is fine.

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Aug 1, 2018

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 1, 2018

📌 Commit 8e88d64 has been approved by pnkfelix

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 1, 2018

Rollup merge of rust-lang#52809 - davidtwco:issue-49579, r=pnkfelix
Add test for unexpected region for local data ReStatic

Fixes rust-lang#49579.

r? @pnkfelix @nikomatsakis

bors added a commit that referenced this pull request Aug 1, 2018

Auto merge of #52958 - pietroalbini:rollup, r=pietroalbini
Rollup of 15 pull requests

Successful merges:

 - #52793 (Add test for NLL: unexpected "free region `` does not outlive" error )
 - #52799 (Use BitVector for global sets of AttrId)
 - #52809 (Add test for unexpected region for local data ReStatic)
 - #52834 ([NLL] Allow conflicting borrows of promoted length zero arrays)
 - #52835 (Fix Alias intra doc ICE)
 - #52854 (fix memrchr in miri)
 - #52899 (tests/ui: Add missing mips{64} ignores)
 - #52908 (Use SetLenOnDrop in Vec::truncate())
 - #52915 (Don't count MIR locals as borrowed after StorageDead when finding locals live across a yield terminator)
 - #52926 (rustc: Trim down the `rust_2018_idioms` lint group)
 - #52930 (rustc_resolve: record single-segment extern crate import resolutions.)
 - #52939 (Make io::Read::read_to_end consider io::Take::limit)
 - #52942 (Another SmallVec.extend optimization)
 - #52947 (1.27 actually added the `armv5te-unknown-linux-musleabi` target)
 - #52954 (async can begin expressions)

Failed merges:

r? @ghost

@bors bors merged commit 8e88d64 into rust-lang:master Aug 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davidtwco davidtwco deleted the davidtwco:issue-49579 branch Aug 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.