Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLL mentions lifetimes that are not included in printed span(s). #52973

Merged
merged 1 commit into from Aug 3, 2018

Conversation

Projects
None yet
4 participants
@davidtwco
Copy link
Member

davidtwco commented Aug 2, 2018

Part of #52663.

r? @pnkfelix

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Aug 2, 2018

The definition point for the lifetime probably isn't the optimal thing to highlight... it would be nice, if we can do it, to highlight the relevant usage points (right)? That is, the points where the lifetime is used in the type(s) relevant to the error message.

Having said that, this is better than nothing, especially since the relevant types are likely to be close to, perhaps even on the same line as, the definition point.

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Aug 2, 2018

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 2, 2018

📌 Commit 2488cb6 has been approved by pnkfelix

cramertj added a commit to cramertj/rust that referenced this pull request Aug 2, 2018

Rollup merge of rust-lang#52973 - davidtwco:issue-52663-lifetimes-not…
…-included-in-span, r=pnkfelix

NLL mentions lifetimes that are not included in printed span(s).

Part of rust-lang#52663.

r? @pnkfelix

cramertj added a commit to cramertj/rust that referenced this pull request Aug 2, 2018

Rollup merge of rust-lang#52973 - davidtwco:issue-52663-lifetimes-not…
…-included-in-span, r=pnkfelix

NLL mentions lifetimes that are not included in printed span(s).

Part of rust-lang#52663.

r? @pnkfelix

bors added a commit that referenced this pull request Aug 2, 2018

Auto merge of #52989 - cramertj:rollup, r=cramertj
Rollup of 10 pull requests

Successful merges:

 - #52716 (Add lldb to the build)
 - #52782 ([NLL] Dangly paths for box)
 - #52886 (cleanup: Remove `Def::GlobalAsm`)
 - #52887 (Disable debug sections when optimization flags is set for LLD.)
 - #52925 (check_const: use the same ParamEnv as codegen for statics)
 - #52927 (Crate store cleanup)
 - #52940 (Align 6-week cycle check with beta promotion instead of stable release.)
 - #52948 (NLL: Better Diagnostic When "Later" means "A Future Loop Iteration")
 - #52952 (Update LLVM submodule)
 - #52973 (NLL mentions lifetimes that are not included in printed span(s).)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 3, 2018

⌛️ Testing commit 2488cb6 with merge 7e031b0...

bors added a commit that referenced this pull request Aug 3, 2018

Auto merge of #52973 - davidtwco:issue-52663-lifetimes-not-included-i…
…n-span, r=pnkfelix

NLL mentions lifetimes that are not included in printed span(s).

Part of #52663.

r? @pnkfelix
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 3, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: pnkfelix
Pushing 7e031b0 to master...

@bors bors merged commit 2488cb6 into rust-lang:master Aug 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@davidtwco davidtwco deleted the davidtwco:issue-52663-lifetimes-not-included-in-span branch Aug 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.