Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

region error messages involving impls are confusing #53124

Merged
merged 3 commits into from Aug 10, 2018

Conversation

Projects
None yet
5 participants
@davidtwco
Copy link
Member

davidtwco commented Aug 6, 2018

Part of #52742.

r? @nikomatsakis

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Aug 6, 2018

@bors r+

1 similar comment
@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Aug 7, 2018

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 7, 2018

📌 Commit 12037ff has been approved by nikomatsakis

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Aug 7, 2018

@bors delegate=davidtwco

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 7, 2018

✌️ @davidtwco can now approve this pull request

cramertj added a commit to cramertj/rust that referenced this pull request Aug 8, 2018

Rollup merge of rust-lang#53124 - davidtwco:issue-52742, r=nikomatsakis
region error messages involving impls are confusing

Part of rust-lang#52742.

r? @nikomatsakis
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 9, 2018

⌛️ Testing commit 12037ff with merge c8cecf4...

bors added a commit that referenced this pull request Aug 9, 2018

Auto merge of #53124 - davidtwco:issue-52742, r=nikomatsakis
region error messages involving impls are confusing

Part of #52742.

r? @nikomatsakis
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 9, 2018

💔 Test failed - status-appveyor

davidtwco added some commits Aug 6, 2018

@kennytm

This comment has been minimized.

Copy link
Member

kennytm commented Aug 9, 2018

@bors r-

 failures:
 ---- [ui] ui\nll\issue-52742.rs stdout ----
 diff of stderr:
-	error: unsatisfied lifetime constraints
-	  --> $DIR/issue-52742.rs:25:9
+	error[E0106]: missing lifetime specifiers
+	  --> $DIR/issue-52742.rs:23:10
3	   |
-	LL |     fn take_bar(&mut self, b: Bar<'_>) {
-	   |                 ---------         -- let's call this `'1`
-	   |                 |
-	   |                 has type `&mut Foo<'_, '2>`
-	LL |         self.y = b.z
-	   |         ^^^^^^^^^^^^ requires that `'1` must outlive `'2`
+	LL | impl Foo<'_, '_> {
+	   |          ^^ expected 2 lifetime parameters
10	
11	error: aborting due to previous error
12	
+	For more information about this error, try `rustc --explain E0106`.
13	
// except according to those terms.

#![feature(nll)]
#![feature(in_band_lifetimes)]

This comment has been minimized.

@nikomatsakis

nikomatsakis Aug 9, 2018

Contributor

the problem here is that we now need another feature gate here

#![feature(impl_header_lifetime_elision)]

This comment has been minimized.

@davidtwco

davidtwco Aug 9, 2018

Author Member

Fixed.

@davidtwco davidtwco force-pushed the davidtwco:issue-52742 branch from 12037ff to 31657c9 Aug 9, 2018

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Aug 9, 2018

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 9, 2018

📌 Commit 31657c9 has been approved by nikomatsakis

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 10, 2018

⌛️ Testing commit 31657c9 with merge f6d43ed...

bors added a commit that referenced this pull request Aug 10, 2018

Auto merge of #53124 - davidtwco:issue-52742, r=nikomatsakis
region error messages involving impls are confusing

Part of #52742.

r? @nikomatsakis
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 10, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing f6d43ed to master...

@bors bors merged commit 31657c9 into rust-lang:master Aug 10, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@davidtwco davidtwco deleted the davidtwco:issue-52742 branch Aug 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.