Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc_resolve: don't allow paths starting with `::crate`. #53347

Merged
merged 1 commit into from Aug 17, 2018

Conversation

Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors T-lang
Projects
None yet
Milestone
No milestone
8 participants
@eddyb @rust-highfive @petrochenkov @joshtriplett @cramertj @Centril @bors @rpjohnst
@eddyb
Copy link
Member

eddyb commented Aug 14, 2018

cc @aturon @joshtriplett
r? @petrochenkov

@rust-highfive rust-highfive assigned petrochenkov Aug 14, 2018

@rust-highfive rust-highfive added the S-waiting-on-review label Aug 14, 2018

@rust-highfive

This comment was marked as resolved.

Sign in to view
Copy link
Collaborator

rust-highfive commented Aug 14, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:22:44]    Compiling crossbeam-epoch v0.3.1
[00:22:46]    Compiling polonius-engine v0.5.0
[00:22:47]    Compiling tempfile v3.0.2
[00:22:48]    Compiling chalk-engine v0.6.0
[00:22:48] error[E0433]: failed to resolve. global paths cannot start with `crate`
[00:22:48]     --> /cargo/registry/src/github.com-1ecc6299db9ec823/chalk-engine-0.6.0/src/logic.rs:1169:11
[00:22:48]      |
[00:22:48] 1169 |         ::crate::maybe_grow_stack(|| self.pursue_strand(depth, strand))
[00:22:48]      |           ^^^^^ global paths cannot start with `crate`
[00:22:49]    Compiling rls-span v0.4.0
[00:22:51]    Compiling rustc_apfloat v0.0.0 (file:///checkout/src/librustc_apfloat)
[00:22:52]    Compiling env_logger v0.5.10
[00:22:52] error: aborting due to previous error
[00:22:52] error: aborting due to previous error
[00:22:52] 
[00:22:52] For more information about this error, try `rustc --explain E0433`.
[00:22:52] error: Could not compile `chalk-engine`.
[00:22:52] 
[00:22:52] Caused by:
[00:22:52]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name chalk_engine /cargo/registry/src/github.com-1ecc6299db9ec823/chalk-engine-0.6.0/src/lib.rs --color always --error-format json --crate-type lib --emit=dep-info,link -C opt-level=2 -C metadata=30c883ec86c7b095 -C extra-filename=-30c883ec86c7b095 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/deps --extern chalk_macros=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps/libchalk_macros-1ec71b9a040fef8a.rlib --extern rustc_hash=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_hash-9bd093322605ad94.rlib --cap-lints allow` (exit code: 1)
[00:22:52] warning: build failed, waiting for other jobs to finish...
02212000, 0x02212fff] PGTABLE
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] BRK [0x02213000, 0x02213fff] PGTABLE
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] RAMDISK: [mem 0x35614000-0x36b01fff]
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] ACPI: Early table checksum verification disabled
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] ACPI: RSDP 0x00000000000F27C0 000014 (v00 Google)
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] ACPI: RSDT 0x00000000BFFF3430 000038 (v01 Google GOOGRSDT 00000001 GOOG 00000001)
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] ACPI: FACP 0x00000000BFFFCF60 0000F4 (v02 Google GOOGFACP 00000001 GOOG 00000001)
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] ACPI: DSDT 0x00000000BFFF3470 0017B2 (v01 Google GOOGDSDT 00000001 GOOG 00000001)
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] ACPI: FACS 0x00000000BFFFCF00 000040
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] ACPI: FACS 0x00000000BFFFCF00 000040
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] ACPI: SSDT 0x00000000BFFF65F0 00690D (v01 Google GOOGSSDT 00000001 GOOG 00000001)
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] ACPI: APIC 0x00000000BFFF5D10 000086 (v01 Google GOOGAPIC 00000001 GOOG 000000015e603d3 kernel: [    0.000000] Early memory node ranges
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000]   node   0: [mem 0x0000000000001000-0x000000000009efff]
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000]   node   0: [mem 0x0000000000100000-0x00000000bfff2fff]
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000]   node   0: [mem 0x0000000100000000-0x00000003ffffffff]
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] Initmem setup node 0 [mem 0x0000000000001000-0x00000003ffffffff]
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] On node 0 totalpages: 3932049
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000]   DMA zone: 64 pages used for memmap
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000]   DMA zone: 21 pages reserved
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000]   DMA zone: 3998 pages, LIFO batch:0
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000]   DMA32 zone: 12224 pages used for memmap
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000]   DMA32 zone: 782323 pages, LIFO batch:31
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000]   Normal zone: 49152 pages used for memmap
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000]   Normal zone: 3145728 pages, LIFO batch:31
Aue603d3 kernel: [    0.000000] Using ACPI (MADT) for SMP configuration information
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] smpboot: Allowing 4 CPUs, 0 hotplug CPUs
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] PM: Registered nosave memory: [mem 0x00000000-0x00000fff]
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] PM: Registered nosave memory: [mem 0x0009f000-0x0009ffff]
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] PM: Registered nosave memory: [mem 0x000a0000-0x000effff]
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] PM: Registered nosave memory: [mem 0x000f0000-0x000fffff]
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] PM: Registered nosave memory: [mem 0xbfff3000-0xbfffffff]
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] PM: Registered nosave memory: [mem 0xc0000000-0xfffbbfff]
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] PM: Registered nosave memory: [mem 0xfffbc000-0xffffffff]
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] e820: [mem 0xc0000000-0xfffbbfff] available for PCI devices
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] Booting paravirtualized kernel on KVM
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] clocksource: refined-jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645519600211568 ns
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] setup_percpu: NR_CPUS:512 nr_cpumask_bits:512 nr_cpu_ids:4 nr_node_ids:1
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] PERCPU: Embedded 34 pages/cpu @ffff8803ffc00000 s98392 r8192 d32680 u524288
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] pcpu-alloc: s98392 r8192 d32680 u524288 alloc=1*2097152
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] pcpu-alloc: [0] 0 1 2 3 
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] Built 1 zonelists in Node order, mobility grouping on.  Total pages: 3870588
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] Policy zone: Normal
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] Kernel command line: BOOT_IMAGE=/boot/vmlinuz-4.4.0-101-generic root=UUID=752b4ef1-0512-4cae-b541-f03ffd29be1b ro cgroup_enable=memory swapaccount=1 apparmor=0 console=ttyS0 console=ttyS0
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] PID hash table entries: 4096 (order: 3, 32768 bytes)
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] Calgary: detecting Calgary via BIOS EBDA area
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] Calgary: Unable to locate Rio Grande table in EBDA - bailing!
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] Memory: 15375492K/15728196K available (8272K kernel code, 1304K rwdata, 4004K rodata, 1496K init, 1316K bss, 352704K reserved, 0K cma-reserved)
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=4, Nodes=1
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] Hierarchical RCU implementation.
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000]  Build-time adjustment of leaf fanout to 64.
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000]  RCU restricting CPUs from NR_CPUS=512 to nr_cpu_ids=4.
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] RCU: Adjusting geometry for rcu_fanout_leaf=64, nr_cpu_ids=4
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] NR_IRQS:33024 nr_irqs:456 16
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] Console: colour VGA+ 80x25
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] console [ttyS0] enabled
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.000000] tsc: Detected 2299.998 MHz processor
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.315090] Calibrating delay loop (skipped) preset value.. 4599.99 BogoMIPS (lpj=9199992)
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.316506] pid_max: default: 32768 minimum: 301
Aug 14 13:54:47 io  0x0d00-0xffff window]
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.679312] pci_bus 0000:00: root bus resource [mem 0x000a0000-0x000bffff window]
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.680452] pci_bus 0000:00: root bus resource [mem 0xc0000000-0xfebfffff window]
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.681926] pci_bus 0000:00: root bus resource [bus 00-ff]
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.682966] pci 0000:00:00.0: [8086:1237] type 00 class 0x060000
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.683425] pci 0000:00:01.0: [8086:7110] type 00 class 0x060100
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.697712] pci 0000:00:01.3: [8086:7113] type 00 class 0x068000
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.710723] pci 0000:00:01.3: quirk: [io  0xb000-0xb03f] claimed by PIIX4 ACPI
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.712338] pci 0000:00:03.0: [1af4:1004] type 00 class 0x000000
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.717705] pci 0000:00:03.0: reg 0x10: [io  0xc000-0xc03f]
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.722729] pci 0000:00:03.0: reg 0x14: [mem 0xfebfe000-0xfebfe07f]
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    0.733900] pci 0000:00:04.0: [1af4:1000] type 00 class 0x020000
Aug 14 13:54:47 travis-job-b9cd9985alizing netlink subsys (disabled)
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.801987] audit: type=2000 audit(1534254879.648:1): initialized
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.803152] Initialise system trusted keyring
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.804078] HugeTLB registered 1 GB page size, pre-allocated 0 pages
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.805037] HugeTLB registered 2 MB page size, pre-allocated 0 pages
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.807228] zbud: loaded
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.808005] VFS: Disk quotas dquot_6.6.0
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.808653] VFS: Dquot-cache hash table entries: 512 (order 0, 4096 bytes)
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.809904] squashfs: version 4.0 (2009/01/31) Phillip Lougher
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.811098] fuse init (API version 7.23)
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.812050] Key type big_key registered
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.812695] Allocating IMA MOK and blacklist keyrings.
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.814765] Key type asymmetric registered
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.815383] Asymmetric key parser 'x509' registered
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.816260] Block layer SCSI generic (bsg) driver version 0.4 loaded (major 249)
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.817414] io scheduler noop registered
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.818047] io scheduler deadline registered (default)
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.818873] io scheduler cfq registered
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.819490] pci_hotplug: PCI Hot Plug PCI Core version: 0.5
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.820281] pciehp: PCI Express Hot Plug Controller Driver version: 0.4
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.821225] intel_idle: does not run on family 6 model 63
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.821321] input: Power Button as /devices/LNXSYSTM:00/LNXPWRBN:00/input/input0
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.822562] ACPI: Power Button [PWRF]
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.823202] input: Sleep Button as /devices/LNXSYSTM:00/LNXSLPBN:00/input/input1
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.824422] ACPI: Sleep Button [SLPF]
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    2.825337] GHES: HEST is not enabled!
Au-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    3.795919] tsc: Refined TSC clocksource calibration: 2300.000 MHz
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    3.796899] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x212735223b2, max_idle_ns: 440795277976 ns
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    4.037497] input: ImExPS/2 Generic Explorer Mouse as /devices/platform/i8042/serio1/input/input4
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    6.111928] floppy0: no floppy controllers found
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    7.255825] raid6: sse2x1   gen()  8858 MB/s
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    7.323819] raid6: sse2x1   xor()  6868 MB/s
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    7.391806] raid6: sse2x2   gen() 11255 MB/s
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    7.459817] raid6: sse2x2   xor()  7576 MB/s
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    7.527836] raid6: sse2x4   gen() 13077 MB/s
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    7.595800] raid6: sse2x4   xor()  9103 MB/s
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    7.663816] raid6: avx2x1   gen() 17184 MB/s
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    7.731802] raid6: avx2x2   gen() 20091 MB/s
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [    7q/31/smp_affinity_list: real affinity 3
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 instance-setup: INFO Setting /proc/irq/32/smp_affinity_list to 3 for device virtio1.
Aug 14 13:54:47 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 instance-setup: INFO /proc/irq/32/smp_affinity_list: real affinity 3
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 instance-setup: INFO Queue 0 XPS=1 for /sys/class/net/eth0/queues/tx-0/xps_cpus
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 instance-setup: INFO Queue 1 XPS=2 for /sys/class/net/eth0/queues/tx-1/xps_cpus
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 instance-setup: INFO Queue 2 XPS=4 for /sys/class/net/eth0/queues/tx-2/xps_cpus
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 instance-setup: INFO Queue 3 XPS=8 for /sys/class/net/eth0/queues/tx-3/xps_cpus
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 google-clock-skew: INFO Starting Google Clock Skew daemon.
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 google-ip-forwarding: INFO Starting Google IP Forwarding daemon.
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 google-clock-skew: INFO Clock drift token has changed: 0.
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [   10.907213] random: nonblocking pool is initialized
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 google-clock-skew: INFO Synced system time with hardware clock.
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 google-accounts: INFO Starting Google Accounts daemon.
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 google-accounts: INFO Creating a new user account for me.
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 google-accounts: INFO Created user account me.
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 google-accounts: INFO Creating a new user account for bogdana.
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 google-accounts: INFO Created user account bogdana.
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 google-accounts: INFO Creating a new user account for aj.
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 google-accounts: INFO Created user account aj.
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 google-accounts: INFO Creating a new user account for asari.
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 google-accounts: INFO Created user account asari.
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 google-accounts: INFO Removing user packer.
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 pollinate: system was previously seeded at [2017-12-05 19:31:29.715998981 +0000]
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 pollinate: To re-seed this system again, use the -r|--reseed option
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 cron[1433]: (CRON) INFO (pidfile fd = 3)
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 cron[1477]: (CRON) STARTUP (fork ok)
Aug 14 13:54:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 cron[1477]: (CRON) INFO (Runnin65:34:6e:7e:c0:64  root@travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 (ECDSA)
Aug 14 13:55:18 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 ec2: 256 5f:31:5b:64:bd:70:4e:3b:be:58:29:17:ec:67:57:d7  root@travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 (ED25519)
Aug 14 13:55:18 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 ec2: 2048 79:eb:80:39:30:36:97:04:4b:b1:25:ab:3c:a9:6d:6d  root@travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 (RSA)
Aug 14 13:55:18 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 ec2: -----END SSH HOST KEY FINGERPRINTS-----
Aug 14 13:55:18 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 ec2: #############################################################
Aug 14 13:55:48 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [   71.633992] IPv6: ADDRCONF(NETDEV_UP): docker0: link is not ready
Aug 14 13:56:51 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [  133.904508] device vethcd2df84 entered promiscuous mode
Aug 14 13:56:51 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [  133.904597] docker0: port 1(vethcd2df84) entered forwarding state
Aug 14 13:56:51 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [  133.904606] docker0: port 1(vethcd2df84) entered forwarding state
Aug 14 13:56:51 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [  133.906026] docker0: port 1(vethcd2df84) entered disabled state
Aug 14 13:56:51 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [  133.991952] cgroup: docker-runc (4754) created nested cgroup for controller "memory" which has incomplete hierarchy support. Nested cgroups may change behavior in the future.
Aug 14 13:56:51 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [  133.991955] cgroup: "memory" requires setting use_hierarchy to 1 on the root
Aug 14 13:56:51 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [  134.059520] eth0: renamed from veth6fa229e
Aug 14 13:56:51 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [  134.093639] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
Aug 14 13:56:51 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [  134.094579] docker0: port 1(vethcd2df84) entered forwarding state
Aug 14 13:56:51 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [  134.094596] docker0: port 1(vethcd2df84) entered forwarding state
Aug 14 13:56:51 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [  134.094612] IPv6: ADDRCONF(NETDEV_CHANGE): docker0: link becomes ready
Aug 14 13:56:54 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 ntpd[1777]: Listen normally on 5 docker0 fe80::42:7cff:fed9:eba8 UDP 123
Aug 14 13:56:54 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 ntpd[1777]: Listen normally on 6 docker0 fe80::1 UDP 123
Aug 14 13:56:54 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 ntpd[1777]: Listen normally on 7 docker0 fd9a:8454:6789:13f7::1 UDP 123
Aug 14 13:56:54 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 ntpd[1777]: peers refreshed
Aug 14 13:56:54 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 ntpd[1777]: new interface(s) found: waking up resolver
Aug 14 13:57:06 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [  149.147440] docker0: port 1(vethcd2df84) entered forwarding state
Aug 14 14:17:01 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 CRON[13765]: (root) CMD (   cd / && run-parts --report /etc/cron.hourly)
Aug 14 14:18:54 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [ 1457.360223] veth6fa229e: renamed from eth0
Aug 14 14:18:54 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [ 1457.400100] docker0: port 1(vethcd2df84) entered disabled state
Aug 14 14:18:54 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [ 1457.424916] docker0: port 1(vethcd2df84) entered disabled state
Aug 14 14:18:54 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [ 1457.426538] device vethcd2df84 left promiscuous mode
Aug 14 14:18:54 travis-job-b9cd9985-fd98-478b-bf4b-6a6fd5e603d3 kernel: [ 1457.426541] docker0: port 1(vethcd2df84) entered disabled state
travis_fold:end:after_failure.1
travis_fold:start:after_failure.2
travis_time:start:03fa2582

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)
@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member Author

eddyb commented Aug 14, 2018

cc @nikomatsakis If we go down this path, chalk at least needs to be updated.
AFAIK crate::... without a leading :: should work before this PR too.
@petrochenkov

This comment has been minimized.

Sign in to view
Copy link
Contributor

petrochenkov commented Aug 14, 2018

Implementation looks good to me, but I'd like to wait for other people's opinions.

I've seen an argument that ::crate may be useful in scenarios like

macro m($crate_name: ident) {
   ::$crate_name::something();
}

m!(my_crate); // OK
m!(crate); // OK
@joshtriplett

This comment has been minimized.

Sign in to view
Copy link
Member

joshtriplett commented Aug 14, 2018 •
edited

@petrochenkov Doesn't seem that hard to write m!(::my_crate) or m!(crate), in that case.

I don't have any fundamental objection to ::crate::foo working, but since crate:: is already unambiguous, it seems preferable to have one way to write it rather than two.
@petrochenkov

This comment has been minimized.

Sign in to view
Copy link
Contributor

petrochenkov commented Aug 14, 2018

@joshtriplett

Doesn't seem that hard to write m!(::my_crate) or m!(crate), in that case.

Yes, this should be possible when #48067 is implemented (paths cannot be easily concatenated in macros right now).

Anyway, prohibiting ::crate is more conservative variant so we can do it now and re-allow again if it becomes necessary.

varkor added a commit to varkor/chalk that referenced this pull request Aug 14, 2018

@varkor
Replace `::crate` with `crate` 
Fixes dependency issue in rust-lang/rust#53347.
eeb705b

@varkor varkor referenced this pull request Aug 14, 2018

Merged

Replace `::crate` with `crate` #170

@eddyb eddyb force-pushed the eddyb:no-crate-in-root branch from fd8ab07 to 2c4a2fc Aug 14, 2018

@rust-highfive

This comment was marked as resolved.

Sign in to view
Copy link
Collaborator

rust-highfive commented Aug 14, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:20:47]    Compiling smallvec v0.6.3
[00:20:47]    Compiling crossbeam-epoch v0.3.1
[00:20:49]    Compiling polonius-engine v0.5.0
[00:20:49]    Compiling chalk-engine v0.6.0
[00:20:49] error[E0433]: failed to resolve. global paths cannot start with `crate`
[00:20:49]     --> /cargo/registry/src/github.com-1ecc6299db9ec823/chalk-engine-0.6.0/src/logic.rs:1169:11
[00:20:49]      |
[00:20:49] 1169 |         ::crate::maybe_grow_stack(|| self.pursue_strand(depth, strand))
[00:20:49]      |           ^^^^^ global paths cannot start with `crate`
[00:20:49]    Compiling tempfile v3.0.2
[00:20:50]    Compiling rls-span v0.4.0
[00:20:51]    Compiling rustc_apfloat v0.0.0 (file:///checkout/src/librustc_apfloat)
[00:20:51]    Compiling env_logger v0.5.10
[00:20:51]    Compiling env_logger v0.5.10
[00:20:53] error: aborting due to previous error
[00:20:53] 
[00:20:53] For more information about this error, try `rustc --explain E0433`.
[00:20:53] error: Could not compile `chalk-engine`.
[00:20:53] 
[00:20:53] Caused by:
[00:20:53]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name chalk_engine /cargo/registry/src/github.com-1ecc6299db9ec823/chalk-engine-0.6.0/src/lib.rs --color always --error-format json --crate-type lib --emit=dep-info,link -C opt-level=2 -C metadata=30c883ec86c7b095 -C extra-filename=-30c883ec86c7b095 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/deps --extern chalk_macros=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps/libchalk_macros-1ec71b9a040fef8a.rlib --extern rustc_hash=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_hash-9bd093322605ad94.rlib --cap-lints allow` (exit code: 1)
[00:20:53] warning: build failed, waiting for other jobs to finish...
-40c5-971b-010c1cb893a7 kernel: [    0.000000] ACPI: FACS 0x00000000BFFFCF00 000040
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000] ACPI: SSDT 0x00000000BFFF65F0 00690D (v01 Google GOOGSSDT 00000001 GOOG 00000001)
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000] ACPI: APIC 0x00000000BFFF5D10 000086 (v01 Google GOOGAPIC 00000001 GOOG 00000001)
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000] ACPI: WAET 0x00000000BFFF5CE0 000028 (v01 Google GOOGWAET 00000001 GOOG 00000001)
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000] ACPI: SRAT 0x00000000BFFF4C30 0000E8 (v01 Google GOOGSRAT 00000001 GOOG 00000001)
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000] ACPI: Local APIC address 0xfee00000
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000] SRAT: PXM 0 -> APIC 0x00 -> Node 0
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000] SRAT: PXM 0 -> APIC 0x01 -> Node 0
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000] SRAT: PXM 0 -> APIC 0x02 -> Node 0
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000] SRAT: PXM 0 -> APIC 0x03 -> Node 0
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000] SRAT: Node 0 PXM 0 [mem 0x00000000-0x0009ffff]
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000] SRAT: Node 0 PXM 0 [mem 0x00100000-0xbfffffff]
Au224 pages used for memmap
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000]   DMA32 zone: 782323 pages, LIFO batch:31
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000]   Normal zone: 49152 pages used for memmap
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000]   Normal zone: 3145728 pages, LIFO batch:31
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000] ACPI: PM-Timer IO Port: 0xb008
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000] ACPI: Local APIC address 0xfee00000
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000] ACPI: LAPIC_NMI (acpi_id[0xff] dfl dfl lint[0x1])
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000] IOAPIC[0]: apic_id 0, version 17, address 0xfec00000, GSI 0-23
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000] ACPI: INT_SRC_OVR (bus 0 bus_irq 5 global_irq 5 high level)
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000] ACPI: INT_SRC_OVR (bus 0 bus_irq 9 global_irq 9 high level)
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000] ACPI: INT_SRC_OVR (bus 0 bus_irq 10 global_irq 10 high level)
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000] ACPI: INT_SRC_OVR (bus 0 bus_irq 11 global_irq 11 high level)
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.000000] ACPI: IRQ5 used bys: 32768 (order: 6, 262144 bytes)
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.467416] Mountpoint-cache hash table entries: 32768 (order: 6, 262144 bytes)
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.469817] Initializing cgroup subsys io
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.470984] Initializing cgroup subsys memory
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.472452] Initializing cgroup subsys devices
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.474071] Initializing cgroup subsys freezer
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.475717] Initializing cgroup subsys net_cls
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.476941] Initializing cgroup subsys perf_event
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.478314] Initializing cgroup subsys net_prio
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.479787] Initializing cgroup subsys hugetlb
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.481491] Initializing cgroup subsys pids
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.483427] CPU: Physical Processor ID: 0
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.484583] CPU: Processor Core ID: 0
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.487042] mce: CPU supports 32 MCE banks
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.488383] Last level iTLB entries: 4KB 512, 2MB 8, 4MB 8
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.490220] Last level dTLB entries: 4KB 512, 2MB 0, 4MB 0, 1GB 4
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.494649] Freeing SMP alternatives memory: 32K
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.506233] ftrace: allocating 32185 entries in 126 pages
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.565317] smpboot: APIC(0) Converting physical 0 to logical package 0
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.568075] smpboot: Max logical packages: 2
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.570019] x2apic enabled
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.572465] Switched APIC routing to physical x2apic.
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.577517] ..TIMER: vector=0x30 apic1=0 pin1=0 apic2=-1 pin2=-1
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.686438] smpboot: CPU0: Intel(R) Xeon(R) CPU @ 2.50GHz (family: 0x6, model: 0x3e, stepping: 0x4)
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.689496] Performance Events: unsupported p6 CPU model 62 no PMU driver, software events only.
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.694195] x86: Booting SMP configuration:
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.695461] .... node  #0, CPUs:      #1
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.697030] kvm-clock: cpu 1, msr 3:ffff1041, secondary cpu clock
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.703052]  #2
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.703848] kvm-clock: cpu 2, msr 3:ffff1081, secondary cpu clock
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.709602]  #3
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.710766] kvm-clock: cpu 3, msr 3:ffff10c1, secondary cpu clock
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.716289] x86: Booted up 1 node, 4 CPUs
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.717515] smpboot: Total of 4 processors activated (20000.00 BogoMIPS)
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.721522] devtmpfs: initialized
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.726909] evm: security.selinux
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.727926] evm: security.SMACK64
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.729061] evm: security.SMACK64EXEC
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.730060] evm: security.SMACK64TRANSMUTE
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.731286] evm: security.SMACK64MMAP
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.732787] evm: security.ima
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.733848] evm: security.capability
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.735396] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.738408] futex hash table entries: 1024 (order: 4, 65536 bytes)
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.741440] pinctrl core: initialized pinctrl subsystem
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.743285] RTC time: 21:42:08, date: 08/14/18
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.745960] NET: Registered protocol family 16
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.758482] cpuidle: using governor ladder
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.770488] cpuidle: using governor menu
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.771802] PCCT header not found.
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.772980] ACPI: bus type PCI registered
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.774314] acpiphp: ACPI Hot Plug PCI Controller Driver version: 0.5
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    0.776752] PCI: Using configuration ty66341] hw unit of domain package 2^-0 Joules
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.267828] hw unit of domain dram 2^-0 Joules
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.269336] Scanning for low memory corruption every 60 seconds
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.271966] audit: initializing netlink subsys (disabled)
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.273722] audit: type=2000 audit(1534282930.300:1): initialized
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.276022] Initialise system trusted keyring
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.277829] HugeTLB registered 1 GB page size, pre-allocated 0 pages
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.280056] HugeTLB registered 2 MB page size, pre-allocated 0 pages
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.283203] zbud: loaded
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.284504] VFS: Disk quotas dquot_6.6.0
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.286104] VFS: Dquot-cache hash table entries: 512 (order 0, 4096 bytes)
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.288796] squashfs: version 4.0 (2009/01/31) Phillip Lougher
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.291095] fuse init (API version 7.23)
Aug 14 21:42:17 travis-job-f099cb893a7 kernel: [    3.439701] 00:06: ttyS3 at I/O 0x2e8 (irq = 7, base_baud = 115200) is a 16550A
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.443890] Linux agpgart interface v0.103
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.448013] loop: module loaded
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.449171] libphy: Fixed MDIO Bus: probed
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.450539] tun: Universal TUN/TAP device driver, 1.6
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.452246] tun: (C) 1999-2004 Max Krasnyansky <maxk@qualcomm.com>
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.492506] PPP generic driver version 2.4.2
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.493996] ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.495936] ehci-pci: EHCI PCI platform driver
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.497345] ehci-platform: EHCI generic platform driver
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.498888] ohci_hcd: USB 1.1 'Open' Host Controller (OHCI) Driver
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.500795] ohci-pci: OHCI PCI platform driver
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.502116] ohci-platform: OHCI generic platform driver
Aug 14 21:42:745-40c5-971b-010c1cb893a7 kernel: [    3.579496] Freeing unused kernel memory: 1496K
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.580929] Write protecting the kernel read-only data: 14336k
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.583512] Freeing unused kernel memory: 1956K
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.585360] Freeing unused kernel memory: 92K
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.600634] systemd-udevd[119]: starting version 204
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.664419] scsi host0: Virtio SCSI HBA
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.670634] scsi 0:0:1:0: Direct-Access     Google   PersistentDisk   1    PQ: 0 ANSI: 6
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.676865] AVX version of gcm_enc/dec engaged.
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.678351] AES CTR mode by8 optimization enabled
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.713205] sd 0:0:1:0: Attached scsi generic sg0 type 0
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.713245] sd 0:0:1:0: [sda] 62914560 512-byte logical blocks: (32.2 GB/30.0 GiB)
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.713249] sd 0:0:1:0: [sda] 4096-byte physical blocks
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.713416] sd 0:0:1:0: [sda] Write Protect is off
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.713418] sd 0:0:1:0: [sda] Mode Sense: 1f 00 00 08
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.713460] sd 0:0:1:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.714668]  sda: sda1
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.715268] sd 0:0:1:0: [sda] Attached SCSI disk
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    3.719109] input: AT Translated Set 2 keyboard as /devices/platform/i8042/serio0/input/input2
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    4.266630] tsc: Refined TSC clocksource calibration: 2499.777 MHz
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    4.268816] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x24086721a4d, max_idle_ns: 440795248663 ns
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    4.552629] input: ImExPS/2 Generic Explorer Mouse as /devices/platform/i8042/serio1/input/input4
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    6.654675] floppy0: no floppy controllers found
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    7.830497] raid6: sse2x1   gen()  9170 MB/s
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [    7.898493] raid6: sse2x1   xor()  7033 MB/s
Aug 14 21:42:17 travis-job-f099f521-a745-40c5-971b-ing daemon.
Aug 14 21:42:18 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-clock-skew: INFO Clock drift token has changed: 0.
Aug 14 21:42:18 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Starting Google Accounts daemon.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-clock-skew: INFO Synced system time with hardware clock.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Creating a new user account for me.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Created user account me.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Creating a new user account for henrik.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Created user account henrik.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Creating a new user account for emma.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 pollinate: system was previously seeded at [2017-12-05 19:31:29.715998981 +0000]
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 pollinate: To re-seed this system again, use the -r|--reseed option
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 cron[1410]: (CRON) INFO (pidfile fd = 3)
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 cron[1455]: (CRON) STARTUP (fork ok)
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Created user account emma.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 cron[1455]: (CRON) INFO (Running @reboot jobs)
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Creating a new user account for igor.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 acpid: starting up with netlink and the input layer
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 acpid: 1 rule loaded
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 acpid: waiting for events: event logging is off
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Created user account igor.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Creating a new user account for konstantinhaase.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 haveged: haveged starting up
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 pollinate: system was previously seeded at [2017-12-05 19:31:29.715998981 +0000]
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 pollinate: To re-seed this system again, use the -r|--reseed option
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Created user account konstantinhaase.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Creating a new user account for aj.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [   11.952309] ip_tables: (C) 2000-2006 Netfilter Core Team
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Created user account aj.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [   11.962073] ip6_tables: (C) 2000-2006 Netfilter Core Team
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Creating a new user account for solarce.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Created user account solarce.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Creating a new user account for asari.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Created user account asari.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Creating a new user account for bogdana.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Created user account bogdana.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Creating a new user account for konstantin.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Created user account konstantin.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 google-accounts: INFO Creating a new user account for carmen.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [   12.173070] bridge: automatic filtering via arp/ip/ip6tables has been deprecated. Update your scripts to load br_netfilter if you need this.
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [   12.177670] Bridge firewalling registered
Aug 14 21:42:19 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [   12.190021] nf_conntrack version 0.5.0 (65536 bu83]: new interface(s) found: waking up resolver
Aug 14 21:44:41 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [  154.514135] docker0: port 1(vethf7171ab) entered forwarding state
Aug 14 22:04:25 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [ 1338.571309] vethc51a41d: renamed from eth0
Aug 14 22:04:25 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [ 1338.584354] docker0: port 1(vethf7171ab) entered disabled state
Aug 14 22:04:26 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [ 1338.633294] docker0: port 1(vethf7171ab) entered disabled state
Aug 14 22:04:26 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [ 1338.635127] device vethf7171ab left promiscuous mode
Aug 14 22:04:26 travis-job-f099f521-a745-40c5-971b-010c1cb893a7 kernel: [ 1338.635130] docker0: port 1(vethf7171ab) entered disabled state
travis_fold:end:after_failure.1
travis_fold:start:after_failure.2
travis_time:start:2e6f07fa

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)
@petrochenkov

This comment has been minimized.

Sign in to view
Copy link
Contributor

petrochenkov commented Aug 15, 2018

Do we have a label "ping @rust-lang/lang, wait for a few days and then r+ even if nobody responded"?

@petrochenkov petrochenkov added S-waiting-on-team and removed S-waiting-on-review labels Aug 15, 2018

@eddyb eddyb added I-nominated T-lang labels Aug 15, 2018

@cramertj

This comment has been minimized.

Sign in to view
Copy link
Member

cramertj commented Aug 15, 2018

We discussed this in a previous meeting and I got the impression that there was consensus around ::<cratename>::.. being the one and only way to use leading-:: in a path.
@Centril

This comment has been minimized.

Sign in to view
Copy link
Contributor

Centril commented Aug 15, 2018

I second @cramertj. ::crate should not be permitted; or at the very least I'd want to be conservative here.
@joshtriplett

This comment has been minimized.

Sign in to view
Copy link
Member

joshtriplett commented Aug 15, 2018

This still needs its build failures fixed (s/::crate::/crate::/g everywhere), but as soon as that happens, let's merge this.

@joshtriplett joshtriplett added S-waiting-on-author and removed S-waiting-on-team labels Aug 16, 2018

@eddyb eddyb removed the I-nominated label Aug 16, 2018

@eddyb eddyb force-pushed the eddyb:no-crate-in-root branch from 2c4a2fc to 9347bf7 Aug 16, 2018

@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member Author

eddyb commented Aug 16, 2018

@bors r=petrochenkov
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Aug 16, 2018

📌 Commit 9347bf7 has been approved by petrochenkov

@bors bors added S-waiting-on-bors and removed S-waiting-on-author labels Aug 16, 2018

@rust-highfive

This comment was marked as resolved.

Sign in to view
Copy link
Collaborator

rust-highfive commented Aug 17, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:47:26] ....................................................................................................
[00:47:29] ....................................................................................................
[00:47:32] ....................................................................................................
[00:47:35] ....................................................................................................
[00:47:39] ..i.....................FF..........................................................................
[00:47:45] ....................................................................................................
[00:47:48] ................................i...................................................................
[00:47:52] ....................................................................................................
[00:47:58] .............................................................................i......................
[00:47:58] .............................................................................i......................
on about this error, try `rustc --explain E0433`.
[00:47:59] 10 
[00:47:59] 
[00:47:59] 
[00:47:59] The actual stderr differed from the expected stderr.
[00:47:59] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2126-crate-paths/crate-path-non-absolute/crate-path-non-absolute.stderr
[00:47:59] To update references, rerun the tests and pass the `--bless` flag
[00:47:59] To only update this specific test, also pass `--test-args rfc-2126-crate-paths/crate-path-non-absolute.rs`
[00:47:59] error: 1 errors occurred comparing output.
[00:47:59] status: exit code: 1
[00:47:59] status: exit code: 1
[00:47:59] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/rfc-2126-crate-paths/crate-path-non-absolute.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2126-crate-paths/crate-path-non-absolute/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2126-crate-paths/crate-path-non-absolute/auxiliary" "-A" "unused"
[00:47:59] ------------------------------------------
[00:47:59] 
[00:47:59] ------------------------------------------
[00:47:59] stderr:
[00:47:59] stderr:
[00:47:59] ------------------------------------------
[00:47:59] {"message":"failed to resolve. `crate` in paths can only be used in start position","code":{"code":"E0433","explanation":"\nAn undeclared type or module was used.\n\nErroneous code example:\n\n```collections::HashMap; // HashMap has been imported.\nlet map: HashMap<u32, u32> = HashMap::new(); // So it can be used!\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/rfc-2126-crate-paths/crate-path-non-absolute.rs","byte_start":610,"byte_end":615,"line_start":18,"line_end":18,"column_start":20,"column_end":25,"is_primary":true,"text":[{"text":"        let s1 = ::crate::S; //~ ERROR failed to resolve","highlight_start":20,"highlight_end":25}],"label":"global paths cannot start with `crate`","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0433]: failed to resolve. global paths cannot start with `crate`\n  --> /checkout/src/test/ui/rfc-2126-crate-paths/crate-path-non-absolute.rs:18:20\n   |\nLL |         let s1 = ::crate::S; //~ ERROR failed to resolve\n   |                    ^^^^^ global paths cannot start with `crate`\n\n"}
[00:47:59] {"message":"aborting due to 2 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 2 previous errors\n\n"}
[00:47:59] {"message":"For more information about this error, try `rustc --explain E0433`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0433`.\n"}
[00:47:59] ------------------------------------------
[00:47:59] 
[00:47:59] thread '[ui] ui/rfc-2126-crate-paths/crate-path-non-absolute.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3166:9
[00:47:59] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:47:59] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:47:59] 
[00:47:59] ---- [ui] ui/rfc-2126-crate-paths/keyword-crate-as-identifier.rs stdout ----
[00:47:59] diff of stderr:
[00:47:59] 
[00:47:59] - error[E0433]: failed to resolve. `crate` in paths can only be used in start position
[00:47:59] + error[E0532]: expected unit struct/variant or constant, found module `crate`
[00:47:59] 2   --> $DIR/keyword-crate-as-identifier.rs:14:9
[00:47:59] 3    |
[00:47:59] - LL |     let crate = 0; //~ ERROR failed to resolve. `crate` in paths can only be used in start position
[00:47:59] -    |         ^^^^^ `crate` in paths can only be used in start position
[00:47:59] + LL |     let crate = 0;
[00:47:59] 6 
[00:47:59] 7 error: aborting due to previous error
[00:47:59] 8 
[00:47:59] 
[00:47:59] 
[00:47:59] - For more information about this error, try `rustc --explain E0433`.
[00:47:59] + For more information about this error, try `rustc --explain E0532`.
[00:47:59] 10 
[00:47:59] 
[00:47:59] 
[00:47:59] The actual stderr differed from the expected stderr.
[00:47:59] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2126-crate-paths/keyword-crate-as-identifier/keyword-crate-as-identifier.stderr
[00:47:59] To update references, rerun the tests and pass the `--bless` flag
[00:47:59] To only update this specific test, also pass `--test-args rfc-2126-crate-paths/keyword-crate-as-identifier.rs`
[00:47:59] error: 1 errors occurred comparing output.
[00:47:59] status: exit code: 1
[00:47:59] status: exit code: 1
[00:47:59] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/rfc-2126-crate-paths/keyword-crate-as-identifier.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2126-crate-paths/keyword-crate-as-identifier/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2126-crate-paths/keyword-crate-as-identifier/auxiliary" "-A" "unused"
[00:47:59] ------------------------------------------
[00:47:59] 
[00:47:59] ------------------------------------------
[00:47:59] stderr:
[00:47:59] stderr:
[00:47:59] ------------------------------------------
[00:47:59] {"message":"expected unit struct/variant or constant, found module `crate`","code":{"code":"E0532","explanation":"\nPattern arm did not match expected kind.\n\nErroneous code example:\n\n```compile_fail,E0532\nenum State {\n    Succeeded,\n    Failed(String),\n}\n\nfn print_on_failure(state: &State) {\n    match *state {\n        // error: expected unit struct/variant or constant, found tuple\n        //        variant `State::Failed`\n        State::Failed => println!(\"Failed\"),\n        _ => ()\n    }\n}\n```\n\nTo fix this error, ensure the match arm kind is the same as the expression\nmatched.\n\nFixed example:\n\n```\nenum State {\n    Succeeded,\n    Failed(String),\n}\n\nfn print_on_failure(state: &State) {\n    match *state {\n        State::Failed(ref msg) => println!(\"Failed with {}\", msg),\n        _ => ()\n    }\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/rfc-2126-crate-paths/keyword-crate-as-identifier.rs","byte_start":516,"byte_end":521,"line_start":14,"line_end":14,"column_start":9,"column_end":14,"is_primary":true,"text":[{"text":"    let crate = 0;","highlight_start":9,"highlight_end":14}],"label":"not a unit struct/variant or constant","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0532]: expected unit struct/variant or constant, found module `crate`\n  --> /checkout/src/test/ui/rfc-2126-crate-paths/keyword-crate-as-identifier.rs:14:9\n   |\nLL |     let crate = 0;\n   |         ^^^^^ not a unit struct/variant or constant\n\n"}
[00:47:59] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[00:47:59] {"message":"For more information about this error, try `rustc --explain E0532`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0532`.\n"}
[00:47:59] ------------------------------------------
[00:47:59] 
[00:47:59] thread '[ui] ui/rfc-2126-crate-paths/keyword-crate-as-identifier.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3166:9
[00:47:59]

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@eddyb eddyb force-pushed the eddyb:no-crate-in-root branch from 9347bf7 to be90514 Aug 17, 2018

@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member Author

eddyb commented Aug 17, 2018

@bors r=petrochenkov
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Aug 17, 2018

📌 Commit be90514 has been approved by petrochenkov
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Aug 17, 2018

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

  1. git checkout no-crate-in-root (switch to your branch)
  2. git fetch upstream master (retrieve the latest master)
  3. git rebase upstream/master -p (rebase on top of it)
  4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
  5. git push self no-crate-in-root --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message 
warning: Cannot merge binary files: src/Cargo.lock (HEAD vs. heads/homu-tmp)
Auto-merging src/Cargo.lock
CONFLICT (content): Merge conflict in src/Cargo.lock
Automatic merge failed; fix conflicts and then commit the result.

@bors bors added S-waiting-on-author and removed S-waiting-on-bors labels Aug 17, 2018

@eddyb eddyb force-pushed the eddyb:no-crate-in-root branch from be90514 to 9b1d3c7 Aug 17, 2018

@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member Author

eddyb commented Aug 17, 2018

@bors r=petrochenkov
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Aug 17, 2018

📌 Commit 9b1d3c7 has been approved by petrochenkov

@bors bors added S-waiting-on-bors and removed S-waiting-on-author labels Aug 17, 2018

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Aug 17, 2018

@frewsxcv
Rollup merge of rust-lang#53347 - eddyb:no-crate-in-root, r=petrochenkov 
rustc_resolve: don't allow paths starting with `::crate`.

cc @aturon @joshtriplett
r? @petrochenkov
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
3de02d3

@frewsxcv frewsxcv referenced this pull request Aug 17, 2018

Merged

Rollup of 11 pull requests #53449

bors added a commit that referenced this pull request Aug 17, 2018

@bors
Auto merge of #53449 - frewsxcv:rollup, r=frewsxcv 
Rollup of 11 pull requests

Successful merges:

 - #52858 (Implement Iterator::size_hint for Elaborator.)
 - #53321 (Fix usage of `wasm_target_feature`)
 - #53326 ([nll] add regression test for issue #27868)
 - #53347 (rustc_resolve: don't allow paths starting with `::crate`.)
 - #53349 ([nll] add tests for #48697 and #30104)
 - #53357 (Pretty print btreemap for GDB)
 - #53358 (`{to,from}_{ne,le,be}_bytes` for unsigned integer types)
 - #53406 (Do not suggest conversion method that is already there)
 - #53407 (make more ported compile fail tests more robust w.r.t. NLL)
 - #53413 (Warn that `#![feature(rust_2018_preview)]` is implied when the edition is set to Rust 2018.)
 - #53434 (wasm: Remove --strip-debug argument to LLD)

Failed merges:

r? @ghost
Loading status checks…
de21ea8

@bors bors merged commit 9b1d3c7 into rust-lang:master Aug 17, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eddyb eddyb deleted the eddyb:no-crate-in-root branch Aug 17, 2018

@rpjohnst

This comment has been minimized.

Sign in to view
Copy link
Contributor

rpjohnst commented Aug 17, 2018

Being conservative here is fine, especially now that :: has become far less necessary, but it seems more consistent to me to allow ::crate because crate plays the same role as crate_name.
@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member Author

eddyb commented Aug 18, 2018

@rpjohnst The current interpretation isn't that, but rather that crate is a keyword just like self and super, that only appears at the start of a path, and changes it from the default mode (whichever it may be, Rust 2015 vs Rust 2015, with and without uniform_paths) to the root of the local crate.
@rpjohnst

This comment has been minimized.

Sign in to view
Copy link
Contributor

rpjohnst commented Aug 18, 2018

I get that interpretation, but the ::crate/"crate is a crate name" mental model is a great way to explain the new system, and it would be a shame to lose it.
@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member Author

eddyb commented Aug 18, 2018

@rpjohnst Note that we can't make that work in Rust 2015, because there is no place (in the "module tree", so to speak) where you can just "access crates by their name".

In Rust 2018 that's the topmost path level, but in Rust 2015 it doesn't exist, and if we allow crate to resolve in the crate root (which is what ::crate means in Rust 2015), then self::crate, super::crate, etc. should resolve too, if the prefix of the path reaches the crate root, to remain consistent (unless we special-case it further).
@rpjohnst

This comment has been minimized.

Sign in to view
Copy link
Contributor

rpjohnst commented Aug 18, 2018 •
edited

Yeah, 2015 does make it messier. But perhaps allowing crate to resolve in the crate root makes sense there? That's where all the extern crate declarations go anyway, and crate really only needs to make sense in 2015 insofar as it's part of the transition path to 2018. :P

We could also allow ::crate only in 2018, by allowing it to resolve in the 2018 root, if that feels less messy. Or maybe it makes it worse via interaction with the new prelude-like mechanism, I'm not sure how that works.

Regardless, :: plays a smaller role in 2018, and that role doesn't intersect with crate, so maybe it doesn't matter to the mental model.

@petrochenkov petrochenkov referenced this pull request Oct 28, 2018

Closed

Crates can't migrate to 2018 edition when they invoke coupled procedural macros #54647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.