Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uprustc_resolve: overhaul `#![feature(uniform_paths)]` error reporting. #53427
Conversation
rust-highfive
assigned
petrochenkov
Aug 16, 2018
rust-highfive
added
the
S-waiting-on-review
label
Aug 16, 2018
This comment has been minimized.
This comment has been minimized.
|
@bors p=10 (somewhat blocking Edition Preview 2 testing) |
This was referenced Aug 16, 2018
This comment was marked as resolved.
This comment was marked as resolved.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
eddyb
force-pushed the
eddyb:uniform-paths-diagnostics
branch
from
c81b481
to
a5bb0c6
Aug 16, 2018
This comment was marked as resolved.
This comment was marked as resolved.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
eddyb
force-pushed the
eddyb:uniform-paths-diagnostics
branch
from
a5bb0c6
to
bcf864d
Aug 16, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-bors
and removed
S-waiting-on-review
labels
Aug 16, 2018
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Aug 16, 2018
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-review
and removed
S-waiting-on-bors
labels
Aug 16, 2018
This comment was marked as off-topic.
This comment was marked as off-topic.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment has been minimized.
This comment has been minimized.
|
@bors retry |
bors
added
S-waiting-on-bors
and removed
S-waiting-on-review
labels
Aug 16, 2018
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Aug 16, 2018
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-review
and removed
S-waiting-on-bors
labels
Aug 16, 2018
eddyb
force-pushed the
eddyb:uniform-paths-diagnostics
branch
from
bcf864d
to
7a87e30
Aug 16, 2018
This comment has been minimized.
This comment has been minimized.
|
@bors r=varkor (sadly I don't think this will make the nightly, oops) |
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-bors
and removed
S-waiting-on-review
labels
Aug 16, 2018
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Aug 17, 2018
This comment has been minimized.
This comment has been minimized.
|
|
bors
merged commit 7a87e30
into
rust-lang:master
Aug 17, 2018
eddyb
deleted the
eddyb:uniform-paths-diagnostics
branch
Aug 17, 2018
joshtriplett
reviewed
Aug 18, 2018
| | refers to external crate `::std` | ||
| | defines `self::std`, shadowing itself | ||
| | | ||
| = help: remove or write `::std` explicitly instead |
This comment has been minimized.
This comment has been minimized.
joshtriplett
Aug 18, 2018
•
Member
Wouldn't use ::somecrate; be redundant as well, because extern_prelude makes somecrate already available?
This comment has been minimized.
This comment has been minimized.
eddyb
Aug 18, 2018
Author
Member
It's redundant for direct uses of the imported name but maybe you actually want use ::std as _; or something.
eddyb commentedAug 16, 2018
•
edited
Fixes #53408 by only considering external crates to conflict within their (type/module) namespace, not with the value or macro namespaces, and also by adding a special-cased error for redundant
use crate_name;imports (without actually allowing them).Also, all canaries for a given import are grouped into one diagnostic per namespace, in order to make block-scoped ambiguities clearer.
See changed/added tests for more details.
r? @petrochenkov cc @aturon @joshtriplett