New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize a few secondary macro features #53459

Merged
merged 1 commit into from Aug 23, 2018

Conversation

Projects
None yet
9 participants
@petrochenkov
Copy link
Contributor

petrochenkov commented Aug 17, 2018

  • tool_attributes - closes #44690
  • proc_macro_path_invoc - this feature was created due to issues with tool attributes (#51277), those issues are now fixed (#52841)
  • partially proc_macro_gen - this feature was created due to issue #50504, the issue is now fixed (#51952), so proc macros can generate modules. They still can't generate macro_rules items though due to unclear hygiene interactions.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Aug 17, 2018

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Aug 17, 2018

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Aug 20, 2018

This looks good to me, thanks!

I'll defer to..

r? @nrc

though because I want to make sure the tool_attributes feature is ready to be stabilized.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 21, 2018

☔️ The latest upstream changes (presumably #53236) made this pull request unmergeable. Please resolve the merge conflicts.

@nrc

This comment has been minimized.

Copy link
Member

nrc commented Aug 22, 2018

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 22, 2018

📌 Commit 1638023 has been approved by nrc

@mark-i-m

This comment has been minimized.

Copy link
Contributor

mark-i-m commented Aug 22, 2018

This needs a rebase.

Stabilize a few secondary macro features
`tool_attributes`, `proc_macro_path_invoc`, partially `proc_macro_gen`

@petrochenkov petrochenkov force-pushed the petrochenkov:stabmore branch from 1638023 to b34503e Aug 22, 2018

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Aug 22, 2018

@bors r=nrc

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 22, 2018

📌 Commit b34503e has been approved by nrc

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Aug 22, 2018

Rollup merge of rust-lang#53459 - petrochenkov:stabmore, r=nrc
Stabilize a few secondary macro features

- `tool_attributes` - closes rust-lang#44690
- `proc_macro_path_invoc` - this feature was created due to issues with tool attributes (rust-lang#51277), those issues are now fixed (rust-lang#52841)
- partially `proc_macro_gen` - this feature was created due to issue rust-lang#50504, the issue is now fixed (rust-lang#51952), so proc macros can generate modules. They still can't generate `macro_rules` items though due to unclear hygiene interactions.

bors added a commit that referenced this pull request Aug 23, 2018

Auto merge of #53620 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Rollup of 9 pull requests

Successful merges:

 - #52602 (Implement try block expressions)
 - #53235 (Feature gate where clauses on associated type impls)
 - #53459 (Stabilize a few secondary macro features)
 - #53520 (Merge `IdxSet` and `IdxSetBuf`)
 - #53562 (Lament the invincibility of the Turbofish)
 - #53592 (docs: minor stylistic changes to str/string docs)
 - #53594 (Update RELEASES.md to include clippy-preview)
 - #53600 (Fix a grammatical mistake in "expected generic arguments" errors)
 - #53617 (tidy: Stop requiring a license header)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 23, 2018

⌛️ Testing commit b34503e with merge 9b55e96...

bors added a commit that referenced this pull request Aug 23, 2018

Auto merge of #53459 - petrochenkov:stabmore, r=nrc
Stabilize a few secondary macro features

- `tool_attributes` - closes #44690
- `proc_macro_path_invoc` - this feature was created due to issues with tool attributes (#51277), those issues are now fixed (#52841)
- partially `proc_macro_gen` - this feature was created due to issue #50504, the issue is now fixed (#51952), so proc macros can generate modules. They still can't generate `macro_rules` items though due to unclear hygiene interactions.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 23, 2018

💔 Test failed - status-travis

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Aug 23, 2018

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm

This comment has been minimized.

Copy link
Member

kennytm commented Aug 23, 2018

@bors retry

An error occurred while generating the build script.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 23, 2018

⌛️ Testing commit b34503e with merge 827e57c...

bors added a commit that referenced this pull request Aug 23, 2018

Auto merge of #53459 - petrochenkov:stabmore, r=nrc
Stabilize a few secondary macro features

- `tool_attributes` - closes #44690
- `proc_macro_path_invoc` - this feature was created due to issues with tool attributes (#51277), those issues are now fixed (#52841)
- partially `proc_macro_gen` - this feature was created due to issue #50504, the issue is now fixed (#51952), so proc macros can generate modules. They still can't generate `macro_rules` items though due to unclear hygiene interactions.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 23, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nrc
Pushing 827e57c to master...

@bors bors merged commit b34503e into rust-lang:master Aug 23, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

flip1995 added a commit to rust-lang/rust-clippy that referenced this pull request Aug 23, 2018

@Havvy

This comment has been minimized.

Copy link
Contributor

Havvy commented Aug 29, 2018

Other than that procedural macros can generate modules now (yay!), what else here that's being stabilized and needs to be documented in the reference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment