New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force-inline `shallow_resolve` at its hottest call site. #53513

Merged
merged 1 commit into from Aug 31, 2018

Conversation

Projects
None yet
6 participants
@nnethercote
Contributor

nnethercote commented Aug 20, 2018

It's a ~1% win on keccak and inflate.

Force-inline `shallow_resolve` at its hottest call site.
It's a ~1% win on `keccak` and `inflate`.
@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Aug 20, 2018

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@nnethercote

This comment has been minimized.

Contributor

nnethercote commented Aug 20, 2018

@bors try

@bors

This comment has been minimized.

Contributor

bors commented Aug 20, 2018

⌛️ Trying commit b73843f with merge 55fa515...

bors added a commit that referenced this pull request Aug 20, 2018

Auto merge of #53513 - nnethercote:inline-shallow_resolve, r=<try>
Force-inline `shallow_resolve` at its hottest call site.

It's a ~1% win on `keccak` and `inflate`.
@bors

This comment has been minimized.

Contributor

bors commented Aug 20, 2018

☀️ Test successful - status-travis
State: approved= try=True

@nnethercote

This comment has been minimized.

Contributor

nnethercote commented Aug 20, 2018

@rust-timer

This comment has been minimized.

rust-timer commented Aug 20, 2018

Please provide the full 40 character commit hash.

@nnethercote

This comment has been minimized.

Contributor

nnethercote commented Aug 20, 2018

@rust-timer

This comment has been minimized.

rust-timer commented Aug 20, 2018

Success: Queued 55fa515 with parent f28f648, comparison URL.

@nnethercote

This comment has been minimized.

Contributor

nnethercote commented Aug 20, 2018

From the comparison URL, these are the ones that I am confident are not noise:

keccak-check
        avg: -1.1%      min: -1.6%      max: 0.1%
inflate-check
        avg: -1.1%      min: -1.5%      max: -0.0%
keccak-debug
        avg: -0.8%      min: -1.4%      max: -0.1%
keccak-opt
        avg: -0.8%      min: -1.3%      max: -0.0%
inflate-debug
        avg: -0.9%      min: -1.2%      max: -0.5%
@nnethercote

This comment has been minimized.

Contributor

nnethercote commented Aug 26, 2018

It's been a week and this is a tiny change. Let's try a different reviewer: r? @varkor

@rust-highfive rust-highfive assigned varkor and unassigned pnkfelix Aug 26, 2018

@varkor

This comment has been minimized.

Member

varkor commented Aug 26, 2018

There are some nice gains here, thanks! @bors r+ rollup

@bors

This comment has been minimized.

Contributor

bors commented Aug 26, 2018

📌 Commit b73843f has been approved by varkor

@bors

This comment has been minimized.

Contributor

bors commented Aug 26, 2018

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #53717
@bors

This comment has been minimized.

Contributor

bors commented Aug 26, 2018

📌 Commit b73843f has been approved by varkor

@nnethercote

This comment has been minimized.

Contributor

nnethercote commented Aug 26, 2018

Thank you for the fast review.

kennytm added a commit to kennytm/rust that referenced this pull request Aug 28, 2018

Rollup merge of rust-lang#53513 - nnethercote:inline-shallow_resolve,…
… r=varkor

Force-inline `shallow_resolve` at its hottest call site.

It's a ~1% win on `keccak` and `inflate`.

bors added a commit that referenced this pull request Aug 28, 2018

Auto merge of #53765 - kennytm:rollup, r=kennytm
Rollup of 15 pull requests

Successful merges:

 - #51760 (Add another PartialEq example)
 - #53113 (Add example for Cow)
 - #53129 (remove `let x = baz` which was obscuring the real error)
 - #53389 (document effect of join on memory ordering)
 - #53472 (Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.)
 - #53513 (Force-inline `shallow_resolve` at its hottest call site.)
 - #53622 (cleanup: Add main functions to some UI tests)
 - #53655 (set applicability)
 - #53702 (Fix stabilisation version for macro_vis_matcher.)
 - #53727 (Do not suggest dereferencing in macro)
 - #53732 (save-analysis: Differentiate foreign functions and statics.)
 - #53743 (fix a typo: taget_env -> target_env)
 - #53747 (Rustdoc fixes)
 - #53753 (expand keep-stage --help text)
 - #53758 (Update clippy submodule)

Failed merges:

r? @ghost

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Aug 28, 2018

Rollup merge of rust-lang#53513 - nnethercote:inline-shallow_resolve,…
… r=varkor

Force-inline `shallow_resolve` at its hottest call site.

It's a ~1% win on `keccak` and `inflate`.

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 29, 2018

Rollup merge of rust-lang#53513 - nnethercote:inline-shallow_resolve,…
… r=varkor

Force-inline `shallow_resolve` at its hottest call site.

It's a ~1% win on `keccak` and `inflate`.

bors added a commit that referenced this pull request Aug 29, 2018

Auto merge of #53798 - pietroalbini:rollup, r=pietroalbini
Rollup of 21 pull requests

Successful merges:

 - #51760 (Add another PartialEq example)
 - #53113 (Add example for Cow)
 - #53129 (remove `let x = baz` which was obscuring the real error)
 - #53389 (document effect of join on memory ordering)
 - #53472 (Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.)
 - #53476 (Add partialeq implementation for TryFromIntError type)
 - #53513 (Force-inline `shallow_resolve` at its hottest call site.)
 - #53655 (set applicability)
 - #53685 (Generalize `async_idents` to all new keywords)
 - #53702 (Fix stabilisation version for macro_vis_matcher.)
 - #53725 (Reduce number of syscalls in `rand`)
 - #53727 (Do not suggest dereferencing in macro)
 - #53732 (save-analysis: Differentiate foreign functions and statics.)
 - #53740 (add llvm-readobj to llvm-tools-preview)
 - #53743 (fix a typo: taget_env -> target_env)
 - #53747 (Rustdoc fixes)
 - #53753 (expand keep-stage --help text)
 - #53756 (Fix typo in comment)
 - #53768 (move file-extension based .gitignore down to src/)
 - #53785 (Fix a comment in src/libcore/slice/mod.rs)
 - #53786 (Replace usages of 'bad_style' with 'nonstandard_style'.)

Failed merges:

r? @ghost

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 29, 2018

Rollup merge of rust-lang#53513 - nnethercote:inline-shallow_resolve,…
… r=varkor

Force-inline `shallow_resolve` at its hottest call site.

It's a ~1% win on `keccak` and `inflate`.

bors added a commit that referenced this pull request Aug 29, 2018

Auto merge of #53799 - pietroalbini:rollup, r=pietroalbini
Rollup of 20 pull requests

Successful merges:

 - #51760 (Add another PartialEq example)
 - #53113 (Add example for Cow)
 - #53129 (remove `let x = baz` which was obscuring the real error)
 - #53389 (document effect of join on memory ordering)
 - #53472 (Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.)
 - #53476 (Add partialeq implementation for TryFromIntError type)
 - #53513 (Force-inline `shallow_resolve` at its hottest call site.)
 - #53655 (set applicability)
 - #53685 (Generalize `async_idents` to all new keywords)
 - #53702 (Fix stabilisation version for macro_vis_matcher.)
 - #53727 (Do not suggest dereferencing in macro)
 - #53732 (save-analysis: Differentiate foreign functions and statics.)
 - #53740 (add llvm-readobj to llvm-tools-preview)
 - #53743 (fix a typo: taget_env -> target_env)
 - #53747 (Rustdoc fixes)
 - #53753 (expand keep-stage --help text)
 - #53756 (Fix typo in comment)
 - #53768 (move file-extension based .gitignore down to src/)
 - #53785 (Fix a comment in src/libcore/slice/mod.rs)
 - #53786 (Replace usages of 'bad_style' with 'nonstandard_style'.)

Failed merges:

r? @ghost

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 30, 2018

Rollup merge of rust-lang#53513 - nnethercote:inline-shallow_resolve,…
… r=varkor

Force-inline `shallow_resolve` at its hottest call site.

It's a ~1% win on `keccak` and `inflate`.

bors added a commit that referenced this pull request Aug 31, 2018

Auto merge of #53832 - pietroalbini:rollup, r=pietroalbini
Rollup of 20 pull requests

Successful merges:

 - #51760 (Add another PartialEq example)
 - #53113 (Add example for Cow)
 - #53129 (remove `let x = baz` which was obscuring the real error)
 - #53389 (document effect of join on memory ordering)
 - #53472 (Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.)
 - #53476 (Add partialeq implementation for TryFromIntError type)
 - #53513 (Force-inline `shallow_resolve` at its hottest call site.)
 - #53655 (set applicability)
 - #53702 (Fix stabilisation version for macro_vis_matcher.)
 - #53727 (Do not suggest dereferencing in macro)
 - #53732 (save-analysis: Differentiate foreign functions and statics.)
 - #53740 (add llvm-readobj to llvm-tools-preview)
 - #53743 (fix a typo: taget_env -> target_env)
 - #53747 (Rustdoc fixes)
 - #53753 (expand keep-stage --help text)
 - #53756 (Fix typo in comment)
 - #53768 (move file-extension based .gitignore down to src/)
 - #53785 (Fix a comment in src/libcore/slice/mod.rs)
 - #53786 (Replace usages of 'bad_style' with 'nonstandard_style'.)
 - #53806 (Fix UI issues on Implementations on Foreign types)

Failed merges:

r? @ghost

@bors bors merged commit b73843f into rust-lang:master Aug 31, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@nnethercote nnethercote deleted the nnethercote:inline-shallow_resolve branch Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment