Force-inline shallow_resolve at its hottest call site.
#53513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a ~1% win on `keccak` and `inflate`.
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors try |
|
⌛ Trying commit b73843f with merge 55fa5150e491e8e5ce6936b862f4878fd3126ffc... |
|
☀️ Test successful - status-travis |
|
@rust-timer build 55fa515 |
|
Please provide the full 40 character commit hash. |
|
@rust-timer build 55fa5150e491e8e5ce6936b862f4878fd3126ffc |
|
Success: Queued 55fa5150e491e8e5ce6936b862f4878fd3126ffc with parent f28f648, comparison URL. |
|
From the comparison URL, these are the ones that I am confident are not noise: |
|
It's been a week and this is a tiny change. Let's try a different reviewer: r? @varkor |
|
There are some nice gains here, thanks! @bors r+ rollup |
|
📌 Commit b73843f has been approved by |
bors
added
S-waiting-on-bors
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit b73843f has been approved by |
|
Thank you for the fast review. |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Aug 28, 2018
… r=varkor Force-inline `shallow_resolve` at its hottest call site. It's a ~1% win on `keccak` and `inflate`.
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Aug 28, 2018
… r=varkor Force-inline `shallow_resolve` at its hottest call site. It's a ~1% win on `keccak` and `inflate`.
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Aug 29, 2018
… r=varkor Force-inline `shallow_resolve` at its hottest call site. It's a ~1% win on `keccak` and `inflate`.
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Aug 29, 2018
… r=varkor Force-inline `shallow_resolve` at its hottest call site. It's a ~1% win on `keccak` and `inflate`.
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Aug 30, 2018
… r=varkor Force-inline `shallow_resolve` at its hottest call site. It's a ~1% win on `keccak` and `inflate`.
bors
added a commit
that referenced
this pull request
Aug 31, 2018
Rollup of 20 pull requests Successful merges: - #51760 (Add another PartialEq example) - #53113 (Add example for Cow) - #53129 (remove `let x = baz` which was obscuring the real error) - #53389 (document effect of join on memory ordering) - #53472 (Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.) - #53476 (Add partialeq implementation for TryFromIntError type) - #53513 (Force-inline `shallow_resolve` at its hottest call site.) - #53655 (set applicability) - #53702 (Fix stabilisation version for macro_vis_matcher.) - #53727 (Do not suggest dereferencing in macro) - #53732 (save-analysis: Differentiate foreign functions and statics.) - #53740 (add llvm-readobj to llvm-tools-preview) - #53743 (fix a typo: taget_env -> target_env) - #53747 (Rustdoc fixes) - #53753 (expand keep-stage --help text) - #53756 (Fix typo in comment) - #53768 (move file-extension based .gitignore down to src/) - #53785 (Fix a comment in src/libcore/slice/mod.rs) - #53786 (Replace usages of 'bad_style' with 'nonstandard_style'.) - #53806 (Fix UI issues on Implementations on Foreign types) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a ~1% win on
keccakandinflate.