New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThinLTO: Don't keep files open after mmaping them. #53962

Merged
merged 1 commit into from Sep 5, 2018

Conversation

Projects
None yet
5 participants
@michaelwoerister
Contributor

michaelwoerister commented Sep 5, 2018

Fixes #53947.

r? @alexcrichton

@michaelwoerister

This comment has been minimized.

Show comment
Hide comment
@michaelwoerister
Contributor

michaelwoerister commented Sep 5, 2018

@bors try

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Sep 5, 2018

Contributor

⌛️ Trying commit fc47a92 with merge bc802ef...

Contributor

bors commented Sep 5, 2018

⌛️ Trying commit fc47a92 with merge bc802ef...

bors added a commit that referenced this pull request Sep 5, 2018

Auto merge of #53962 - michaelwoerister:close-thinlto-file-descriptor…
…s, r=<try>

ThinLTO: Don't keep files open after mmaping them.

Fixes #53947.

r? @alexcrichton
@michaelwoerister

This comment has been minimized.

Show comment
Hide comment
@michaelwoerister
Contributor

michaelwoerister commented Sep 5, 2018

@rust-timer

This comment has been minimized.

Show comment
Hide comment
@rust-timer

rust-timer Sep 5, 2018

Success: Queued bc802ef with parent 3f13b27, comparison URL.

rust-timer commented Sep 5, 2018

Success: Queued bc802ef with parent 3f13b27, comparison URL.

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Sep 5, 2018

Contributor

☀️ Test successful - status-travis
State: approved= try=True

Contributor

bors commented Sep 5, 2018

☀️ Test successful - status-travis
State: approved= try=True

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Sep 5, 2018

Member

r=me if perf comes back with a successful run!

Or just r=me in general, looks good!

Member

alexcrichton commented Sep 5, 2018

r=me if perf comes back with a successful run!

Or just r=me in general, looks good!

@michaelwoerister

This comment has been minimized.

Show comment
Hide comment
@michaelwoerister

michaelwoerister Sep 5, 2018

Contributor

Yeah, the test run didn't make too much sense since the parent commit is still broken. Unless the build logs can be viewed somewhere. Anyway, I'm even going to up the priority so we get valid perf data sooner.

@bors r=alexcrichton p=1

Contributor

michaelwoerister commented Sep 5, 2018

Yeah, the test run didn't make too much sense since the parent commit is still broken. Unless the build logs can be viewed somewhere. Anyway, I'm even going to up the priority so we get valid perf data sooner.

@bors r=alexcrichton p=1

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Sep 5, 2018

Contributor

📌 Commit fc47a92 has been approved by alexcrichton

Contributor

bors commented Sep 5, 2018

📌 Commit fc47a92 has been approved by alexcrichton

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Sep 5, 2018

Contributor

⌛️ Testing commit fc47a92 with merge 6e0f1cc...

Contributor

bors commented Sep 5, 2018

⌛️ Testing commit fc47a92 with merge 6e0f1cc...

bors added a commit that referenced this pull request Sep 5, 2018

Auto merge of #53962 - michaelwoerister:close-thinlto-file-descriptor…
…s, r=alexcrichton

ThinLTO: Don't keep files open after mmaping them.

Fixes #53947.

r? @alexcrichton
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Sep 5, 2018

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 6e0f1cc to master...

Contributor

bors commented Sep 5, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 6e0f1cc to master...

@bors bors merged commit fc47a92 into rust-lang:master Sep 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment