Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove documentation about proc_macro being bare-bones #54085

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
4 participants
@dtolnay @alexcrichton @bors @rust-highfive
@dtolnay
Copy link
Member

dtolnay commented Sep 9, 2018

A large chunk of useful API surface area is stabilizing in Rust 1.29. We no longer have a commitment to expand the API over time as much as implied by these comments.

r? @alexcrichton
@dtolnay
Remove documentation about proc_macro being bare-bones
Verified
This commit was signed with a verified signature.
@dtolnay dtolnay David Tolnay
GPG key ID: F9BA143B95FF6D82 Learn about signing commits
Loading status checks…
7acd4b1

@rust-highfive rust-highfive assigned alexcrichton Sep 9, 2018

@rust-highfive rust-highfive added the S-waiting-on-review label Sep 9, 2018

@dtolnay

This comment has been minimized.

Sign in to view
Copy link
Member Author

dtolnay commented Sep 9, 2018

@bors rollup
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Sep 9, 2018

@bors: r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Sep 9, 2018

📌 Commit 7acd4b1 has been approved by alexcrichton

@bors bors added S-waiting-on-bors and removed S-waiting-on-review labels Sep 9, 2018

kennytm added a commit to kennytm/rust that referenced this pull request Sep 12, 2018

@kennytm
Rollup merge of rust-lang#54085 - dtolnay:bare, r=alexcrichton 
Remove documentation about proc_macro being bare-bones

A large chunk of useful API surface area is stabilizing in Rust 1.29. We no longer have a commitment to expand the API over time as much as implied by these comments.

r? @alexcrichton
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
85b6bf9

@kennytm kennytm referenced this pull request Sep 12, 2018

Merged

Rollup of 15 pull requests #54146

bors added a commit that referenced this pull request Sep 12, 2018

@bors
Auto merge of #54146 - kennytm:rollup, r=kennytm 
Rollup of 15 pull requests

Successful merges:

 - #52514 (Fix a few AMDGPU related issues)
 - #53703 (Document .0 to unpack integer from Wrapping)
 - #53777 (Implemented map_or_else for Result<T, E>)
 - #54031 (A few cleanups and minor improvements to rustc_passes)
 - #54046 (Update documentation for fill_buf in std::io::BufRead)
 - #54064 (`&CStr`, not `CStr`, is the counterpart of `&str`)
 - #54072 (Stabilization change for mod.rs)
 - #54073 (docs: Use dollar sign for all bash prompts)
 - #54074 (simplify ordering for Kind)
 - #54085 (Remove documentation about proc_macro being bare-bones)
 - #54087 (rustdoc: Remove generated blanket impls from trait pages)
 - #54106 (Reexport CheckLintNameResult)
 - #54107 (Fix typos in libstd hash map)
 - #54136 (Update LLVM to fix GlobalISel dbg.declare)
 - #54142 (Recover proper regression test for issue #16278.)

Failed merges:

r? @ghost
Loading status checks…
289c63e

bors added a commit that referenced this pull request Sep 12, 2018

@bors
Auto merge of #54146 - kennytm:rollup, r=kennytm 
Rollup of 15 pull requests

Successful merges:

 - #52514 (Fix a few AMDGPU related issues)
 - #53703 (Document .0 to unpack integer from Wrapping)
 - #53777 (Implemented map_or_else for Result<T, E>)
 - #54031 (A few cleanups and minor improvements to rustc_passes)
 - #54046 (Update documentation for fill_buf in std::io::BufRead)
 - #54064 (`&CStr`, not `CStr`, is the counterpart of `&str`)
 - #54072 (Stabilization change for mod.rs)
 - #54073 (docs: Use dollar sign for all bash prompts)
 - #54074 (simplify ordering for Kind)
 - #54085 (Remove documentation about proc_macro being bare-bones)
 - #54087 (rustdoc: Remove generated blanket impls from trait pages)
 - #54106 (Reexport CheckLintNameResult)
 - #54107 (Fix typos in libstd hash map)
 - #54136 (Update LLVM to fix GlobalISel dbg.declare)
 - #54142 (Recover proper regression test for issue #16278.)

Failed merges:

r? @ghost
Loading status checks…
8586ec6

@bors bors merged commit 7acd4b1 into rust-lang:master Sep 12, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dtolnay dtolnay deleted the dtolnay:bare branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.