New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-overlap the lifetimes of `flow_inits` and `flow_{un,ever_}inits`. #54213

Merged
merged 1 commit into from Sep 16, 2018

Conversation

Projects
None yet
5 participants
@nnethercote
Contributor

nnethercote commented Sep 14, 2018

This reduces max-rss for an nll-check build by 27% for keccak, and
by 8% for inflate.

r? @nikomatsakis

De-overlap the lifetimes of `flow_inits` and `flow_{un,ever_}inits`.
This reduces `max-rss` for an `nll-check` build by 27% for `keccak`, and
by 8% for `inflate`.
@nikomatsakis

This comment has been minimized.

Contributor

nikomatsakis commented Sep 14, 2018

@bors r+ rollup

@bors

This comment has been minimized.

Contributor

bors commented Sep 14, 2018

📌 Commit aa9aca0 has been approved by nikomatsakis

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 16, 2018

Rollup merge of rust-lang#54213 - nnethercote:keccak-flow_inits-memor…
…y, r=nikomatsakis

De-overlap the lifetimes of `flow_inits` and `flow_{un,ever_}inits`.

This reduces `max-rss` for an `nll-check` build by 27% for `keccak`, and
by 8% for `inflate`.

r? @nikomatsakis

bors added a commit that referenced this pull request Sep 16, 2018

Auto merge of #54270 - GuillaumeGomez:rollup, r=GuillaumeGomez
Rollup of 5 pull requests

Successful merges:

 - #53941 (rustdoc: Sort implementors)
 - #54181 (Suggest && and || instead of 'and' and 'or')
 - #54209 (Partially revert 674a5db "Fix undesirable fallout [from macro modularization]")
 - #54213 (De-overlap the lifetimes of `flow_inits` and `flow_{un,ever_}inits`.)
 - #54244 (Add a small search box to seach Rust's standary library)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Sep 16, 2018

Auto merge of #54270 - GuillaumeGomez:rollup, r=GuillaumeGomez
Rollup of 5 pull requests

Successful merges:

 - #53941 (rustdoc: Sort implementors)
 - #54181 (Suggest && and || instead of 'and' and 'or')
 - #54209 (Partially revert 674a5db "Fix undesirable fallout [from macro modularization]")
 - #54213 (De-overlap the lifetimes of `flow_inits` and `flow_{un,ever_}inits`.)
 - #54244 (Add a small search box to seach Rust's standary library)

Failed merges:

r? @ghost

@bors bors merged commit aa9aca0 into rust-lang:master Sep 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nnethercote nnethercote deleted the nnethercote:keccak-flow_inits-memory branch Sep 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment