New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Once perf regression #54662

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Projects
None yet
6 participants
@matklad
Member

matklad commented Sep 29, 2018

Because call_once is generic, but is_completed is not, we need
#[inline] annotation to allow LLVM to inline is_completed into
call_once in downstream crates.

cc https://github.com/rust-lang/rust/pull/53027/files#r221418859

Fix Once perf regression
Because `call_once` is generic, but `is_completed` is not, we need
`#[inline]` annotation to allow LLVM to inline `is_completed` into
`call_once` in downstream crates.
@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Sep 29, 2018

Collaborator

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Sep 29, 2018

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb

This comment has been minimized.

Show comment
Hide comment
@eddyb
Member

eddyb commented Sep 29, 2018

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton
Member

alexcrichton commented Sep 29, 2018

@bors: r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Sep 29, 2018

Contributor

📌 Commit f8e9d2f has been approved by alexcrichton

Contributor

bors commented Sep 29, 2018

📌 Commit f8e9d2f has been approved by alexcrichton

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 1, 2018

Contributor

⌛️ Testing commit f8e9d2f with merge 0337964...

Contributor

bors commented Oct 1, 2018

⌛️ Testing commit f8e9d2f with merge 0337964...

bors added a commit that referenced this pull request Oct 1, 2018

Auto merge of #54662 - matklad:once-perf, r=alexcrichton
Fix Once perf regression

Because `call_once` is generic, but `is_completed` is not, we need
`#[inline]` annotation to allow LLVM to inline `is_completed` into
`call_once` in downstream crates.

cc https://github.com/rust-lang/rust/pull/53027/files#r221418859
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 1, 2018

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 0337964 to master...

Contributor

bors commented Oct 1, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 0337964 to master...

@bors bors merged commit f8e9d2f into rust-lang:master Oct 1, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment