Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Once perf regression #54662

Merged
merged 1 commit into from Oct 1, 2018
Merged

Fix Once perf regression #54662

merged 1 commit into from Oct 1, 2018

Conversation

@matklad
Copy link
Member

@matklad matklad commented Sep 29, 2018

Because call_once is generic, but is_completed is not, we need
#[inline] annotation to allow LLVM to inline is_completed into
call_once in downstream crates.

cc https://github.com/rust-lang/rust/pull/53027/files#r221418859

Because `call_once` is generic, but `is_completed` is not, we need
`#[inline]` annotation to allow LLVM to inline `is_completed` into
`call_once` in downstream crates.
@rust-highfive
Copy link
Collaborator

@rust-highfive rust-highfive commented Sep 29, 2018

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb
Copy link
Member

@eddyb eddyb commented Sep 29, 2018

@alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Sep 29, 2018

@bors: r+

@bors
Copy link
Contributor

@bors bors commented Sep 29, 2018

📌 Commit f8e9d2f has been approved by alexcrichton

@bors
Copy link
Contributor

@bors bors commented Oct 1, 2018

Testing commit f8e9d2f with merge 0337964...

bors added a commit that referenced this pull request Oct 1, 2018
Fix Once perf regression

Because `call_once` is generic, but `is_completed` is not, we need
`#[inline]` annotation to allow LLVM to inline `is_completed` into
`call_once` in downstream crates.

cc https://github.com/rust-lang/rust/pull/53027/files#r221418859
@bors
Copy link
Contributor

@bors bors commented Oct 1, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 0337964 to master...

@bors bors merged commit f8e9d2f into rust-lang:master Oct 1, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@matklad matklad deleted the matklad:once-perf branch Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.