New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bug! message for impossible case in Relate #54679

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Projects
None yet
6 participants
@phansch
Contributor

phansch commented Sep 29, 2018

Hitting this branch in Clippy and I think it makes sense to print
both values here in case other people hit this branch, too.

(still have to figure out why this branch is hit)

Improve bug! message for impossible case in Relate
Hitting this branch in Clippy and I think it makes sense to print
both values here in case other people hit this branch, too.
@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Sep 29, 2018

Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Sep 29, 2018

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@tmandry

This comment has been minimized.

Show comment
Hide comment
@tmandry

tmandry Sep 29, 2018

Contributor

@bors r+

Contributor

tmandry commented Sep 29, 2018

@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Sep 29, 2018

Contributor

@tmandry: 🔑 Insufficient privileges: Not in reviewers

Contributor

bors commented Sep 29, 2018

@tmandry: 🔑 Insufficient privileges: Not in reviewers

@tmandry

This comment has been minimized.

Show comment
Hide comment
@tmandry

tmandry Sep 29, 2018

Contributor

Looks like bors hasn’t updated yet, you’re the first PR I tried to r+ ☺️

Contributor

tmandry commented Sep 29, 2018

Looks like bors hasn’t updated yet, you’re the first PR I tried to r+ ☺️

@matthewjasper

This comment has been minimized.

Show comment
Hide comment
@matthewjasper
Contributor

matthewjasper commented Sep 29, 2018

@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Sep 29, 2018

Contributor

📌 Commit d654e3c has been approved by matthewjasper

Contributor

bors commented Sep 29, 2018

📌 Commit d654e3c has been approved by matthewjasper

@kennytm

This comment has been minimized.

Show comment
Hide comment
@kennytm

kennytm Oct 1, 2018

Member

@bors rollup

Member

kennytm commented Oct 1, 2018

@bors rollup

kennytm added a commit to kennytm/rust that referenced this pull request Oct 1, 2018

Rollup merge of rust-lang#54679 - phansch:improve_bug_message, r=matt…
…hewjasper

Improve bug! message for impossible case in Relate

Hitting this branch [in Clippy][clippy_issue] and I think it makes sense to print
both values here in case other people hit this branch, too.

(still have to figure out why this branch is hit)

[clippy_issue]: rust-lang-nursery/rust-clippy#2831 (comment)

bors added a commit that referenced this pull request Oct 1, 2018

Auto merge of #54711 - kennytm:rollup, r=kennytm
Rollup of 10 pull requests

Successful merges:

 - #53784 (Document that slices cannot be larger than `isize::MAX` bytes)
 - #54308 (Better user experience when attempting to call associated functions with dot notation)
 - #54488 (in which we include attributes in unused `extern crate` suggestion spans)
 - #54544 (Indicate how to move value out of Box in docs.)
 - #54623 (Added help message for `impl_trait_in_bindings` feature gate)
 - #54641 (A few cleanups and minor improvements to rustc/infer)
 - #54656 (Correct doc for WorkQueue<T>::pop().)
 - #54679 (Improve bug! message for impossible case in Relate)
 - #54681 (Rename sanitizer runtime libraries on OSX)
 - #54708 (Make ./x.py help <cmd> invoke ./x.py <cmd> -h on its own )

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Oct 1, 2018

Auto merge of #54711 - kennytm:rollup, r=kennytm
Rollup of 13 pull requests

Successful merges:

 - #53784 (Document that slices cannot be larger than `isize::MAX` bytes)
 - #54308 (Better user experience when attempting to call associated functions with dot notation)
 - #54488 (in which we include attributes in unused `extern crate` suggestion spans)
 - #54544 (Indicate how to move value out of Box in docs.)
 - #54623 (Added help message for `impl_trait_in_bindings` feature gate)
 - #54641 (A few cleanups and minor improvements to rustc/infer)
 - #54656 (Correct doc for WorkQueue<T>::pop().)
 - #54674 (update miri)
 - #54676 (Remove `-Z disable_ast_check_for_mutation_in_guard`)
 - #54679 (Improve bug! message for impossible case in Relate)
 - #54681 (Rename sanitizer runtime libraries on OSX)
 - #54708 (Make ./x.py help <cmd> invoke ./x.py <cmd> -h on its own)
 - #54713 (Add nightly check for tool_lints warning)

@bors bors merged commit d654e3c into rust-lang:master Oct 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@phansch phansch deleted the phansch:improve_bug_message branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment