New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nest the `impl Trait` existential item inside the return type #54741

Merged
merged 2 commits into from Oct 5, 2018

Conversation

Projects
None yet
4 participants
@oli-obk
Contributor

oli-obk commented Oct 2, 2018

fixes #54045

r? @cramertj

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Oct 2, 2018

Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Collaborator

rust-highfive commented Oct 2, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@cramertj

This comment has been minimized.

Show comment
Hide comment
@cramertj

cramertj Oct 2, 2018

Member

Nice!

@bors r+

Member

cramertj commented Oct 2, 2018

Nice!

@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 2, 2018

Contributor

📌 Commit c3151c6 has been approved by cramertj

Contributor

bors commented Oct 2, 2018

📌 Commit c3151c6 has been approved by cramertj

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 5, 2018

Contributor

⌛️ Testing commit c3151c6 with merge 2155f27...

Contributor

bors commented Oct 5, 2018

⌛️ Testing commit c3151c6 with merge 2155f27...

bors added a commit that referenced this pull request Oct 5, 2018

Auto merge of #54741 - oli-obk:impl_trait_hierarchy, r=cramertj
Nest the `impl Trait` existential item inside the return type

fixes #54045

r? @cramertj
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 5, 2018

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: cramertj
Pushing 2155f27 to master...

Contributor

bors commented Oct 5, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: cramertj
Pushing 2155f27 to master...

@bors bors merged commit c3151c6 into rust-lang:master Oct 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@bors bors referenced this pull request Oct 5, 2018

Merged

Cleanup rustc/middle #54756

Manishearth added a commit to rust-lang-nursery/rust-clippy that referenced this pull request Oct 5, 2018

Manishearth added a commit to rust-lang-nursery/rust-clippy that referenced this pull request Oct 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment