New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLL is missing struct field suggestion #54831

Merged
merged 2 commits into from Oct 10, 2018

Conversation

Projects
None yet
7 participants
@davidtwco
Member

davidtwco commented Oct 4, 2018

Part of #52663.

This commit adds suggestions to change the definitions of fields in
struct definitions from immutable references to mutable references.

r? @nikomatsakis
cc @pnkfelix

@nikomatsakis

r=me but maybe consider matching AST message (could we then remove the .nll reference?)

@memoryruins memoryruins added the A-NLL label Oct 6, 2018

davidtwco added some commits Oct 4, 2018

Add struct field suggestions.
This commit adds suggestions to change the definitions of fields in
struct definitions from immutable references to mutable references.
Change from label to suggestion.
This commit changes the label to a maybe incorrect suggestion for better
integration with RLS.
@nikomatsakis

This comment has been minimized.

Show comment
Hide comment
@nikomatsakis

nikomatsakis Oct 8, 2018

Contributor

@bors r+

Contributor

nikomatsakis commented Oct 8, 2018

@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 8, 2018

Contributor

📌 Commit 9e49ac0 has been approved by nikomatsakis

Contributor

bors commented Oct 8, 2018

📌 Commit 9e49ac0 has been approved by nikomatsakis

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Oct 9, 2018

Rollup merge of rust-lang#54831 - davidtwco:issue-52663-struct-field-…
…suggestion, r=nikomatsakis

NLL is missing struct field suggestion

Part of rust-lang#52663.

This commit adds suggestions to change the definitions of fields in
struct definitions from immutable references to mutable references.

r? @nikomatsakis
cc @pnkfelix

bors added a commit that referenced this pull request Oct 10, 2018

Auto merge of #54944 - pietroalbini:rollup, r=pietroalbini
Rollup of 14 pull requests

Successful merges:

 - #54755 (Documents reference equality by address (#54197))
 - #54811 (During rustc bootstrap, make default for `optimize` independent of `debug`)
 - #54831 (NLL is missing struct field suggestion)
 - #54848 (Better Diagnostic for Trait Object Capture)
 - #54850 (Fix #54707 - parse_trait_item_ now handles interpolated blocks as function body decls)
 - #54860 (Add doc comments about safest way to initialize a vector of zeros)
 - #54869 (Fix mobile docs)
 - #54891 (Fix tracking issue for Once::is_completed)
 - #54893 (Fix internal compiler error on malformed match arm pattern.)
 - #54904 (Stabilize the `Option::replace` method)
 - #54913 (doc fix: it's auto traits that make for automatic implementations)
 - #54917 (Unused result warning: "X which must" ↦ "X that must")
 - #54920 (Fix handling of #[must_use] on unit and uninhabited types)
 - #54936 (impl Eq+Hash for TyLayout)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 10, 2018

Contributor

⌛️ Testing commit 9e49ac0 with merge 71d3a71...

Contributor

bors commented Oct 10, 2018

⌛️ Testing commit 9e49ac0 with merge 71d3a71...

bors added a commit that referenced this pull request Oct 10, 2018

Auto merge of #54831 - davidtwco:issue-52663-struct-field-suggestion,…
… r=nikomatsakis

NLL is missing struct field suggestion

Part of #52663.

This commit adds suggestions to change the definitions of fields in
struct definitions from immutable references to mutable references.

r? @nikomatsakis
cc @pnkfelix
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 10, 2018

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 71d3a71 to master...

Contributor

bors commented Oct 10, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 71d3a71 to master...

@bors bors merged commit 9e49ac0 into rust-lang:master Oct 10, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@davidtwco davidtwco deleted the davidtwco:issue-52663-struct-field-suggestion branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment