New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLL: Fix migrate mode issue by not buffering lints. #55135

Merged
merged 1 commit into from Oct 18, 2018

Conversation

Projects
None yet
4 participants
@davidtwco
Member

davidtwco commented Oct 16, 2018

When lints are emitted from the AST borrow checker, they do not signal
an error as it is not known at that time whether, due to attributes,
that lint will error or warn. This means that when lints are buffered
in the MIR they will always be downgraded, as the AST borrowck will not
have been marked as having errored, even if a lint was upgraded to
an error after being emitted from the AST borrowck. The simple solution
to this is to not buffer any lints from the MIR borrowck.

r? @pnkfelix

Don't buffer lints.
When lints are emitted from the AST borrow checker, they do not signal
an error as it is not known at that time whether, due to attributes,
that lint will error or warn. This means that when lints are buffered
in the MIR they will always be downgraded, as the AST borrowck will not
have been marked as having errored, even if a lint was upgraded to
an error after being emitted from the AST borrowck. The simple solution
to this is to not buffer any lints from the MIR borrowck.
@pnkfelix

This comment has been minimized.

Member

pnkfelix commented Oct 17, 2018

@bors r+

@bors

This comment has been minimized.

Contributor

bors commented Oct 17, 2018

📌 Commit d8db529 has been approved by pnkfelix

@pnkfelix

This comment has been minimized.

Member

pnkfelix commented Oct 17, 2018

@bors rollup

@bors bors merged commit d8db529 into rust-lang:master Oct 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davidtwco davidtwco deleted the davidtwco:issue-55118-migrate-fix branch Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment