Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[WIP] Bump system LLVM version to 7 #55176
Conversation
rust-highfive
assigned
nikomatsakis
Oct 18, 2018
This comment has been minimized.
This comment has been minimized.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
label
Oct 18, 2018
glandium
force-pushed the
glandium:system-llvm
branch
from
0362f4c
to
046fe96
Oct 18, 2018
glandium
force-pushed the
glandium:system-llvm
branch
from
046fe96
to
53ba5cb
Oct 18, 2018
This comment has been minimized.
This comment has been minimized.
|
Started thread: https://internals.rust-lang.org/t/rust-vs-llvm/8604 Don't merge. |
kennytm
added
S-blocked
and removed
S-waiting-on-review
labels
Oct 19, 2018
nikomatsakis
changed the title
Bump system LLVM version to 7
[WIP] Bump system LLVM version to 7
Oct 22, 2018
This comment has been minimized.
This comment has been minimized.
|
Tagging as |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
It does not appear that there is any more discussion on the linked thread. There doesn’t appear to be any sort of consensus... |
This comment has been minimized.
This comment has been minimized.
|
@glandium is this PR still necessary ? |
This comment has been minimized.
This comment has been minimized.
|
Probably not. |
glandium
closed this
Feb 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
glandium commentedOct 18, 2018
My immediate goal with this PR is to see if the change works on Travis. There is much discussion to have related to system LLVM, Travis, and the minimum supported version of system LLVM, and I'm not sure this is the right avenue. I'll probably post something on internals.rust-lang.org.