New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libproc_macro to rust-src distribution #55280

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
8 participants
@vlad20012
Member

vlad20012 commented Oct 23, 2018

Fixes #55279

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Oct 23, 2018

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@TimNN

This comment has been minimized.

Contributor

TimNN commented Oct 30, 2018

Ping from triage @aturon: This PR requires your review.

@Mark-Simulacrum

This comment has been minimized.

Member

Mark-Simulacrum commented Oct 30, 2018

@bors r+

Cc @rust-lang/libs @rust-lang/lang just for awareness (but I don't see this as anything that needs a team decision - proc_macro is stably exposed).

@bors

This comment has been minimized.

Contributor

bors commented Oct 30, 2018

📌 Commit ea3e9a3 has been approved by Mark-Simulacrum

@cuviper

This comment has been minimized.

Member

cuviper commented Oct 30, 2018

From #55279:

I see proc_macro has a several dependencies: "libsyntax", "libsyntax_pos", "librustc_errors", "librustc_data_structures". Is it ok to not add them to the list?

@vlad20012, what did you find? Is libproc_macro alone useful enough for your IDE, without its other dependencies?

@Centril Centril assigned Mark-Simulacrum and unassigned aturon Oct 30, 2018

@vlad20012

This comment has been minimized.

Member

vlad20012 commented Oct 30, 2018

@cuviper

Is libproc_macro alone useful enough for your IDE, without its other dependencies?

Certainly yes! It doesn't re-export its dependencies.
My question was just about your vision of source distribution (is it ok or not to distribute some crate sources without its dependencies). As for me - it's ok =)

@Mark-Simulacrum

This comment has been minimized.

Member

Mark-Simulacrum commented Oct 31, 2018

Yes, the rust-src component is purely intended for this sort of autocompletion etc -- if you want to build Rust, that's a separate component (i.e., the source code itself, in full)

@bors

This comment has been minimized.

Contributor

bors commented Oct 31, 2018

⌛️ Testing commit ea3e9a3 with merge bac0697...

bors added a commit that referenced this pull request Oct 31, 2018

Auto merge of #55280 - vlad20012:add-libproc_macro-to-src-disrt, r=Ma…
…rk-Simulacrum

Add libproc_macro to rust-src distribution

Fixes #55279
@bors

This comment has been minimized.

Contributor

bors commented Oct 31, 2018

💔 Test failed - status-travis

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Oct 31, 2018

The job dist-i686-freebsd of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:08:37] travis_fold:start:stage2-cargo
travis_time:start:stage2-cargo
Building stage2 tool cargo (i686-unknown-freebsd)
[01:08:37]  Downloading openssl-src v111.0.1+1.1.1
[01:08:58] warning: spurious network error (2 tries remaining): failed to download from `https://crates.io/api/v1/crates/openssl-src/111.0.1+1.1.1/download`
[01:09:18] warning: spurious network error (1 tries remaining): failed to download from `https://crates.io/api/v1/crates/openssl-src/111.0.1+1.1.1/download`
[01:09:38] 
[01:09:38] Caused by:
[01:09:38] Caused by:
[01:09:38]   failed to download from `https://crates.io/api/v1/crates/openssl-src/111.0.1+1.1.1/download`
[01:09:38] Caused by:
[01:09:38]   [6] Couldn't resolve host name (Could not resolve host: crates.io)
[01:09:38] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "i686-unknown-freebsd" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/cargo/Cargo.toml" "--features" "rustc-workspace-hack/all-static" "--message-format" "json"
[01:09:38] expected success, got: exit code: 101
---
travis_time:end:23b91e37:start=1540968079880489677,finish=1540968079889693320,duration=9203643
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1231e3d3
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:02c6c1ff
travis_time:start:02c6c1ff
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1b3979f2
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm

This comment has been minimized.

Member

kennytm commented Oct 31, 2018

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 1, 2018

Rollup merge of rust-lang#55280 - vlad20012:add-libproc_macro-to-src-…
…disrt, r=Mark-Simulacrum

Add libproc_macro to rust-src distribution

Fixes rust-lang#55279

bors added a commit that referenced this pull request Nov 1, 2018

Auto merge of #55579 - pietroalbini:rollup, r=pietroalbini
Rollup of 10 pull requests

Successful merges:

 - #55280 (Add libproc_macro to rust-src distribution)
 - #55469 (Regression tests for issue #54477.)
 - #55504 (Use vec![x; n] instead of iter::repeat(x).take(n).collect())
 - #55518 (std: Improve codegen size of accessing TLS)
 - #55522 (use String::from() instead of format!() macro to construct Strings.)
 - #55536 (Pass suggestions as impl Iterator instead of Vec)
 - #55542 (syntax: improve a few allocations)
 - #55558 (Tweak `MatcherPos::matches`)
 - #55574 (Use `SmallVec` within `MoveData`.)
 - #55575 (Fix invalid_const_promotion test on some archs)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Nov 1, 2018

Auto merge of #55579 - pietroalbini:rollup, r=kennytm
Rollup of 13 pull requests

Successful merges:

 - #55280 (Add libproc_macro to rust-src distribution)
 - #55469 (Regression tests for issue #54477.)
 - #55504 (Use vec![x; n] instead of iter::repeat(x).take(n).collect())
 - #55522 (use String::from() instead of format!() macro to construct Strings.)
 - #55536 (Pass suggestions as impl Iterator instead of Vec)
 - #55542 (syntax: improve a few allocations)
 - #55558 (Tweak `MatcherPos::matches`)
 - #55561 (Fix double_check tests on big-endian targets)
 - #55573 (Make sure the `aws` executable is in $PATH on macOS)
 - #55574 (Use `SmallVec` within `MoveData`.)
 - #55575 (Fix invalid_const_promotion test on some archs)
 - #55578 (Made doc example of `impl Default for …` use `-> Self` instead of explicit self type)
 - #55582 (Remove unused import copy from publish_toolstate.py)

@bors bors merged commit ea3e9a3 into rust-lang:master Nov 1, 2018

1 of 2 checks passed

homu Test failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment