New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change a flat_map with 0/1-element vecs to a filter_map #55476

Merged
merged 1 commit into from Oct 30, 2018

Conversation

Projects
None yet
5 participants
@ljedrz
Contributor

ljedrz commented Oct 29, 2018

No need to use vectors in this case - Options are quite sufficient.

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Oct 29, 2018

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@cramertj

This comment has been minimized.

Member

cramertj commented Oct 29, 2018

@bors r+ rollup

@bors

This comment has been minimized.

Contributor

bors commented Oct 29, 2018

📌 Commit bb3e77d has been approved by cramertj

kennytm added a commit to kennytm/rust that referenced this pull request Oct 30, 2018

Rollup merge of rust-lang#55476 - ljedrz:flat_map_to_filter_map, r=cr…
…amertj

Change a flat_map with 0/1-element vecs to a filter_map

No need to use vectors in this case - `Option`s are quite sufficient.

bors added a commit that referenced this pull request Oct 30, 2018

Auto merge of #55502 - kennytm:rollup, r=kennytm
Rollup of 12 pull requests

Successful merges:

 - #54885 (Don't lint 'unused_parens` on `if (break _) { .. }`)
 - #55205 (Improve a few cases of collecting to an FxHash(Map/Set))
 - #55450 (msp430: remove the whole Atomic* API)
 - #55459 (Add UI test for #49296)
 - #55472 (Use opt.take() instead of mem::replace(opt, None))
 - #55473 (Take advantage of impl Iterator in (transitive/elaborate)_bounds)
 - #55474 (Fix validation false positive)
 - #55476 (Change a flat_map with 0/1-element vecs to a filter_map)
 - #55487 (Adjust Ids of path segments in visibility modifiers)
 - #55493 (Doc fixes)
 - #55494 (borrowck=migrate must look at parents of closures)
 - #55496 (Update clippy)

Failed merges:

r? @ghost

@bors bors merged commit bb3e77d into rust-lang:master Oct 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ljedrz ljedrz deleted the ljedrz:flat_map_to_filter_map branch Oct 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment