Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Value visitors for miri #55549
Click to expand the log.
Preliminary review. I think reviewing the rest only makes sense with the review questions addressed
oh damn, I never pressed the submit review button :/
Anyway, yes, this is getting closer to what I'm imagining.
Take the comments with a grain of salt, because I've not checked how obsolete they have become with your changes
The visitor as it is (except for the
visit_scalar method as mentioned in the comments) looks good to me now. I'll review the rest of the code independently now