Build rlibs for the core compile crates #55860
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the compiler to be embedded in a staticlib, suitable for invoking from a C application on a platform lacking a dynamic linker.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Thanks for the PR! Unfortunately though this is going to be pretty tricky to land, not just because of the CI failures but because of distribution problems as well. We don't necessarily want to commit to shipping two copies of the compiler per target (one dynamic and one static), so there's a larger question here about whether we want to support this and whether we can support this. I think that a question like that probably shouldn't be hashed out here on this PR but rather on one of our forums like internals.rust-lang.org |
|
Makes sense. I'll kick off the discussion at https://internals.rust-lang.org/t/embedding-rustc-on-ios/8824 |
|
Ok thanks! I'm going to close this in favor of that discussion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the compiler to be embedded in a staticlib, suitable for
invoking from a C application on a platform lacking a dynamic linker.
See #55741