New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Remove unnecessary dummy span checks #56221

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@estebank
Contributor

estebank commented Nov 25, 2018

The emitter already verifies wether a given span note or span label
can be emitted to the output. If it can't, because it is a dummy
span, it will be either elided for labels or emitted as an unspanned
note/help when applicable.

Remove unnecessary dummy span checks
The emitter already verifies wether a given span note or span label
can be emitted to the output. If it can't, because it is a dummy
span, it will be either elided for labels or emitted as an unspanned
note/help when applicable.
@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Nov 25, 2018

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@estebank

This comment has been minimized.

Contributor

estebank commented Nov 25, 2018

CC #55669

@estebank estebank changed the title from Remove unnecessary dummy span checks to WIP Remove unnecessary dummy span checks Nov 25, 2018

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Nov 25, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:04c4d500:start=1543180090456155706,finish=1543180091509179283,duration=1053023577
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:51:36] .................................................................................................... 1300/5057
[00:51:39] .................................................................................................... 1400/5057
[00:51:41] .................................................................................................... 1500/5057
[00:51:45] ....i....................................................................i.......................... 1600/5057
[00:51:48] .....................................................................................FF............. 1700/5057
[00:51:52] .....F....F.......F................................................................................. 1800/5057
[00:51:58] ............i....................................................................................... 2000/5057
[00:52:02] .................................................................................................... 2100/5057
[00:52:06] .................................................................................................... 2200/5057
[00:52:10] .................................................................................................... 2300/5057
[00:52:10] .................................................................................................... 2300/5057
[00:52:14] .................................................................................................... 2400/5057
[00:52:18] .................................................................................................... 2500/5057
[00:52:22] .................................................................................................... 2600/5057
[00:52:26] .................................................................................................... 2700/5057
[00:52:29] .................................................................................................... 2800/5057
[00:52:32] .................................................................................................... 2900/5057
[00:52:36] .................................................................................................... 3000/5057
[00:52:39] ........................................................i.........................F................. 3100/5057
[00:52:46] ...................ii..i..ii........................................................................ 3300/5057
[00:52:50] .................................................................................................... 3400/5057
[00:52:53] .................................................................................................... 3500/5057
[00:52:56] ii.................................................................................................. 3600/5057
[00:52:56] ii.................................................................................................. 3600/5057
[00:52:58] ..................i................................................................................. 3700/5057
[00:52:59] ..........................................................................i......................... 3800/5057
[00:53:01] .................................................................................................... 3900/5057
[00:53:04] .................................................................................................... 4000/5057
[00:53:07] .................................................................................................... 4100/5057
[00:53:10] .................................................................................................... 4200/5057
[00:53:14] ...................................i................................................................ 4300/5057
[00:53:19] ........................................F.F.FF..F.FFF............................................... 4400/5057
[00:53:26] .................................................................................................... 4600/5057
[00:53:29] .....................i.............................................................................. 4700/5057
[00:53:33] .................................................................................................... 4800/5057
[00:53:36] .................................................................................................... 4900/5057
[00:53:36] .................................................................................................... 4900/5057
[00:53:38] ................................................................................................i... 5000/5057
sion":{"span":{"file_name":"/checkout/src/test/ui/imports/extern-prelude-extern-crate-restricted-shadowing.rs","byte_start":396,"byte_end":417,"line_start":24,"line_end":24,"column_start":1,"column_end":22,"is_primary":false,"text":[{"text":"define_other_core!();","highlight_start":1,"highlight_end":22}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"define_other_core!","def_site_span":{"file_name":"/checkout/src/test/ui/imports/extern-prelude-extern-crate-restricted-shadowing.rs","byte_start":210,"byte_end":394,"line_start":17,"line_end":22,"column_start":1,"column_end":2,"is_primary":false,"text":[{"text":"macro_rules! define_other_core {","highlight_start":1,"highlight_end":33},{"text":"    () => {","highlight_start":1,"highlight_end":12},{"text":"        extern crate std as core;","highlight_start":1,"highlight_end":34},{"text":"        //~^ ERROR macro-expanded `extern crate` items cannot shadow names passed with `--extern`","highlight_start":1,"highlight_end":98},{"text":"    }","highlight_start":1,"highlight_end":6},{"text":"}","highlight_start":1,"highlight_end":2}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[],"rendered":"error: macro-expanded `extern crate` items cannot shadow names passed with `--extern`\n  --> /checkout/src/test/ui/imports/extern-prelude-extern-crate-restricted-shadowing.rs:19:9\n   |\nLL |         extern crate std as core;\n   |         ^^^^^^^^^^^^^^^^^^^^^^^^^\n...\nLL | define_other_core!();\n   | --------------------- in this macro invocation\n\n"}
[00:53:40] {"messac/test/ui/imports/glob-shadowing.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/glob-shadowing/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/glob-shadowing/auxiliary" "-A" "unused"
[00:53:40] ------------------------------------------
[00:53:40] 
[00:53:40] ------------------------------------------
[00:53:40] stderr:
[00:53:40] stderr:
[00:53:40] ------------------------------------------
[00:53:40] {"message":"`env` is ambiguous (glob import vs any other name from outer scope during import/macro resolution)","code":{"code":"E0659","explanation":"\nAn item usage is ambiguous.\n\nErroneous code example:\n\n```compile_fail,E0659\npub mod moon {\n    pub fn foo() {}\n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon::*;\n    pub use earth::*;\n}\n\nfn main() {\n    collider::foo(); // ERROR: `foo` is ambiguous\n}\n```\n\nThis error generally appears when two items with the same name are imported into\na module. Here, the `foo` functions are imported and reexported from the\n`collider` module and therefore, when we're using `collider::foo()`, both\nfunctions collide.\n\nTo solve this error, the best solution is generally to keep the path before the\nitem when using it. Example:\n\n```\npub mod moon {\n    pub fn foo() {}\n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon;\n    pub use earth;\n}\n\nfn maige":"or use `self::env` to refer to this macro unambiguously","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0659]: `env` is ambiguous (glob import vs any other name from outer scope during import/macro resolution)\n  --> /checkout/src/test/ui/imports/glob-shadowing.rs:21:17\n   |\nLL |         let x = env!(\"PATH\"); //~ ERROR `env` is ambiguous\n   |                 ^^^ ambiguous name\n   |\nnote: `env` could refer to a built-in macro\nnote: `env` could also refer to the macro imported here\n  --> /checkout/src/test/ui/imports/glob-shadowing.rs:19:9\n   |\nLL |     use m::*;\n   |         ^^^^\n   = help: consider adding an explicit import of `env` to disambiguate\n   = help: or use `self::env` to refer to this macro unambiguously\n\n"}
[00:53:40] {"message":"`env` is ambiguous (glob import vs any other name from outer scope during import/macro resolution)","code":{"code":"E0659","explanation":"\nAn item usage is ambiguous.\n\nErroneous code example:\n\n```compile_fail,E0659\npub mod moon {\n    pub fn foo() {}\n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon::*;\n    pub use earth::*;\n}\n\nfn main() {\n    collider::foo(); // ERROR: `foo` is ambiguous\n}\n```\n\nThis error generally appears when two items with the same name are imported into\na module. Here, the `foo` functions are imported and reexported from the\n`collider` module and therefore, when we're using `collider::foo()`, both\nfunctions collide.\n\nTo solve this error, the best solution is generally to keep the path before the\nitem when using it. Example:\n\n```\npub mod moon {\n    pub fn foo() {}\n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon;\n    pub use earth;\n}\n\nfn main() {\n    collider::moon::foo(); // ok!\n    collider::earth::foo(); // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/imports/glob-shadowing.rs","byte_start":795,"byte_end":798,"line_start":29,"line_end":29,"column_start":21,"column_end":24,"is_primary":true,"text":[{"text":"            let x = env!(\"PATH\"); //~ ERROR `env` is ambiguous","highlight_start":21,"highlight_end":24}],"label":"ambiguous name","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`env` could refer to a built-in macro","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/imports/glob-shadowing.rs","byte_start":0,"byte_end":0,"line_start":1,"line_end":1,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"// Copyright 2018 The Rust Project Developers. See the COPYRIGHT","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null},{"message":"`env` could also refer to the macro imported here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/imports/glob-shadowing.rs","byte_start":748,"byte_end":752,"line_start":27,"line_end":27,"column_start":13,"column_end":17,"is_primary":true,"text":[{"text":"        use m::*;","highlight_start":13,"highlight_end":17}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null},{"messageimports/local-modularized-tricky-fail-1.rs","byte_start":949,"byte_end":968,"line_start":41,"line_end":41,"column_start":5,"column_end":24,"is_primary":false,"text":[{"text":"    define_exported!();","highlight_start":5,"highlight_end":24}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"define_exported!","def_site_span":{"file_name":"/checkout/src/test/ui/imports/local-modularized-tricky-fail-1.rs","byte_start":492,"byte_end":604,"line_start":13,"line_end":18,"column_start":1,"column_end":3,"is_primary":false,"text":[{"text":"macro_rules! define_exported { () => {","highlight_start":1,"highlight_end":39},{"text":"    #[macro_export]","highlight_start":1,"highlight_end":20},{"text":"    macro_rules! exported {","highlight_start":1,"highlight_end":28},{"text":"        () => ()","highlight_start":1,"highlight_end":17},{"text":"    }","highlight_start":1,"highlight_end":6},{"text":"}}","highlight_start":1,"highlight_end":3}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[],"rendered":null},{"message":"`exported` could also refer to the macro imported here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/imports/local-modularized-tricky-fail-1.rs","byte_start":828,"byte_end":837,"line_start":32,"line_end":32,"column_start":5,"column_end":14,"is_primary":true,"text":[{"text":"use inner1::*;","highlight_start":5,"highlight_end":14}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null},{"message":"consider adding an ex {\n    pub fn foo() {}\n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon;\n    pub use earth;\n}\n\nfn main() {\n    collider::moon::foo(); // ok!\n    collider::earth::foo(); // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/imports/local-modularized-tricky-fail-1.rs","byte_start":988,"byte_end":993,"line_start":45,"line_end":45,"column_start":5,"column_end":10,"is_primary":true,"text":[{"text":"    panic!(); //~ ERROR `panic` is ambiguous","highlight_start":5,"highlight_end":10}],"label":"ambiguous name","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`panic` could refer to a macro from prelude","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/imports/local-modularized-tricky-fail-1.rs","byte_start":0,"byte_end":0,"line_start":1,"line_end":1,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"// Copyright 2018 The Rust Project Developers. See the COPYRIGHT","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null},{"message":"`panic` could also refer to the macro defined here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/imports/local-modularized-tricky-fail-1.rs","byte_start":665,"byte_end":708,"line_start":21,"line_end":23,"column_start":5,"column_end":6,"is_primary":true,"text":[{"text":"    macro_rules! panic {","highlight_start":5,"highlight_end":25},{"text":"        () => ()","highlight_start":1,"highlight_end":17},{"text":"    }","h|     panic!(); //~ ERROR `panic` is ambiguous\n   |     ^^^^^ ambiguous name\n   |\nnote: `panic` could refer to a macro from prelude\nnote: `panic` could also refer to the macro defined here\n  --> /checkout/src/test/ui/imports/local-modularized-tricky-fail-1.rs:21:5\n   |\nLL | /     macro_rules! panic {\nLL | |         () => ()\nLL | |     }\n   | |_____^\n...\nLL |       define_panic!();\n   |       ---------------- in this macro invocation\n   = help: use `self::panic` to refer to this macro unambiguously\n\n"}
[00:53:40] {"message":"`panic` is ambiguous (macro-expanded name vs less macro-expanded name from outer scope during import/macro resolution)","code":{"code":"E0659","explanation":"\nAn item usage is ambiguous.\n\nErroneous code example:\n\n```compile_fail,E0659\npub mod moon {\n    pub fn foo() {}\n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon::*;\n    pub use earth::*;\n}\n\nfn main() {\n    collider::foo(); // ERROR: `foo` is ambiguous\n}\n```\n\nThis error generally appears when two items with the same name are imported into\na module. Here, the `foo` functions are imported and reexported from the\n`collider` module and therefore, when we're using `collider::foo()`, both\nfunctions collide.\n\nTo solve this error, the best solution is generally to keep the path before the\nitem when using it. Example:\n\n```\npub mod moon {\n    pub fn foo() {}\n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon;\n    pub use earth;\n}\n\nfn main() {\n    collider::moon::foo(); // ok!\n    collider::earth::foo(); // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"<::std::macros::panic macros>","byte_start":12,"byte_end":17,"line_start":1,"line_end":1,"column_start":13,"column_end":18,"is_primary":true,"text":[{"text":"(  ) => ( { panic ! ( \"explicit panic\" ) } ) ; ( $ msg : expr ) => (","highlight_start":13,"highlight_end":18}],"label":"ambiguous name","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`panic` could refer to a macro from prelude","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/imports/local-modularized-tricky-fail-1.rs","byte_start":0,"byte_end":0,"line_start":1,"line_end":1,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"// Copyright 2018 The Rust Project Developers. See the COPYRIGHT","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null},{"message":"`panic` could also refer to the macro defined here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/imports/local-modularized-tricky-fail-1.rs","byte_start":665,"byte_end":708,"line_start":21,"line_end":23,"column_start":5,"column_end":6,"is_primary":true,"text":[{"text":"    macro_rules! panic {","highlight_start":5,"highlight_end":25},{"text":"        () => ()","highlight_start":1,"highlight_end":17},{"text":"    }","highlight_start":1,"highlight_end":6}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":{"span":{"file_name":"/checkout/src/test/ui/imports/local-modularized-tricky-fail-1.rs","byte_start":1049,"byte_end":1065,"line_start":49,"line_null,"expansion":null}],"children":[],"rendered":"error[E0433]: failed to resolve: could not find `non_last_segment` in `issue_56125`\n  --> /checkout/src/test/ui/imports/issue-56125.rs:14:22\n   |\nLL |     use issue_56125::non_last_segment::non_last_segment::*;\n   |                      ^^^^^^^^^^^^^^^^ could not find `non_last_segment` in `issue_56125`\n\n"}
[00:53:40] {"message":"unresolved import `issue_56125::last_segment`","code":{"code":"E0432","explanation":"\nAn import was unresolved.\n\nErroneous code example:\n\n```compile_fail,E0432\nuse something::Foo; // error: unresolved import `something::Foo`.\n```\n\nPaths in `use` statements are relative to the crate root. To import items\nrelative to the current and parent modules, use the `self::` and `super::`\nprefixes, respectively. Also verify that you didn't misspell the import\nname and that the import exists in the module from where you tried to\nimport it. Example:\n\n```\nuse self::something::Foo; // ok!\n\nmod something {\n    pub struct Foo;\n}\n# fn main() {}\n```\n\nOr, if you tried to use a module from an external crate, you may have missed\nthe `extern crate` declaration (which is usually placed in the crate root):\n\n```\nextern crate core; // Required to use the `core` crate\n\nuse core::any;\n# fn main() {}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/imports/issue-56125.rs","byte_start":141,"byte_end":153,"line_start":8,"line_end":8,"column_start":22,"column_end":34,"is_primary":true,"text":[{"text":"    use issue_56125::last_segment::*;","highlight_start":22,"highlight_end":34}],"label":"could not find `last_segment` in `iss25.rs:8:9\n   |\nLL |     use issue_56125::last_segment::*;\n   |         ^^^^^^^^^^^ ambiguous name\n   |\nnote: `issue_56125` could refer to an extern crate passed with `--extern`\n   = help: use `::issue_56125` to refer to this extern crate unambiguously\nnote: `issue_56125` could also refer to the module imported here\n  --> /checkout/src/test/ui/imports/issue-56125.rs:8:9\n   |\nLL |     use issue_56125::last_segment::*;\n   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   = help: use `self::issue_56125` to refer to this module unambiguously\n\n"}
[00:53:40] {"message":"`issue_56125` is ambiguous (name vs any other name during import resolution)","code":{"code":"E0659","explanation":"\nAn item usage is ambiguous.\n\nErroneous code example:\n\n```compile_fail,E0659\npub mod moon {\n    pub fn foo() {}\n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon::*;\n    pub use earth::*;\n}\n\nfn main() {\n    collider::foo(); // ERROR: `foo` is ambiguous\n}\n```\n\nThis error generally appears when two items with the same name are imported into\na module. Here, the `foo` functions are imported and reexported from the\n`collider` module and therefore, when we're using `collider::foo()`, both\nfunctions collide.\n\nTo solve this error, the best solution is generally to keep the path before the\nitem when using it. Example:\n\n```\npub mod moon {\n    pub fn foo() {}\n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon;\n    pub use earth;\n}\n\nfn main() {\n    collider::moon::foo(); // ok!\n    collider::earth::foo(); // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/c E0432`.\n"}
[00:53:40] ------------------------------------------
[00:53:40] 
[00:53:40] thread '[ui] ui/imports/issue-56125.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3282:9
[00:53:40] 
[00:53:40] 
[00:53:40] ---- [ui] ui/imports/shadow_builtin_macros.rs stdout ----
[00:53:40] diff of stderr:
[00:53:40] 
[00:53:40] 4 LL |     fn f() { panic!(); } //~ ERROR ambiguous
[00:53:40] 6    |
[00:53:40] 6    |
[00:53:40] -    = note: `panic` could refer to a macro from prelude
[00:53:40] + note: `panic` could refer to a macro from prelude
[00:53:40] 8 note: `panic` could also refer to the macro imported here
[00:53:40] 10    |
[00:53:40] 
[00:53:40] 
[00:53:40] 19 LL |     fn f() { panic!(); } //~ ERROR ambiguous
[00:53:40] 21    |
[00:53:40] 21    |
[00:53:40] -    = note: `panic` could refer to a macro from prelude
[00:53:40] + note: `panic` could refer to a macro from prelude
[00:53:40] 23 note: `panic` could also refer to the macro imported here
[00:53:40] 25    |
[00:53:40] 
[00:53:40] 
[00:53:40] 33 LL |     panic!(); //~ ERROR `panic` is ambiguous
[00:53:40] 35    |
[00:53:40] 35    |
[00:53:40] -    = note: `panic` could refer to a macro from prelude
[00:53:40] + note: `panic` could refer to a macro from prelude
[00:53:40] 37 note: `panic` could also refer to the macro defined here
[00:53:40] 39    |
[00:53:40] 
[00:53:40] 
[00:53:40] 
[00:53:h::*;\n}\n\nfn main() {\n    collider::foo(); // ERROR: `foo` is ambiguous\n}\n```\n\nThis error generally appears when two items with the same name are imported into\na module. Here, the `foo` functions are imported and reexported from the\n`collider` module and therefore, when we're using `collider::foo()`, both\nfunctions collide.\n\nTo solve this error, the best solution is generally to keep the path before the\nitem when using it. Example:\n\n```\npub mod moon {\n    pub fn foo() {}\n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon;\n    pub use earth;\n}\n\nfn main() {\n    collider::moon::foo(); // ok!\n    collider::earth::foo(); // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/imports/shadow_builtin_macros.rs","byte_start":680,"byte_end":685,"line_start":25,"line_end":25,"column_start":14,"column_end":19,"is_primary":true,"text":[{"text":"    fn f() { panic!(); } //~ ERROR ambiguous","highlight_start":14,"highlight_end":19}],"label":"ambiguous name","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`panic` could refer to a macro from prelude","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/imports/shadow_builtin_macros.rs","byte_start":0,"byte_end":0,"line_start":1,"line_end":1,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"// Copyright 2017 The Rust Project Developers. See the COPYRIGHT","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null},{"message":"`panic` could also refer to the macro imported here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/imports/shadow_builtin_macros.rs","byte_start":659,"byte_end":665,"line_start":24,"line_end":24,"column_start":9,"column_end":15,"is_primary":true,"text":[{"text":"    use foo::*;","highlight_start":9,"highlight_end":15}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null},{"message":"consider adding an explicit import of `panic` to disambiguate","code":null,"level":"help","spans":[],"children":[],"rendered":null},{"message":"or use `self::panic` to refer to this macro unambiguously","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0659]: `panic` is ambiguous (glob import vs any other name from outer scope during import/macro resolution)\n  --> /checkout/src/test/ui/imports/shadow_builtin_macros.rs:25:14\n   |\nLL |     fn f() { panic!(); } //~ ERROR ambiguous\n   |              ^^^^^ ambiguous name\n   |\nnote: `panic` could refer to a macro from prelude\nnote: `panic` could also refer to the macro imported here\n  --> /checkout/src/test/ui/imports/shadow_builtin_macros.rs:24:9\n   |\nLL |     use foo::*;\n   |         ^^^^^^\n   = help: consider adding an explicit import of `panic` to disambiguate\n   = help: or use `self::panic` to refer to this macro unambiguously\n\n"}
[00:53:40] {"message":"`panic` is ambiguous (macro-expanded name vs less macro-expanded name from outer scope during import/macro resolution)","code":{"code":"E0659","explanation":"\nAn item usage is ambiguous.\n\nErroneous code example:\n\n```compile_fail,E0659\npub mod moon {\n    pub fn foo() {}\n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon::*;\n    pub use earth::*;\n}\n\nfn main() {\n    collider::foo(); // ERROR: `foo` is ambiguous\n}\n```\n\nThis error generally appears when two items with the same name are imported into\na module. Here, the `foo` functions are imported and reexported from the\n`collider` module and therefore, when we're using `collider::foo()`, both\nfunctions collide.\n\nTo solve this error, the best solution is generally to keep the path before the\nitem when using it. Example:\n\n```\npub mod moon {\n    pub fn foo() {}\n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon;\n    pub use earth;\n}\n\nfn main() {\n    collider::moon::foo(); // ok!\n    collider::earth::foo(); // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/imports/shadow_builtin_macros.rs","byte_start":776,"byte_end":781,"line_start":30,"line_end":30,"column_start":14,"column_end":19,"is_primary":true,"text":[{"text":"    fn f() { panic!(); } //~ ERROR ambiguous","highlight_start":14,"highlight_end":19}],"label":"ambiguous name","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`panic` could refer to a macro from prelude","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/imports/shadow_builtin_macros.rs","byte_start":0,"byte_end":0,"line_start":1,"line_end":1,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"// Copyright 2017 The Rust Project Developers. See the panic` is ambiguous (macro-expanded name vs less macro-expanded name from outer scope during import/macro resolution)\n  --> /checkout/src/test/ui/imports/shadow_builtin_macros.rs:43:5\n   |\nLL |     panic!(); //~ ERROR `panic` is ambiguous\n   |     ^^^^^ ambiguous name\n   |\nnote: `panic` could refer to a macro from prelude\nnote: `panic` could also refer to the macro defined here\n  --> /checkout/src/test/ui/imports/shadow_builtin_macros.rs:40:9\n   |\nLL |         macro_rules! panic { () => {} }\n   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nLL |     } }\nLL |     m!();\n   |     ----- in this macro invocation\n\n"}
[00:53:40] {"message":"`n` is ambiguous (glob import vs any other name from outer scope during import/macro resolution)","code":{"code":"E0659","explanation":"\nAn item usage is ambiguous.\n\nErroneous code example:\n\n```compile_fail,E0659\npub mod moon {\n    pub fn foo() {}\n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon::*;\n    pub use earth::*;\n}\n\nfn main() {\n    collider::foo(); // ERROR: `foo` is ambiguous\n}\n```\n\nThis error generally appears when two items with the same name are imported into\na module. Here, the `foo` functions are imported and reexported from the\n`collider` module and therefore, when we're using `collider::foo()`, both\nfunctions collide.\n\nTo solve this error, the best solution is generally to keep the path before the\nitem when using it. Example:\n\n```\npub mod moon {\n    pub fn foo() {}\n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon;\n    pub use earth;\n}\n\nfn main() {\n    collider::moon::foo(); a built-in extern crate","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/macros/macro-path-prelude-shadowing.rs","byte_start":0,"byte_end":0,"line_start":1,"line_end":1,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"// Copyright 2018 The Rust Project Developers. See the COPYRIGHT","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null},{"message":"`std` could also refer to the module imported here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/macros/macro-path-prelude-shadowing.rs","byte_start":1063,"byte_end":1068,"line_start":37,"line_end":37,"column_start":9,"column_end":14,"is_primary":true,"text":[{"text":"    use m2::*; // glob-import user-defined `std`","highlight_start":9,"highlight_end":14}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null},{"message":"consider adding an explicit import of `std` to disambiguate","code":null,"level":"help","spans":[],"children":[],"rendered":null},{"message":"or use `self::std` to refer to this module unambiguously","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0659]: `std` is ambiguous (glob import vs any other name from outer scope during import/macro resolution)\n  --> /checkout/src/test/ui/macros/macro-path-prelude-shadowing.rs:39:9\n   |\nLL |         std::panic!(); //~ ERROR `std` is ambiguous\n   |         ^^^ ambiguous name\n   |\nnote: `std` could refer to a built-in extern crate\nnotexpected stderr.
[00:53:40] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/uniform-paths-forward-compat/ambiguity-macros-nested/ambiguity-macros-nested.stderr
[00:53:40] To update references, rerun the tests and pass the `--bless` flag
[00:53:40] To only update this specific test, also pass `--test-args rust-2018/uniform-paths-forward-compat/ambiguity-macros-nested.rs`
[00:53:40] error: 1 errors occurred comparing output.
[00:53:40] status: exit code: 1
[00:53:40] status: exit code: 1
[00:53:40] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/rust-2018/uniform-paths-forward-compat/ambiguity-macros-nested.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/uniform-paths-forward-compat/ambiguity-macros-nested/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/uniform-paths-forward-compat/ambiguity-macros-nested/auxiliary" "-A" "unused"
[00:53:40] ------------------------------------------
[00:53:40] 
[00:53:40] ------------------------------------------
[00:53:40] stderr:
[00:53:40] stderr:
[00:53:40] ------------------------------------------
[00:53:40] {"message":"`std` is ambiguous (name vs any other name during import resolution)","code":{"code":"E0659","explanation":"\nAn item usage is ambiguous.\n\nErroneous code example:\n\n```compile_fail,E0659\npub mod moon {\n    pub fn foo() {}\n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon::*;\n    pub use earth::*;\n}\n\nfn main() {\n    collider::foo(); // ERROR: `foo` is ambiguous\n}\n```\n\nThis error generally appears when two items with the same name are imported into\na module. Here, the `foo` functions are imported and reexported from the\n`collider` module and therefore, when we're using `collider::foo()`, both\nfunctions collide.\n\nTo solve this error, the best solution is generally to keep the path before the\nitem when using it. Example:\n\n```\npub mod moon {\n    pub fn foo() {}\n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon;\n    pub use earth;\n}\n\nfn main() {\n    collider::moon::foo(); // ok!\n    collider::earth::foo(); // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/uniform-paths-forward-compat/ambiguity-macros-nested.rs","byte_start":581,"byte_end":584,"line_start":16,"line_end":16,"column_start":13,"column_end":16,"is_primary":true,"text":[{"text":"    pub use std::io;","highlight_start":13,"highlight_end":16}],"label":"ambiguous name","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`std` could refer to a built-in extern crate","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/uniform-paths-forward-compat/ambiguity-macros-nested.rs","byte_start":0,"byte_end":0,"line_start":1,"line_end":1,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"// Copyright 2018 The Rust Project Developers. See the COPYRIGHT","highlight_start":n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon;\n    pub use earth;\n}\n\nfn main() {\n    collider::moon::foo(); // ok!\n    collider::earth::foo(); // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/uniform-paths-forward-compat/ambiguity-macros.rs","byte_start":570,"byte_end":573,"line_start":15,"line_end":15,"column_start":5,"column_end":8,"is_primary":true,"text":[{"text":"use std::io;","highlight_start":5,"highlight_end":8}],"label":"ambiguous name","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`std` could refer to a built-in extern crate","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/uniform-paths-forward-compat/ambiguity-macros.rs","byte_start":0,"byte_end":0,"line_start":1,"line_end":1,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"// Copyright 2018 The Rust Project Developers. See the COPYRIGHT","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null},{"message":"use `::std` to refer to this extern crate unambiguously","code":null,"level":"help","spans":[],"children":[],"rendered":null},{"message":"`std` could also refer to the module defined here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/uniform-paths-forward-compat/ambiguity-macros.rs","byte_start":647,"byte_end":693,"line_start":20,"line_end":22,"column_start":9,"column_end":10,"is_primary":true,"text":[{"text":"        mod std {","hir:
[00:53:40] ------------------------------------------
[00:53:40] {"message":"`std` is ambiguous (name vs any other name during import resolution)","code":{"code":"E0659","explanation":"\nAn item usage is ambiguous.\n\nErroneous code example:\n\n```compile_fail,E0659\npub mod moon {\n    pub fn foo() {}\n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon::*;\n    pub use earth::*;\n}\n\nfn main() {\n    collider::foo(); // ERROR: `foo` is ambiguous\n}\n```\n\nThis error generally appears when two items with the same name are imported into\na module. Here, the `foo` functions are imported and reexported from the\n`collider` module and therefore, when we're using `collider::foo()`, both\nfunctions collide.\n\nTo solve this error, the best solution is generally to keep the path before the\nitem when using it. Example:\n\n```\npub mod moon {\n    pub fn foo() {}\n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon;\n    pub use earth;\n}\n\nfn main() {\n    collider::moon::foo(); // ok!\n    collider::earth::foo(); // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/uniform-paths-forward-compat/ambiguity-nested.rs","byte_start":574,"byte_end":577,"line_start":16,"line_end":16,"column_start":13,"column_end":16,"is_primary":true,"text":[{"text":"    pub use std::io;","highlight_start":13,"highlight_end":16}],"label":"ambiguous name","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`std` could refer to a built-in extern crate","code":null,"level":"note","spans":[{"file_name":"/ch":[],"rendered":null},{"message":"use `::std` to refer to this extern crate unambiguously","code":null,"level":"help","spans":[],"children":[],"rendered":null},{"message":"`std` could also refer to the module defined here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/uniform-paths-forward-compat/ambiguity.rs","byte_start":528,"byte_end":558,"line_start":16,"line_end":18,"column_start":1,"column_end":2,"is_primary":true,"text":[{"text":"mod std {","highlight_start":1,"highlight_end":10},{"text":"    pub struct io;","highlight_start":1,"highlight_end":19},{"text":"}","highlight_start":1,"highlight_end":2}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null},{"message":"use `self::std` to refer to this module unambiguously","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0659]: `std` is ambiguous (name vs any other name during import resolution)\n  --> /checkout/src/test/ui/rust-2018/uniform-paths-forward-compat/ambiguity.rs:13:5\n   |\nLL | use std::io;\n   |     ^^^ ambiguous name\n   |\nnote: `std` could refer to a built-in extern crate\n   = help: use `::std` to refer to this extern crate unambiguously\nnote: `std` could also refer to the module defined here\n  --> /checkout/src/test/ui/rust-2018/uniform-paths-forward-compat/ambiguity.rs:16:1\n   |\nLL | / mod std {\nLL | |     pub struct io;\nLL | | }\n   | |_^\n   = help: use `self::std` to refer to this module unambiguously\n\n"}
[00:53:40] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"[00:53:40] status: exit code: 1
[00:53:40] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/rust-2018/uniform-paths/ambiguity-macros-nested.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/uniform-paths/ambiguity-macros-nested/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/uniform-paths/ambiguity-macros-nested/auxiliary" "-A" "unused"
[00:53:40] ------------------------------------------
[00:53:40] 
[00:53:40] ------------------------------------------
[00:53:40] stderr:
[00:53:40] stderr:
[00:53:40] ------------------------------------------
[00:53:40] {"message":"`std` is ambiguous (name vs any other name during import resolution)","code":{"code":"E0659","explanation":"\nAn item usage is ambiguous.\n\nErroneous code example:\n\n```compile_fail,E0659\npub mod moon {\n    pub fn foo() {}\n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon::*;\n    pub use earth::*;\n}\n\nfn main() {\n    collider::foo(); // ERROR: `foo` is ambiguous\n}\n```\n\nThis error generally appears when two items with the same name are imported into\na module. Here, the `foo` functions are imported and reexported from the\n`collider` module and therefore, when we're using `collider::foo()`, both\nfunctions collide.\n\nTo solve this error, the best solution is generally to keep the path before the\nitem when using it. Example:\n\n```\npub mod moon {\n    pub fn foo() {}\n}\n\npub mod earth {\n    pub fn foo() {}\n}\n\nmod collider {\n    pub use moon;\n    pub use earth;\n}\n\nfn main() {\n    collider::moon::foo(); // ok!\n    collider::earth::foo(); // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/uniform-paths/ambiguity-macros-nested.rs","byte_start":581,"byte_end":584,"line_start":16,"line_end":16,"column_start":13,"column_end":16,"is_primary":true,"text":[{"text":"    pub use std::io;","highlight_start":13,"highlight_end":16}],"label":"ambiguous name","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`std` could refer to a built-in extern crate","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/uniform-paths/ambiguity-macros-nested.rs","byte_start":0,"byte_end":0,"line_start":1,"line_end":1,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"// Copyright 2018 The Rust Project Developers. See the COPYRIGHT","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null},{"message":"use `::std` to refer to this extern crate unambiguously","code":null,"level":"help","spans":[],"children":[],"rendered":null},{"message":"`std` could also refer to the module defined here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/uniform-paths/ambiguity-macros-nested.rs","byte_start":674,"byte_end":728,"line_start":21,"line_end":23,"column_start":13,"columni/rust-2018/uniform-paths/ambiguity-macros.rs","byte_start":0,"byte_end":0,"line_start":1,"line_end":1,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"// Copyright 2018 The Rust Project Developers. See the COPYRIGHT","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null},{"message":"use `::std` to refer to this extern crate unambiguously","code":null,"level":"help","spans":[],"children":[],"rendered":null},{"message":"`std` could also refer to the module defined here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/uniform-paths/ambiguity-macros.rs","byte_start":647,"byte_end":693,"line_start":20,"line_end":22,"column_start":9,"column_end":10,"is_primary":true,"text":[{"text":"        mod std {","highlight_start":9,"highlight_end":18},{"text":"            pub struct io;","highlight_start":1,"highlight_end":27},{"text":"        }","highlight_start":1,"highlight_end":10}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":{"span":{"file_name":"/checkout/src/test/ui/rust-2018/uniform-paths/ambiguity-macros.rs","byte_start":702,"byte_end":707,"line_start":25,"line_end":25,"column_start":1,"column_end":6,"is_primary":false,"text":[{"text":"m!();","highlight_start":1,"highlight_end":6}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"m!","def_site_span":{"file_name":"/checkout/src/test/ui/rust-2018/uniform-paths/ambiguity-macros.rs","byte_start":610,"byte_end":701,"line_start"n}\n\nmod collider {\n    pub use moon;\n    pub use earth;\n}\n\nfn main() {\n    collider::moon::foo(); // ok!\n    collider::earth::foo(); // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/uniform-paths/ambiguity-nested.rs","byte_start":574,"byte_end":577,"line_start":16,"line_end":16,"column_start":13,"column_end":16,"is_primary":true,"text":[{"text":"    pub use std::io;","highlight_start":13,"highlight_end":16}],"label":"ambiguous name","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`std` could refer to a built-in extern crate","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/uniform-paths/ambiguity-nested.rs","byte_start":0,"byte_end":0,"line_start":1,"line_end":1,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"// Copyright 2018 The Rust Project Developers. See the COPYRIGHT","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null},{"message":"use `::std` to refer to this extern crate unambiguously","code":null,"level":"help","spans":[],"children":[],"rendered":null},{"message":"`std` could also refer to the module defined here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/rust-2018/uniform-paths/ambiguity-nested.rs","byte_start":622,"byte_end":660,"line_start":19,"line_end":21,"column_start":5,"column_end":6,"is_primary":true,"text":[{"text":"    mod std {","highlight_start":5,"highlight_end":14},{"text":"        pub struct io;","highlight_n extern crate\n   = help: use `::std` to refer to this extern crate unambiguously\nnote: `std` could also refer to the module defined here\n  --> /checkout/src/test/ui/rust-2018/uniform-paths/ambiguity.rs:16:1\n   |\nLL | / mod std {\nLL | |     pub struct io;\nLL | | }\n   | |_^\n   = help: use `self::std` to refer to this module unambiguously\n\n"}
[00:53:40] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[00:53:40] {"message":"For more information about this error, try `rustc --explain E0659`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0659`.\n"}
[00:53:40] ------------------------------------------
[00:53:40] 
[00:53:40] thread '[ui] ui/rust-2018/uniform-paths/ambiguity.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3282:9
[00:53:40] 
---
[00:53:40] 
[00:53:40] 
[00:53:40] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:53:40] Build completed unsuccessfully in 0:04:00
[00:53:40] Makefile:58: recipe for target 'check' failed
[00:53:40] make: *** [check] Error 1
127444 ./.git/modules
127440 ./.git/modules/src
123692 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps
115736 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/release

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment has been minimized.

Contributor

bors commented Nov 27, 2018

☔️ The latest upstream changes (presumably #56262) made this pull request unmergeable. Please resolve the merge conflicts.

@TimNN

This comment has been minimized.

Contributor

TimNN commented Dec 4, 2018

Ping from triage @varkor: This PR requires your review.

Ping form triage @estebank: It looks like your PR failed on travis and needs a rebase.

@varkor

This comment has been minimized.

Member

varkor commented Dec 5, 2018

Sorry, I was putting off looking at this because I saw it was marked as "WIP". Is this ready to review now?

@estebank

This comment has been minimized.

Contributor

estebank commented Dec 5, 2018

I'll come back to this soon. I need to add some code to special case the emitter so the notes appear indented instead as left aligned when span == DUMMY_SP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment