Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize local linkchecker program #56360

Merged
merged 1 commit into from Nov 30, 2018

Conversation

Reviewers
No reviews
Assignees

@pietroalbini pietroalbini

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
5 participants
@alexcrichton @rust-highfive @pietroalbini @bors @aturon
@alexcrichton
Copy link
Member

alexcrichton commented Nov 29, 2018

I noticed on a recent build that the linkchecker stage of CI took a
whopping 15 minutes of CI time for something that should be near
instantaneous. Some local profiling showed some very hot functions and
clones which were pretty easy to remove, and now instead of running in
minutes locally it runs in seconds.
@alexcrichton
Optimize local linkchecker program 
I noticed on a [recent build][1] that the linkchecker stage of CI took a
whopping 15 minutes of CI time for something that should be near
instantaneous. Some local profiling showed some very hot functions and
clones which were pretty easy to remove, and now instead of running in
minutes locally it runs in seconds.

[1]: https://ci.appveyor.com/project/rust-lang/rust/build/job/kptifw1kb1nm4xuu
Loading status checks…
225140e

@rust-highfive rust-highfive assigned aturon Nov 29, 2018

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Nov 29, 2018

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review label Nov 29, 2018

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Nov 29, 2018

r? @pietroalbini

@rust-highfive rust-highfive assigned pietroalbini and unassigned aturon Nov 29, 2018

@pietroalbini

This comment has been minimized.

Sign in to view
Copy link
Member

pietroalbini commented Nov 29, 2018

@bors r+

Thanks!
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Nov 29, 2018

📌 Commit 225140e has been approved by pietroalbini

@bors bors added S-waiting-on-bors and removed S-waiting-on-review labels Nov 29, 2018

kennytm added a commit to kennytm/rust that referenced this pull request Nov 30, 2018

@kennytm
Rollup merge of rust-lang#56360 - alexcrichton:linkchecker-omg, r=pie… 
…troalbini

Optimize local linkchecker program

I noticed on a [recent build][1] that the linkchecker stage of CI took a
whopping 15 minutes of CI time for something that should be near
instantaneous. Some local profiling showed some very hot functions and
clones which were pretty easy to remove, and now instead of running in
minutes locally it runs in seconds.

[1]: https://ci.appveyor.com/project/rust-lang/rust/build/job/kptifw1kb1nm4xuu
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
b650cce

@kennytm kennytm referenced this pull request Nov 30, 2018

Closed

Rollup of 16 pull requests #56376

bors added a commit that referenced this pull request Nov 30, 2018

@bors
Auto merge of #56376 - kennytm:rollup, r=kennytm 
Rollup of 16 pull requests

Successful merges:

 - #55821 (Use sort_by_cached_key when the key function is not trivial/free)
 - #56014 (add test for issue #21335)
 - #56131 (Assorted tweaks)
 - #56216 (Add TryFrom<&[T]> for [T; $N] where T: Copy)
 - #56224 (Update cargo)
 - #56268 (Reuse the `P` in `InvocationCollector::fold_{,opt_}expr`.)
 - #56285 (move stage0.txt to toplevel directory)
 - #56305 (update miri)
 - #56336 (Clean up and streamline the pretty-printer)
 - #56339 (Remove not used option)
 - #56341 (Rename conversion util; remove duplicate util in librustc_codegen_llvm.)
 - #56349 (rustc 1.30.0's linker flavor inference is a non-backwards compat change to -Clinker)
 - #56355 (Add inline attributes and add unit to CommonTypes)
 - #56360 (Optimize local linkchecker program)
 - #56364 (Fix panic with outlives in existential type)
 - #56373 (Update books)

Failed merges:

r? @ghost
Loading status checks…
75b0d85

kennytm added a commit to kennytm/rust that referenced this pull request Nov 30, 2018

@kennytm
Rollup merge of rust-lang#56360 - alexcrichton:linkchecker-omg, r=pie… 
…troalbini

Optimize local linkchecker program

I noticed on a [recent build][1] that the linkchecker stage of CI took a
whopping 15 minutes of CI time for something that should be near
instantaneous. Some local profiling showed some very hot functions and
clones which were pretty easy to remove, and now instead of running in
minutes locally it runs in seconds.

[1]: https://ci.appveyor.com/project/rust-lang/rust/build/job/kptifw1kb1nm4xuu
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
941aeaa

@kennytm kennytm referenced this pull request Nov 30, 2018

Merged

Rollup of 19 pull requests #56381

kennytm added a commit to kennytm/rust that referenced this pull request Nov 30, 2018

@kennytm
Rollup merge of rust-lang#56360 - alexcrichton:linkchecker-omg, r=pie… 
…troalbini

Optimize local linkchecker program

I noticed on a [recent build][1] that the linkchecker stage of CI took a
whopping 15 minutes of CI time for something that should be near
instantaneous. Some local profiling showed some very hot functions and
clones which were pretty easy to remove, and now instead of running in
minutes locally it runs in seconds.

[1]: https://ci.appveyor.com/project/rust-lang/rust/build/job/kptifw1kb1nm4xuu
Verified
This commit was signed with a verified signature.
@kennytm kennytm
GPG key ID: FEF6C8051D0E013C Learn about signing commits
2cd82d9

kennytm added a commit to kennytm/rust that referenced this pull request Nov 30, 2018

@kennytm
Rollup merge of rust-lang#56360 - alexcrichton:linkchecker-omg, r=pie… 
…troalbini

Optimize local linkchecker program

I noticed on a [recent build][1] that the linkchecker stage of CI took a
whopping 15 minutes of CI time for something that should be near
instantaneous. Some local profiling showed some very hot functions and
clones which were pretty easy to remove, and now instead of running in
minutes locally it runs in seconds.

[1]: https://ci.appveyor.com/project/rust-lang/rust/build/job/kptifw1kb1nm4xuu
Verified
This commit was signed with a verified signature.
@kennytm kennytm
GPG key ID: FEF6C8051D0E013C Learn about signing commits
ddc7ef2

bors added a commit that referenced this pull request Nov 30, 2018

@bors
Auto merge of #56381 - kennytm:rollup, r=kennytm 
Rollup of 19 pull requests

Successful merges:

 - #55011 (Add libstd Cargo feature "panic_immediate_abort")
 - #55821 (Use sort_by_cached_key when the key function is not trivial/free)
 - #56014 (add test for issue #21335)
 - #56131 (Assorted tweaks)
 - #56214 (Implement chalk unification routines)
 - #56216 (Add TryFrom<&[T]> for [T; $N] where T: Copy)
 - #56268 (Reuse the `P` in `InvocationCollector::fold_{,opt_}expr`.)
 - #56324 (Use raw_entry for more efficient interning)
 - #56336 (Clean up and streamline the pretty-printer)
 - #56337 (Fix const_fn ICE with non-const function pointer)
 - #56339 (Remove not used option)
 - #56341 (Rename conversion util; remove duplicate util in librustc_codegen_llvm.)
 - #56349 (rustc 1.30.0's linker flavor inference is a non-backwards compat change to -Clinker)
 - #56355 (Add inline attributes and add unit to CommonTypes)
 - #56360 (Optimize local linkchecker program)
 - #56364 (Fix panic with outlives in existential type)
 - #56365 (Stabilize self_struct_ctor feature.)
 - #56367 (Moved some feature gate tests to correct location)
 - #56373 (Update books)
Loading status checks…
d09466c

@bors bors merged commit 225140e into rust-lang:master Nov 30, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexcrichton alexcrichton deleted the alexcrichton:linkchecker-omg branch Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.