Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upci: Only run compare-mode tests on one builder #56391
Conversation
rust-highfive
assigned
aturon
Nov 30, 2018
This comment has been minimized.
This comment has been minimized.
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
label
Nov 30, 2018
This comment has been minimized.
This comment has been minimized.
rust-highfive
assigned
Mark-Simulacrum
and unassigned
aturon
Nov 30, 2018
This comment has been minimized.
This comment has been minimized.
|
Looks solid to me. @bors r+ p=1 (Feel free to bump priority down, but I feel like this should help queue move faster) |
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-bors
and removed
S-waiting-on-review
labels
Nov 30, 2018
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Nov 30, 2018
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-review
and removed
S-waiting-on-bors
labels
Dec 1, 2018
This comment has been minimized.
This comment has been minimized.
|
@bors: retry |
bors
added
S-waiting-on-bors
and removed
S-waiting-on-review
labels
Dec 1, 2018
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Dec 1, 2018
This comment has been minimized.
This comment has been minimized.
|
|
bors
merged commit 8ee62bb
into
rust-lang:master
Dec 1, 2018
alexcrichton
deleted the
alexcrichton:less-compare-mode
branch
Dec 17, 2018
pnkfelix
referenced this pull request
Jan 25, 2019
Merged
[NLL] Clean up handling of type annotations #57714
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alexcrichton commentedNov 30, 2018
The run-pass test suite currently takes 30 minutes on Windows, and
that appears to be roughly split between two 15 minute runs of the test
suite: one without NLL and one with NLL. In discussion on Discord the
platform coverage of the NLL compare mode may not necessarily be worth
it, so this commit removes the NLL compare mode from tests by default,
and then reenables it on only one builder.