Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upStabilize dbg!(...) #56395
Conversation
Centril
added
the
relnotes
label
Dec 1, 2018
rust-highfive
assigned
SimonSapin
Dec 1, 2018
rust-highfive
added
the
S-waiting-on-review
label
Dec 1, 2018
Centril
referenced this pull request
Dec 1, 2018
Closed
Tracking issue for RFC 2361, "Simpler alternative dbg!() macro" #54306
This comment has been minimized.
This comment has been minimized.
|
@bors r+ rollup |
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-bors
and removed
S-waiting-on-review
labels
Dec 1, 2018
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Dec 1, 2018
bors
added a commit
that referenced
this pull request
Dec 1, 2018
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 1, 2018
bors
added a commit
that referenced
this pull request
Dec 2, 2018
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 2, 2018
bors
added a commit
that referenced
this pull request
Dec 2, 2018
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 2, 2018
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 2, 2018
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 2, 2018
bors
added a commit
that referenced
this pull request
Dec 2, 2018
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 2, 2018
bors
added a commit
that referenced
this pull request
Dec 2, 2018
This comment has been minimized.
This comment has been minimized.
|
@bors rollup- |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Dec 3, 2018
bors
added a commit
that referenced
this pull request
Dec 3, 2018
bors
merged commit f4cde5b
into
rust-lang:master
Dec 3, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Centril
deleted the
Centril:stabilize-dbg-macro
branch
Dec 3, 2018
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 19, 2019
This comment has been minimized.
This comment has been minimized.
RoelKluin
commented
Jan 22, 2019
|
I wonder whether this alternative implementation that optionally allows formatting may be of use: |
This comment has been minimized.
This comment has been minimized.
|
@RoelKluin you might want to raise this issue somewhere more visible for new discussion, e.g. http://internals.rust-lang.org/. My view is that extra arguments should be for passing more values, that no guarantees should be made about formatting, and that formatting choices is better served by a different macro. You may try out the more advanced macro in https://crates.io/crates/dbg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Centril commentedDec 1, 2018
Per FCP in #54306 (which is ~1 day from completion).
r? @SimonSapin
The PR is fairly isolated so a rollup should probably work.