Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] Add a few critical fixes to the 1.31.0 release #56518

Merged
merged 4 commits into from Dec 5, 2018

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
8 participants
@pietroalbini @rust-highfive @alexcrichton @bors @Geal @oli-obk @matthewjasper @steveklabnik
@pietroalbini
Copy link
Member

pietroalbini commented Dec 4, 2018 •
edited

This PR cherry-picks the following PRs to stable:

  • #56467: Bump stack size to 32MB
  • #56486: Propagate all closure requirements to the caller
  • #56519: update edition guide

The changes will be included in the final 1.31.0 binary (to avoid a point release). To deploy the build to dev-static the old manifest needs to be removed from the bucket after the PR is merged.

cc @rust-lang/core @rust-lang/release @rust-lang/compiler
r? @alexcrichton

oli-obk and others added some commits Dec 3, 2018

@oli-obk @pietroalbini
Bump stack size to 32MB
Verified
This commit was signed with a verified signature.
@pietroalbini pietroalbini Pietro Albini
GPG key ID: 3E06ABE80BAAF19C Learn about signing commits
ddeda45
@matthewjasper @pietroalbini
Propagate all closure requirements to the caller
Verified
This commit was signed with a verified signature.
@pietroalbini pietroalbini Pietro Albini
GPG key ID: 3E06ABE80BAAF19C Learn about signing commits
6b4e297
@matthewjasper @pietroalbini
Call methods on the right tcx 
There are two `TyCtxt`s, one global, one local. Methods must be called
on the right one, as they differ by invariant lifetimes.
Verified
This commit was signed with a verified signature.
@pietroalbini pietroalbini Pietro Albini
GPG key ID: 3E06ABE80BAAF19C Learn about signing commits
Loading status checks…
f41b48a

@rust-highfive rust-highfive assigned alexcrichton Dec 4, 2018

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Dec 4, 2018

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review label Dec 4, 2018

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Dec 4, 2018

@bors: r+ p=1000
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 4, 2018

📌 Commit f41b48a has been approved by alexcrichton

@bors bors added S-waiting-on-bors and removed S-waiting-on-review labels Dec 4, 2018

This was referenced Dec 4, 2018

Merged
Merged
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 4, 2018

⌛️ Testing commit f41b48a with merge 55a0c79...

bors added a commit that referenced this pull request Dec 4, 2018

@bors
Auto merge of #56518 - pietroalbini:stable-additions, r=alexcrichton 
[stable] Add a few critical fixes to the 1.31.0 release

This PR cherry-picks the following PRs to stable:

* #56467: Bump stack size to 32MB
* #56486: Propagate all closure requirements to the caller

The changes will be included in the final 1.31.0 binary (to avoid a point release). To deploy the build to dev-static the old manifest needs to be removed from the bucket after the PR is merged.

cc @rust-lang/core @rust-lang/release @rust-lang/compiler
r? @alexcrichton
Loading status checks…
55a0c79
@steveklabnik @pietroalbini
build the edition guide 
and update it so that links are correct
Verified
This commit was signed with a verified signature.
@pietroalbini pietroalbini Pietro Albini
GPG key ID: 3E06ABE80BAAF19C Learn about signing commits
Loading status checks…
6d54f6d
@pietroalbini

This comment has been minimized.

Sign in to view
Copy link
Member Author

pietroalbini commented Dec 4, 2018

@bors r-

@bors bors added S-waiting-on-author and removed S-waiting-on-bors labels Dec 4, 2018

@pietroalbini

This comment has been minimized.

Sign in to view
Copy link
Member Author

pietroalbini commented Dec 4, 2018

@bors retry

@bors bors added S-waiting-on-bors and removed S-waiting-on-author labels Dec 4, 2018

@pietroalbini

This comment has been minimized.

Sign in to view
Copy link
Member Author

pietroalbini commented Dec 4, 2018

Added #56519

@bors r+ p=1000
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 4, 2018

📌 Commit 6d54f6d has been approved by pietroalbini
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 4, 2018

⌛️ Testing commit 6d54f6d with merge abe02ce...

bors added a commit that referenced this pull request Dec 4, 2018

@bors
Auto merge of #56518 - pietroalbini:stable-additions, r=pietroalbini 
[stable] Add a few critical fixes to the 1.31.0 release

This PR cherry-picks the following PRs to stable:

* #56467: Bump stack size to 32MB
* #56486: Propagate all closure requirements to the caller
* #56519: update edition guide

The changes will be included in the final 1.31.0 binary (to avoid a point release). To deploy the build to dev-static the old manifest needs to be removed from the bucket after the PR is merged.

cc @rust-lang/core @rust-lang/release @rust-lang/compiler
r? @alexcrichton
Loading status checks…
abe02ce

@pietroalbini pietroalbini referenced this pull request Dec 4, 2018

Closed

1.31 announcement #295

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 5, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: pietroalbini
Pushing abe02ce to stable...

@bors bors merged commit 6d54f6d into rust-lang:stable Dec 5, 2018
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Geal

This comment has been minimized.

Sign in to view
Copy link
Contributor

Geal commented Dec 5, 2018

this might fix #55390, I'll test with this nightly

@pietroalbini pietroalbini deleted the pietroalbini:stable-additions branch Dec 5, 2018

@pnkfelix pnkfelix referenced this pull request Dec 13, 2018

Closed

regression: stack overflow on macosx with xcode 6.4 #55471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.