New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve: Reduce some clutter in import ambiguity errors #56620

Merged
merged 1 commit into from Dec 8, 2018

Conversation

Projects
None yet
5 participants
@petrochenkov
Copy link
Contributor

petrochenkov commented Dec 8, 2018

Noticed in https://www.reddit.com/r/rust/comments/a3pyrw/announcing_rust_131_and_rust_2018/eb8alhi/.
The first error is distracting, but unnecessary, it's a consequence of the ambiguity error and appears because one of the ambiguous actix modules (unsurprisingly) doesn't have the expected name in it.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 8, 2018

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Dec 8, 2018

@rust-highfive rust-highfive assigned estebank and unassigned pnkfelix Dec 8, 2018

@estebank

This comment has been minimized.

Copy link
Contributor

estebank commented Dec 8, 2018

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 8, 2018

📌 Commit 2010b4f has been approved by estebank

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Dec 8, 2018

@bors rollup

Centril added a commit to Centril/rust that referenced this pull request Dec 8, 2018

Rollup merge of rust-lang#56620 - petrochenkov:noclutter, r=estebank
resolve: Reduce some clutter in import ambiguity errors

Noticed in https://www.reddit.com/r/rust/comments/a3pyrw/announcing_rust_131_and_rust_2018/eb8alhi/.
The first error is distracting, but unnecessary, it's a *consequence* of the ambiguity error and appears because one of the ambiguous `actix` modules (unsurprisingly) doesn't have the expected name in it.

@Centril Centril referenced this pull request Dec 8, 2018

Merged

Rollup of 6 pull requests #56623

bors added a commit that referenced this pull request Dec 8, 2018

Auto merge of #56623 - Centril:rollup, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #56248 (Suggest an appropriate token when encountering `pub Ident<'a>`)
 - #56597 (Improve the usage message for `-Z dump-mir`.)
 - #56599 (codegen: Fix va_list - aarch64 iOS/Windows)
 - #56602 (Fix the just-introduced ptr::hash docs)
 - #56620 (resolve: Reduce some clutter in import ambiguity errors)
 - #56621 (Add missing comma in Generators)

Failed merges:

r? @ghost

@bors bors merged commit 2010b4f into rust-lang:master Dec 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment