New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mir-opt: Make SimplifyCfg collapse goto chains starting from bb0 #56764

Merged
merged 1 commit into from Dec 17, 2018

Conversation

Projects
None yet
5 participants
@sinkuu
Copy link
Contributor

sinkuu commented Dec 13, 2018

SimplifyCfg pass was not able to collapse goto chains starting from bb0, leaving MIR like this:

bb0: {
    goto -> bb1;
}
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 13, 2018

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@sinkuu sinkuu force-pushed the sinkuu:simpcfg_bb0 branch from 8616f74 to 83298a2 Dec 13, 2018

@wesleywiser
Copy link
Member

wesleywiser left a comment

Nice job! Lgtm but I'd like somebody else to review as well.

@matthewjasper

This comment has been minimized.

Copy link
Contributor

matthewjasper commented Dec 16, 2018

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 16, 2018

📌 Commit 83298a2 has been approved by matthewjasper

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 17, 2018

⌛️ Testing commit 83298a2 with merge 7fb479c...

bors added a commit that referenced this pull request Dec 17, 2018

Auto merge of #56764 - sinkuu:simpcfg_bb0, r=matthewjasper
mir-opt: Make SimplifyCfg collapse goto chains starting from bb0

`SimplifyCfg` pass was not able to collapse goto chains starting from bb0, leaving MIR like this:

```
bb0: {
    goto -> bb1;
}
```
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 17, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: matthewjasper
Pushing 7fb479c to master...

@bors bors merged commit 83298a2 into rust-lang:master Dec 17, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@sinkuu sinkuu deleted the sinkuu:simpcfg_bb0 branch Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment