New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize termination_trait_lib #56791

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@llogiq
Copy link
Contributor

llogiq commented Dec 13, 2018

This is a prerequisite to #56470

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 13, 2018

r? @KodrAus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 13, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:141f0511:start=1544735260886422528,finish=1544735261896761327,duration=1010338799
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:04:15] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--message-format" "json"
[00:04:15] expected success, got: exit code: 101
[00:04:15] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:04:15] Build completed unsuccessfully in 0:00:49
[00:04:15] make: *** [all] Error 1
[00:04:15] Makefile:28: recipe for target 'all' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:09ac9717
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Thu Dec 13 21:12:06 UTC 2018
---
travis_time:end:10fabd28:start=1544735526951403983,finish=1544735526956935123,duration=5531140
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1981ff80
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0c0d11a8
travis_time:start:0c0d11a8
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:004715d0
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@llogiq

This comment has been minimized.

Copy link
Contributor

llogiq commented Dec 14, 2018

Error seems unrelated. Any ideas?

@sinkuu

This comment has been minimized.

Copy link
Contributor

sinkuu commented Dec 14, 2018

[00:04:15] error: This node does not have a stability attribute
[00:04:15] --> src/libstd/process.rs:1593:5
[00:04:15] |
[00:04:15] 1593 | fn report(self) -> i32;
[00:04:15] | ^^^^^^^^^^^^^^^^^^^^^^^
[00:04:15]
[00:04:15] error: aborting due to previous error
[00:04:15]
[00:04:15] error: Could not compile std.

@llogiq llogiq force-pushed the llogiq:stabilize_termination_trait_lib branch from 5a8f0be to 6e2119e Dec 14, 2018

@Centril Centril added I-nominated and removed I-nominated labels Dec 15, 2018

@cramertj

This comment has been minimized.

Copy link
Member

cramertj commented Dec 20, 2018

@llogiq If you're interested in stabilizing, would you be able to write up a stabilization report on the tracking issue? The lang team isn't sure about whether or not this feature is ready for stabilization, and we'd like to see an update on where the feature is and why it's being proposed for stabilization.

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Dec 20, 2018

Note: maybe there is another way to achieve the goals w/o stabilization? (Or with a narrow stabilization)

@Dylan-DPC

This comment has been minimized.

Copy link
Member

Dylan-DPC commented Jan 21, 2019

ping from triage @llogiq any updates on this?

@llogiq

This comment has been minimized.

Copy link
Contributor

llogiq commented Jan 23, 2019

On second thought, I agree that it's probably too early to stabilize. Besides I found a way to accept Results in doctests without this feature, so this doesn't block anything. Closing this for now.

@llogiq llogiq closed this Jan 23, 2019

@llogiq llogiq deleted the llogiq:stabilize_termination_trait_lib branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment