New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Activate compiler_builtins `mem` feature for no_std targets #56825

Merged
merged 1 commit into from Dec 15, 2018

Conversation

Projects
None yet
4 participants
@alexcrichton
Copy link
Member

alexcrichton commented Dec 14, 2018

This was an accidental regression from #56092, but for no_std targets
being built and distributed we want to be sure to activate the
compiler-builtins mem feature which demangles important memory-related
intrinsics.

std: Activate compiler_builtins `mem` feature for no_std targets
This was an accidental regression from #56092, but for `no_std` targets
being built and distributed we want to be sure to activate the
compiler-builtins `mem` feature which demangles important memory-related
intrinsics.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 14, 2018

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Dec 14, 2018

@bors: p=1

(fixing a regression)

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Dec 14, 2018

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 14, 2018

📌 Commit c811915 has been approved by nikomatsakis

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 15, 2018

⌛️ Testing commit c811915 with merge bcf920f...

bors added a commit that referenced this pull request Dec 15, 2018

Auto merge of #56825 - alexcrichton:demangle-mem, r=nikomatsakis
std: Activate compiler_builtins `mem` feature for no_std targets

This was an accidental regression from #56092, but for `no_std` targets
being built and distributed we want to be sure to activate the
compiler-builtins `mem` feature which demangles important memory-related
intrinsics.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 15, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing bcf920f to master...

@bors bors merged commit c811915 into rust-lang:master Dec 15, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@alexcrichton alexcrichton deleted the alexcrichton:demangle-mem branch Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment