New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add targets thumbv7neon-linux-androideabi and thumbv7neon-unknown-linux-gnueabihf #56947

Merged
merged 1 commit into from Dec 19, 2018

Conversation

Projects
None yet
6 participants
@hsivonen
Copy link
Contributor

hsivonen commented Dec 18, 2018

These two targets enable both thumb-mode and NEON for ARMv7 CPUs.

This another attempt at #49902, which cannot be reopened. Between that PR and this one, some subrepos with C code whose build systems were failing went away.

Add targets thumbv7neon-linux-androideabi and thumbv7neon-unknown-lin…
…ux-gnueabihf

These two targets enable both thumb-mode and NEON for ARMv7 CPUs.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 18, 2018

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@estebank

This comment has been minimized.

Copy link
Contributor

estebank commented Dec 18, 2018

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Dec 18, 2018

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 18, 2018

📌 Commit 0fbe382 has been approved by alexcrichton

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Dec 19, 2018

Rollup merge of rust-lang#56947 - hsivonen:neon, r=alexcrichton
Add targets thumbv7neon-linux-androideabi and thumbv7neon-unknown-linux-gnueabihf

These two targets enable both thumb-mode and NEON for ARMv7 CPUs.

This another attempt at rust-lang#49902, which cannot be reopened. Between that PR and this one, some subrepos with C code whose build systems were failing went away.

bors added a commit that referenced this pull request Dec 19, 2018

Auto merge of #56977 - pietroalbini:rollup, r=pietroalbini
Rollup of 15 pull requests

Successful merges:

 - #56363 (Defactored Bytes::read)
 - #56663 (Remove lifetime from Resolver)
 - #56689 (add a lint group for lints emitted by rustdoc)
 - #56772 (fix issue 54153 by not testing issue-18804 on Windows nor OS X.)
 - #56820 (format-related tweaks)
 - #56881 (Implement Eq, PartialEq and Hash for atomic::Ordering)
 - #56907 (Fix grammar in compiler error for array iterators)
 - #56908 (rustc: Don't ICE on usage of two new target features)
 - #56910 (Do not point at delim spans for complete correct blocks)
 - #56913 (Enable stack probes for UEFI images)
 - #56918 (Profiler: simplify total_duration, improve readability)
 - #56931 (Update release notes for Rust 1.31.1)
 - #56947 (Add targets thumbv7neon-linux-androideabi and thumbv7neon-unknown-linux-gnueabihf)
 - #56948 (Update LLVM submodule)
 - #56959 (Fix mobile menu rendering collision with tooltip.)

Failed merges:

 - #56914 (Ignore ui/target-feature-gate on sparc, sparc64, powerpc, powerpc64 and powerpc64le)

r? @ghost

@bors bors merged commit 0fbe382 into rust-lang:master Dec 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hsivonen

This comment has been minimized.

Copy link
Contributor

hsivonen commented Dec 20, 2018

Filed a follow-up about rust-std availability for these targets via rustup.

@hsivonen

This comment has been minimized.

Copy link
Contributor

hsivonen commented Dec 20, 2018

And thanks for getting this landed!

@SimonSapin

This comment has been minimized.

Copy link
Contributor

SimonSapin commented Dec 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment