New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel query tweaks #56983

Merged
merged 4 commits into from Dec 25, 2018

Conversation

Projects
None yet
5 participants
@ljedrz
Copy link
Contributor

ljedrz commented Dec 19, 2018

  • faster stack reversal in remove_cycle
  • insert visited queries more eagerly
  • simplify stack trimming in cycle_check
  • minor refactoring in 2 spots
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 19, 2018

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@michaelwoerister

This comment has been minimized.

Copy link
Contributor

michaelwoerister commented Dec 19, 2018

r? @Zoxc (who knows this code best)

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Dec 21, 2018

@ljedrz Did this pass tests locally with [rust] experimental-parallel-queries = true?

@ljedrz

This comment has been minimized.

Copy link
Contributor

ljedrz commented Dec 21, 2018

@Zoxc sure did; when I saw their recent performance wins I decided to keep it that way. We can always do a try run for added safety.

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Dec 25, 2018

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 25, 2018

📌 Commit dfe187d has been approved by Zoxc

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 25, 2018

⌛️ Testing commit dfe187d with merge 27c4335...

bors added a commit that referenced this pull request Dec 25, 2018

Auto merge of #56983 - ljedrz:parallel_query_tweaks, r=Zoxc
Parallel query tweaks

- faster stack reversal in `remove_cycle`
- insert visited queries more eagerly
- simplify stack trimming in `cycle_check`
- minor refactoring in 2 spots
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 25, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Zoxc
Pushing 27c4335 to master...

@bors bors merged commit dfe187d into rust-lang:master Dec 25, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@ljedrz ljedrz deleted the ljedrz:parallel_query_tweaks branch Dec 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment